rafaelmardojai / forge-sparks

Get git forges notifications

Hi there 👋

I'm a Web Developer working on open source projects in my free time, mainly GNOME desktop related projects.

I work on nice native GNOME apps and also develop themes to integrate popular software with GNOME.

Apps for GNOME

• Blanket
• Dialect (co-maintainer)
• Forge Sparks
• Share Preview
• Webfont Kit Generator
• Diccionario de la Lengua

GNOME integration themes

• Firefox GNOME theme
• Thunderbird GNOME theme

If you want to support my work, you can donate me, here you can find how.

forge-sparks's Issues

Icon for Forge Sparks

An anvil and hammer with sparks would be the first metaphor I can imagine.

Option to keep read notifications

Sometimes I read notifications but want to keep them to visit them at a later point in time.
It would be helpful to have the read notifications stay visible with a manual "dismiss" action button. This could be something configurable in the settings to keep the current behaviour intact aswell.

Would something like this be in scope for Forge Sparks or is this something against this projects goal? :)

[Flatpak] Can't add account / access secrets store

On my system (sway+xdg-desktop-portal-wlr) using the flatpak it's not possible to add an account because it seems to be missing access to the secrets store.

com.mardojai.ForgeSparks-Message: 11:45:48.857: Gio.DBusError: org.freedesktop.DBus.Error.ServiceUnknown
_promisify/proto[asyncFunc]/</<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:454:44
main@resource://com/mardojai/ForgeSparks/main.js:28:24
run@resource:///org/gnome/gjs/modules/script/package.js:206:19
@file:///app/bin/forge-sparks:28:43
@file:///app/bin/forge-sparks:34:6
### Promise created here: ###
saveAccount@resource:///com/mardojai/ForgeSparks/model/accountsManager.js:145:42
_addAccount@resource:///com/mardojai/ForgeSparks/widgets/accountDialog.js:325:32
async*_onSave@resource:///com/mardojai/ForgeSparks/widgets/accountDialog.js:300:18
main@resource://com/mardojai/ForgeSparks/main.js:28:24
run@resource:///org/gnome/gjs/modules/script/package.js:206:19
@file:///app/bin/forge-sparks:28:43
@file:///app/bin/forge-sparks:34:6

However, it works when run with:

flatpak run --talk-name=org.freedesktop.secrets com.mardojai.ForgeSparks

[ Feature request ] Codeberg

It would be nice to have access to the Codeberg.org's notifications. The page seems to be a modded Gitea instance, but sadly the Forge Sparks does not work w/ it. 😞

Oh, and thank you for your work. This app is awesome! 🥳

[feat] Implement interacting with each notification separately

Currently the only write action is "Mark all read". I was hoping that this application would allow me to finally quit GitHub's Notification UI. For that I would need at least a "mark as read" button on each notification.

Thanks for the cool app!

Add GitLab support

Error when adding Gitea account with access token that lacks `read:user` permission

Adding a Gitea instance with an access token that just has the notifications permission results in "Unexpected error when creating the account" being shown in the app. The log shows:

com.mardojai.ForgeSparks-Message: 10:24:46.276: Error: Expected type string for argument 'value' but got type undefined
createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:730:46
saveAccount@resource:///com/mardojai/ForgeSparks/model/accountsManager.js:165:33
async*_onAddAccount@resource:///com/mardojai/ForgeSparks/preferences.js:399:28
Async*main@resource://com/mardojai/ForgeSparks/main.js:28:24
run@resource:///org/gnome/gjs/modules/script/package.js:206:19
@file:///app/bin/forge-sparks:28:43
@file:///app/bin/forge-sparks:34:6

The app did actually save the newly added account, though it only seems to show up when quitting and re-opening the app. It then also shows up in the Accounts list with a missing username, which also exposes the root if the issue; when also giving access to the read:user permission, everything works exactly as expected.

(Thanks so much for building this app! I'm giving it a try to see if I can maybe finally stop getting so many darn emails from Github 😅)

some github notifications have incorrect links

When clicking on a notification from github (for example, from a PR with "reason": "review_requested"). The link leads to https://github.com/org/repo/pulls instead of https://github.com/org/repo/pull/123. I think this used to work in the past.

From my testing, this only seems to affect private repos.

I can share raw API data for notifications in private if that would help.

[bug] Keep Running in Background shows "Request Failed"

If I run via CLI I don't really see any logs related to it:

flatpaflatpak run com.mardojai.ForgeSparks 
Gjs-Message: 09:48:30.329: JS LOG: Forge Sparks: com.mardojai.ForgeSparks
Gjs-Message: 09:48:30.329: JS LOG: Version: 0.2.0
Gjs-Message: 09:48:30.923: JS LOG: https://api.github.com/notifications response resulted in 200

I'm on GNOME 44.5.

Initial State Illustration.

The current state uses a placeholder image from Todo.

Allow notification filtering based on org/project

In certain contexts, I still want to receive GitHub notifications but only from specific orgs/projects, or from anything but specific orgs/projects. Very basic filters would be really helpful for that.

Stuck at Loading

Issue:
After generating a classic token on github with notifications and User:read turned on, and entering the token into Forge Sparks, I am stuck at a loading circle and nothing else happens.

system information:
Mobian with Phosh, Arm64

Cannot add GitHub and Codeberg profile

When I try to add an GitHub or Codeberg account Forge Sparks sort of times out with an unexpected error. As flatpak run com.mardojai.ForgeSparks directly detaches after launch I can't provide any error messages.

GH access token needs additional permissions for private repos

Hi, first of thank you for making this!
As of some time last week the app isn't showing new notifications anymore, while they do get in the GitHub notifications page. I've tried regenerating the access token and removing the account to re-add it.

This is on Fedora 38, running it from the terminal with flatpak run --allow=devel com.mardojai.ForgeSparks does log:

Gjs-Message: 15:18:25.883: JS LOG: Forge Sparks: com.mardojai.ForgeSparks
Gjs-Message: 15:18:25.883: JS LOG: Version: 0.1.1
Gjs-Message: 15:18:26.537: JS LOG: https://api.github.com/notifications response resulted in 200
Gjs-Message: 15:18:26.909: JS LOG: Error: Invalid value 'undefined' for property url in object initializer.

Jira support

Would be nice if this could should Jira notifications etc as well. However I don't know if Jira and/or Jira Cloud have a suitable API.

Document supported notification types

I just learned that this application exists and wonder if it will show CI pipeline status changes.
It's unclear if it shows commits from starred directories, changes to issues or other things.

Please document the supported notification types in the README.

TypeScript

I would love it for the developer experience if the project would use TypeScript, also I could test our TypeScript types in a real scenario. Hence the question, would this project accept a pull request that ports your project to TypeScript?

[feat] Notification tools by using Github notification_referrer_id

When you click on a notification on github.com/notifications you get this bar at the top of the target page

These quick actions are very handy and I'd love to get this bar when opening a notification through forge sparks.

Clicking on a notification on github adds this url param: ?notification_referrer_id=NT_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx. The process to get a valid id is probably not that hard to reverse engineer.