primer / primer-markdown Goto Github PK
View Code? Open in Web Editor NEWStylesheets for rendering GitHub Flavored Markdown with Primer.
Home Page: http://primercss.io/markdown
Stylesheets for rendering GitHub Flavored Markdown with Primer.
Home Page: http://primercss.io/markdown
Some symbols not correctly rendering (β¬ for example).
Symbols correctly rendering if styles will be changed:
from
.markdown-body {
font-family: "Helvetica Neue", Helvetica, "Segoe UI", Arial, freesans, sans-serif;
}
to
.markdown-body {
font-family: "Helvetica Neue", Helvetica, "Segoe UI", Arial, freesans, sans-serif; "Segoe UI Symbol";
}
See https://github.com/atom/toggle-quotes/blob/mq-readme/README.md#configuration
toggle-quotes.quoteCharacters
under Configuration Key Path is wrapping, but this is quite strange since there is enough leeway for the text under Description to wrap instead, if that makes sense.
We manually provide this in a few instances on github/github
βright now it's specific to #readme .markdown-body
. I imagine this is something we should just set on every .markdown-body
though since I'm fixing a bug in our wikis to do the same thing.
Reported in github/markup#460, our markdown styles currently use display:block
. Should they use display:table
?
Here's what we'll need to to ship this. Feel free to add to it.
We could potentially just copy this into a new repo for the name change, which would take care of the issue audit.
The second paragraph in .github/CONTRIBUTING.md says:
Before you do, would you mind reading this license agreement?
That link is 404.
Note that the link in CONTRIBUTING.md is relative and points to CLA.md file in the same folder. That file doesn't exist there, hence the 404.
Provide a build script to build the Scss into CSS
Hi,
If I understand correctly, this repository looks like the CSS to support (GitHub Flavored) Markdown, and includes the CSS for things like headers, lists, tables, images, links, spacing and so on. That's great!
Does it also include CSS for syntax highlighting of languages inside Fenced Code Blocks? For example, if I render the following Markdown document using the raw Markdown rendering API endpoint:
Hello **world**.
```diff
+added
-removed
```
```Go
err := http.ListenAndServe(":8080", mux)
```
Which can be done using the following curl
command:
$ curl -X POST -H 'Content-Type: text/x-markdown' https://api.github.com/markdown/raw -d $'Hello **world**.
```diff
+added
-removed
```
```Go
err := http.ListenAndServe(":8080", mux)
```
'
The response is:
<p>Hello <strong>world</strong>.</p>
<div class="highlight highlight-source-diff"><pre><span class="pl-mi1">+added</span>
<span class="pl-md">-removed</span></pre></div>
<div class="highlight highlight-source-go"><pre><span class="pl-smi">err</span> <span class="pl-k">:=</span> http.<span class="pl-c1">ListenAndServe</span>(<span class="pl-s"><span class="pl-pds">"</span>:8080<span class="pl-pds">"</span></span>, mux)</pre></div>
Does this repository contain the neccessary CSS to style those classes such as pl-mi1
, pl-md
, pl-c1
, pl-s
, etc., to be able to render that Markdown to look like the following:
Hello world.
+added
-removed
err := http.ListenAndServe(":8080", mux)
If not, is it available somewhere else? Is it going to be available in the future?
Thank you!
If memory serves, we should be nuking that last margin on all the things, no matter the element.
/cc @jasonlong
This is mostly a question for @benogle.
What's the purpose of the symlink in the project root? I don't see anything noted in the readme for it. Is there something else this affects that coincides with the package name perhaps for imports?
Just to give folks a heads up, I plan on shipping this to genpop later this month (maybe next week?) once everything settles with our recent tweaks. I've made a few more readme edits and might make some more changes. Two quick questions though:
components/
folder necessary for anything?Lastly. I very much view this as a test ground for future open sourcing of more Primer components. Minimal tooling and basic documentation, but with the help of the community for bug reports, iterations, etc seems like a good balance for us.
/cc @benogle @bkeepers @cameronmcefee who have all had shared code, feedback, and such.
https://github.com/github/github/pull/31324 (In Chrome)
I cannot find any example of usage. Would help to get started with quickly.
Emoji get the img
element's white background, which makes emoji in the alternating grey rows of tables look a little funny:
Test | Test |
---|---|
π | |
π |
I'm happy to open a PR for this, but I'm not sure which place to add it in:
Seems like most PRs in this repo are made to the components
files, in which case I'd add background: none;
here:
https://github.com/cmrberry/markdown/blob/background-free-emoji/components/markdown.scss#L525-L527
But the actual css that affects seems to be in the dist folder:
https://github.com/primer/markdown/blob/master/dist/user-content.css#L204-L206
Does that get auto-updated when changes are made to the components
files? Thanks for your patience in dealing with a total newbie question π
Headings w/o space looks broken for now? Is there any reason for that?
Example:
##Heading (w/o space)
Not sure is it right place for that bug. But there is issue with rendering list of links with images:
wiki:
https://github.com/kiddick/draft/wiki/Pip
repo:
https://github.com/kiddick/pystuff/blob/master/pyvideos/README.md
content is identical
Hey guys,
I have a tiny docs project that uses npm for package managment and build scripts...I'd love to pull this in, but would prefer to use npm to do so.
I noticed an unfinished discussion (#4) regarding an npm package...can I haz this on npm?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.