Links no longer have underlines on hover about primer-markdown

[aroben]

@bleikamp Do you have a link to an example? There should still be underlines on all links; I removed link styling on non-link anchors like <a name="examples">.

[bleikamp]

It was happening on every PR and issue on Friday.

On Monday, March 16, 2015, Adam Roben [email protected] wrote:

@bleikamp https://github.com/bleikamp Do you have a link to an example?
There should still be underlines on all links; I removed link styling on
non-link anchors like .

—
Reply to this email directly or view it on GitHub
#43 (comment).

[aroben]

OK, here's some links to test:

https://github.com
GitHub
#43
#43 (comment)

[aroben]

Looks like it's working to me. Are you still seeing this bug somewhere else?

[mdo]

None of those work for me. This is in Safari, mind you.

[bleikamp]

Whoops — yeah, should say this is Safari on Yosemite.

[aroben]

Gotcha. I haven't been using Safari lately because of https://team.githubapp.com/statuses/24431. I can reproduce the issue in Safari. I'll look into it.

[aroben]

Looks like :not(:link) doesn't work in Safari, though :not([href]) does. Weird.

[aroben]

I filed https://bugs.webkit.org/show_bug.cgi?id=142734

[aroben]

This was presumably caused by #41

[aroben]

The previous WebKit bug is not the actual issue here. I just filed this one, which covers the exact problem we're having: https://bugs.webkit.org/show_bug.cgi?id=142737

[aroben]

Looks like this bug is fixed in the latest WebKit nightly.

[aroben]

I think we can work around the WebKit bug by changing the selector to a:not([href]). Hopefully that won't be much more expensive for the browser to match.