poteto / ember-changeset-validations

Validations for ember-changeset

ember-changeset-validations's Issues

Test rultor

@rultor hello

Add documentation for `buildMessage`

This is now public API with #82

Ember 1.13.13 support?

After reading through the GH template that pops up when creating an issue ... I'm uncertain if this is a bug/ support like question / or documentation clarification (improvement?). Regardless, I have reproduced it with twiddle and captured a quick/easy to watch animated gif showing the breakdown.

I decided to use this ember addon because it has support for 1.13.13. When I actually implemented this (following the twiddle shown in the README) I discovered an issue worth mentioning.

https://ember-twiddle.com/b70553450d0c7e4e2329e02b7d082e11

With ember 2x and the 2x series template compiler it works as desired. Validations fall off as you type ahead. But with ember 1.13.13 and the older template compiler you are required to add the ember-get-helper because without it you get an error.

If you run the twiddle above you will see the following

This makes me think we have 1 of 2 issues

1. the twiddle shows a legit bug in ember-changeset-validations (a possible conflict with ember 1.13.13)
2. ember-get-helper is broken with ember 1.13.13 and this implementation of it (as shown in the README)

I wanted to raise awareness mostly so we can update the twiddle/ call out that this implementation may not work for 1.13.13 or find and fix the bug with ember-changeset-validations (or ember-get-helper)

Update

It's worth noting that the actual validations do fall off from the changset itself - it seems to be a visual issue only. I'd guess we either don't notifyPropertyChange correctly or the ember-get-helper isn't picking that notify up as it should

Update 2

After I removed the ember-get-helper altogether (by doing the below) I still see this behavior making me think it's between ember 1.13.13/the template compiler? and ember-changeset-validations

{{#if changeset.error.firstName}}
            <ul>
            {{#each changeset.error.firstName.validation as |message|}}
                <li><span>{{message}}</span></li>
            {{/each}}
            </ul>
{{/if}}

Update 3

Also found this in other related documentation and it's broken as well

{{#if changeset.error.firstName}}
  <p>{{changeset.error.firstName.validation}}</p>
{{/if}}

Trouble using ember-validators with ember-changeset-validators

In a legacy app, I've got some code that uses ember-validators, but I'm starting to add new functionality using ember-changeset-validators.
I discovered that just having ember-changset-validators installed in the same app breaks my old ember-validations code. Now when the old ember-validations code goes to look up the 'presence' validator, it somehow comes back with the validatesPresence function from e-c-v. Then it can't call validator.create, and the app screeches to a halt.

I know long term I want to get off of ember-validations, but for now I need to use both at once, e-v and e-c-v. One way to fix would be to update the names for 'validator:presence' etc to not clash with the names from e-v. Any other suggestions for fixing or working around?

Remove circle.yml

Don't need two CIs...

Readme : Usage example missing import statement

Line 101 references the Changeset Object but it is not there in the import list

https://github.com/DockYard/ember-changeset-validations/blame/master/README.md#L101

Multi field validation (i.e. one of must be present) can result in incorrect `isValid` state

This might be more of a feature request than a bug (at least with the provided validators).

I have implemented a validator which checks for presence OR for the presence of other fields (so at least one of the fields must be "present" for the validator to pass). Currently there is no way to call validation for these other fields as the actual changeset is not passed to the validator function (just the changes and the model).

The only "workaround" right now is to call validate on the main changeset validating all fields, but this means that before that happens, the isValid state is incorrect (and errors for said fields might be present on the changeset).

This is likely also an issue for the validator proposed in #189 / #191

Skipping a validator

I have a validation file which holds a complete set of validators for a particular template. The template conditionally renders certain fields. Even when those fields are not rendered the validators appear to be triggering an error on the changeset (since I am using validatePresence and nothing is being entered, since it is not rendered). Is there a way to skip a validator?

Support custom error messages

Password confirmation validation is not working after validate()

Version 1.2.6

Test Case

https://ember-twiddle.com/a83d4a0647b7705a3759e9688006be2d?openFiles=templates.components.marketing-copy.hbs%2C

Steps to reproduce

Fill all the fields correctly and press "save" button 2 times

Expected Behavior

all validations should be correct

Actual Behavior

passwordConfirmation validation is failing and giving error:
Password confirmation doesn't match password

Unable to set a custom validation on two or more fields

Hi!, i can't make a customValidator that check two fields in the changeset. The current changeset is hidden from validator for any reason, or simply i don't find a way go get it?

I think my usercase isn't very strange, i have to date and time fields that needs to be coherent between them.

ValidatePresence has opposite behavior

sorry I don't have time to set up a dummy link for this but I noticed it twice now...

ember-source: "2.13.3"
ember-changeset: "^1.3.0",
ember-changeset-validations: "^1.2.7",

export default {
  url: [
    validatePresence(true),
  ],

Validate type

Maybe if the underlying model is a DS.Model, we can check and enforce type as a validator

Update yarn.lock

Closed by #168.

Cannot find module 'ember-changeset-validations/validators'

Version

1.2.4

Test Case

// test.js

import { validatePresence } from 'ember-changeset-validations/validators';
console.log(validatePresence);

Steps to reproduce

npm install ember-changeset-validations
node test.js

Expected Behavior

I'd expect to see the validatePresence function declaration outputted in the logs.

Actual Behavior

The module cannot be found:

Cannot find module 'ember-changeset-validations/validators'

Not sure if I'm missing something obvious here, but I tested this within an Ember app and had the same result. Wasn't sure if the problem was with my build process or something, so I thought I'd try the same thing in a single file (as above) and got the same result.

Tested with node 6.9.1

Delete

Edit: Scrap this

Investigate using ember-validators

https://github.com/offirgolan/ember-validators

Promise-based validation example and best practices?

Hey,

Thanks for the great library. I've noticed that you can return a promise from a custom validator leading me to believe I could write validators that query a remote backend. The most common use-case for this would be checking for other instances of a model with the same value (unique email for example).

It would be great to see a more verbose example this. I'm not sure what is the best way of getting access to the data store as an injected dependency. From my understanding (based largely on this SO answer) you would need to declare the validator as an Object and register it with the container to be able to inject the store dynamically.

I may be overthinking this but would like to hear about some best practices when needing to interact with other models during validation.

validateFormat regex won't allow blank values

Version

1.2.10

Test Case

// validations/text.js
import {
	validateLength,
	validateFormat,
} from 'ember-changeset-validations/validators';

export default {
  text: {
    validateFormat({regex: /^[a-z]*$/ }),
    validateLength({max: 250, allowBlank: true})
  }
};

Steps to reproduce

type something, delete everything, will be isInvalid=true and trigger the validateFormat-error

Expected Behavior

expecting to be valid, because 1st regex demands zero or more (*) and 2nd allowBlank is set.

a normal js match would indeed find a blank string:

var str = '';
var re = /^[a-z]*$/;
var found = str.match(re);
console.log(found);
// output: ["", index: 0, input: ""]

Actual Behavior

isInvalid
(removing the string-boundaries ^ and $ doesn't change anything but of course make the regex obsolete)

"validatePresence on" not updating

validatePresence({ presence: true, on: 'email' })

Version

2.1.0

This is probably me misunderstanding the behavior of the validator.

Steps to reproduce

export default {
	email: [
		validatePresence(true),
		validateFormat({ type: 'email' }),
	],
	password: [
		validatePresence({ presence: true, on: 'email' }),
	],
}

Expected Behavior

Empty password validates fine, but

1. turns invalid once an email is entered, or
2. turns invalid after focused after email is entered.

Actual Behavior

Empty password stays valid, focused or not.
Once you type in a password and then remove it again then the validator fails (as expected).

How to validate nested keys?

Given the following Ember.Object:

Ember.Object.create({
  title: 'Hello',
  contactNumber: {
    type: '07594378348',
    number: ''
  }
})

How do I define validations to validate the contactNumber.number field?

{
  title: validatePresence(true),
  contactNumber: ... ?
}

Latest version uses beta version of ember-changeset, which has bugs

The latest version of ember-changeset-validations, 1.2.11, has a dependency on a beta version of ember-changeset, 1.4.2-beta.1. This version seems to have bugs:

poteto/ember-changeset#289

poteto/ember-changeset#281

Possible to validate one field based on the value of another field?

I have a use case where I want to validate one field based on a value in another field (which, lets say, hasn't been changed).

Right now, using a custom validator, I can only see the validation arguments, field name, old value, new value, and change object. Is it possible to access the object underneath the changeset within a validation function?

Feature Request: Public API for getDescriptionFor

In my app, the propertyName for the input does not always map to the displayed label; this would be even more common in localised products.

For example:

<label for={{concat type "-" property}}>{{spanishProperty}}</label>
<input
  class="u-full-width"
  type={{type}}
  id={{concat type "-" property}}
  value={{get changeset property}}
  oninput={{action (mut (get changeset property)) value="target.value"}}
  onblur={{action validateProperty}}>
{{#if (get changeset.error property)}}
  <small>
  	<ul>
    	{{#each (get (get changeset.error property) "validation") as |message|}}
    		<li>{{message}}</li>
    	{{/each}}
    </ul>
  </small>
{{/if}}

While it is possible to change the messages hash per language, the hardcoded {description} just takes the propertyName and normalises it.

Would it be possible to allow the app/utils/messages.js file to be overridden, in order to allow more complex names for the {description} placeholder?

`buildMessage` function is backwards incompatible

Version

Latest Master starting at #126

Test Case

Steps to reproduce

Expected Behavior

From the Docs and existing behavior the buildMessage function should have a signature like this:
buildMessage(key, type, value, context = {}).

Actual Behavior

On this line the signature made a backwards incompatible change and now looks like this: buildMessage(key, result).

Is the next release intended to bump the major version? If not, any apps relying on buildMessage will be broken.

buildMessage function not getting message by type

Running ember-changeset-validations 1.2.4 and ember 2.10 / ember data 2.10.

My validation file looks like this and I was getting back the default case "is invalid" error message instead of the expected standard message for 'present':

import { validatePresence } from 'ember-changeset-validations/validators';

export default {
  amount: validatePresence({ presence: true })
}; 

I went into the buildMessage function and logged values until I noticed that the return in this line for the get of the type from the messages object was undefined:

return formatMessage(get(messages, type), assign({ description }, context));

I also noticed on further logging values that the "messages" object held all of its values in an object in a "defaults" property. As soon as I added defaults the message was displaying properly:

return formatMessage(get(messages.defaults, type), assign({ description }, context));

Even then, while the standard message content is there, the "description" doesn't seem to be added to the beginning of the message, but it seems like it should be based on what I'm seeing in the messages.js (i.e. the description variable is made a part of the message there). That said, this appends the description to the front of what's returned in the buildMessage:

return formatMessage(description + ' ' + get(messages.defaults, type), assign({ description }, context));

Blueprint for new validator

• Create validator with name as camelized function name
• Add unit test for it

export default function validatorName(options = {}) {
  return (key, newValue, oldValue, changes) => {
    return true;
  };
}

validateConfirmation does not revalidate if related property changes

Version

1.2.8

Test Case

https://ember-twiddle.com/8687b828162c979dceef152ba69d1be8?openFiles=controllers.application.js%2C

Steps to reproduce

Enter missing "t" in "Password" input field.

Expected Behavior

Password confirmation should be valid after both values are the same.

Actual Behavior

It's not revalidated until password confirmation field changes.

Other bugs in validateConfirmation

• #137, which is partly addressed by #138

Make validator messages object overridable

User should be able to provide their own messages POJO that overrides https://github.com/DockYard/ember-changeset-validations/blob/master/addon/validators/messages.js

Will most likely involve an ember-cli hook step

Bump ember-changeset to 1.4.0

Documentation Needed: Argument definitions/usage for a custom validator

The documentation currently shows that you can create a custom validator and which arguments are provided into the function, however, nowhere is it explained what each of these arguments actually IS. For example, I have a validator that is dependent on two values from the changeset and I thought getting the property from the changes argument would work but in some cases, I am getting undefined. Whether or not this is a bug or just an issue in my code is irrelevant. The problem here is that there is no indication on what these args mean or how they should be used. key, oldValue and newValue are easy enough, but what about changes and content?

`presence` messages are backwards

Version

Starts with this commit in latest master

Test Case

Steps to reproduce

Expected Behavior

When using presence(true) I expect the message to say {key} can't be blank.

When using buildMessage('present') I expect {key} can't be blank.
When using buildMessage('blank') I expect {key} must be blank.

Actual Behavior

When using presence(true) the message says{key} must be blank.
On these lines the type that is returned when the value is blank is blank. In the new mapping blank points to the correct message. However, the logic flips the type to present which is the wrong message.

When using buildMessage('present') I get {key} must be blank.
When using buildMessage('blank') I get {key} can't be blank.

Update an already existing model

Hi @poteto & others,

I am trying to have more than one validated-form in the page, for the same model, taking a changeset.
Different fields will be applicable for each form. But certain fields in one form, is a computed property of another form (the computed property is given in the model itself, so when we save / get, field is computed and received).

Since they are different forms, and each form creates a new model, the model is not updating the other form. Is there any way in which this can be achieved?

Please find this Twiddle for a similar demo.

Many thanks in advance!

Feature Request: validatePresenceOn

Suggested Addition

The validatePresenceOn validator: validate presence if other field(s) are also there.

How it works

export default {
  lastName: validatePresenceOn('firstName'),
  password: validatePresenceOn([ 'email', 'ssn', 'address', ])
}

Alternatively, it could be an option for the validatePresence validator:

export default {
  lastName: validatePresence({ on: 'firstName' }),
  password: validatePresence({ on: [ 'email', 'ssn', 'address', ] })
}

This is something I wrote as a custom validator, so if it's something you would like, I can put up a PR.

How to handle validators that return promises

From @brancusi

Hi,

Wondering how I can handle validators that return promises.

Trying to create a validator that checks if a name is available by calling some api/name_check service.

https://ember-twiddle.com/d4ec3c55c540d6da68da36ba79250590?fileTreeShown=false&openFiles=validations.user.js%2C

If you type anything in firstName you will notice [object Object] instead of a passing validation.

I noticed there was work done on handling validators that return promises, but I can't see how it actually works.

Thank you

Is there anyway to stop the next validator on the same field if one is invalid?

Hi,

Thanks for creating a great ember addon.

Here is scenario:
I want to validate email field as a email and unique in DB (the uniqueEmail validator will make a request to server to check unique)

 email: [
      validateFormat({ type: "email" }),
      uniqueEmail()
    ]

I think it would be nice if we check unique email just in case passed validateFormat only (for performance). Is there anyway to do it?

Thanks

Validator introspection

I want to put * on the required fields in a form if the Presence validator of those field attirbutes is present and set to true. For example, I've have a changeset object and an attribute name say title. How can I introspect the changeset to see if title has a presence validator and that presence validator has been set to true?

Email validation issue

• - I've raised a PR regarding the email validation, could you please review and merge?

#119

The issue is, email validation accepts without the domain (like test@gmail).

Version

Test Case

Steps to reproduce

Expected Behavior

Actual Behavior

Readme "validateNumber" incorrect description

The readme for validator number contains the following:

propertyName: validateNumber({ gte: 10 }), // greater than or equal to 5

Comment there should say 10 instead of 5.

`validateNumber` does not handle `null` value properly

First off, great project! It has radically simplified/standardized our forms and validation handling.

Small issue with validateNumber though. From playing around in my console (after struggling with false-positives in some tests):

> validate
function validateNumber() {
    var options = arguments.length <= 0 || arguments[0] === undefined ? {} : arguments[0];

    return function (key, value) {
      var numValue = Number(value);
      var…

undefined is fine...

> validate({ })('someKey', undefined)
"Some key must be a number"

> validate({ allowBlank: false })('someKey', undefined)
"Some key must be a number"

... but null...?

> validate({ })('someKey', null)
true
> validate({ allowBlank: false })('someKey', null)
true

https://github.com/DockYard/ember-changeset-validations/blob/master/addon/validators/number.js#L52 seems to be the issue.

> Number(undefined)
NaN
> Number(null)
0

Because JavaScript.

Will attempt a PR this weekend if possible.

Changing validation error messages at runtime

Hi, great addon.

I'm wondering, if there is a recommended way of changing validation messages at runtime?

I know it's possible to change it initially by defining a module that matches /validations\/messages$/gi but it's only loaded once.

define(['foo/validations/messages'], () => {
  return {default: {
     ...messages
  }};
})

If a user changes its locale, it's impossible to update validation messages from what i can tell.
Are there any known workarounds for supporting this kind of use-case?

Email Validation Update?

Currently,

email: /^[a-zA-Z0-9.!#$%&'*+/=?^_{|}~-]+@a-zA-Z0-9?(?:.a-zA-Z0-9?)*$/`

This validation allows emails for emails with invalid format, for example: "y@y", this could cause problems for those who use the email validator to check emails but also use a database validator to store authentication credentials.

I'm not sure if the validation was intended this way. Another validator I have found to work is:

email: /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/

How to observe model/changeset properties?

I've added ember-changeset-validations to my Ember app today. I have some computed properties which observe model. They don't work anymore. What am I missing? How can I observe changeset properties?

How to use two validation files for same page?

Hi,

How to couple two validation files as one?
For example, I have two different cards in my page, for which I have two separate validation files.
I have them separately because, I can either create and submit (for which both the validation files need to be considered), else if I edit the already present details, I can edit a separate card & save.

Is there any way to achieve the above feature? Kindly guide.

Thanks in advance!

Cache validations via WeakMap

Also amend validators to take an option to opt-out of caching (e.g. async validators)

TODO:

• Investigate https://github.com/thoov/ember-weakmap

ember-data errors support?

Does it make sense to have a validator similar to ember-cp-validations' ds-error validator? The main goal (for me) would be to consolidate the sources of error messages, but perhaps this would over-complicate the functionality intended here.

Otherwise, the user needs to manually handle ember-data (server) errors if changeset.save rejects.

clash with ember-validations messages

Hi there,

It seems like there is a bit of a clash happening with the default messages. The addon supports using a custom message map, but the way that the file is found iterates through all the modules (incl. addons) this results in the ember-validations/messages.js file being picked up and applied.

Looks like its happening here in the get-messages.js util file.

I'm wondering if you know of any work around? I'm happy to submit a PR that might fix this as well, but any hints would be welcome 😃. I would like to remove ember-validations, but we have it used throughout our application and I'd rather slowly convert it our larger forms to ember-changesets over time.

Thanks!

Version

1.2.4

Test Case

https://ember-twiddle.com/cbe30296bfa00125a43447eb68f8b4a1

Steps to reproduce

• Delete the value "Jim" from the field "firstName"

Expected Behavior

The default messages that come with ember-changeset-validations should be used.

Actual Behavior

The message, 'is invalid' is used instead because the get-messages function finds the ember-validations/messages.js file and so can't match the type to a message template.

regex not working as expected with boolean fields in ValidateFormat

Hello,

I know you won't answer questions, but I tought it would be good to share this. I stumbled upon an issue with validateFormat using regex when trying to check a boolean field. I suspect this simply cannot be used for boolean fields.

More info here:

https://stackoverflow.com/questions/44246791/ember-changeset-validations-not-working-as-expected-with-a-boolean

Maybe this should be stated more clearly in the docs?

Thanks and keep up the good work!

Show loading during async validation

During one of our validations, we hit an external service that sometimes takes up to 2 seconds. Is there a property or event that I can hook into so I can show loading while until the async validator completes?

Initial changset validation state

Given a changeset reacts to changes, the default state is always valid until a change is made on each property.

Is there a way to force a validation to run on the entire changeset on construction?

e.g.

let model = {};

let validations = Ember.Object.create({
  myKey: validatePresence(true)
});

let changeset = new Changeset(model, lookupValidator(validations), validations);
console.log(changeset.get('isValid')); // true, but the changeset is invalid

changeset.validate();
console.log(changeset.get('isValid')); // false, as expected