Comments (3)
Good idea. But this would be an additional "feature" as it requires to not just parse for forbidden methods calls (invoke/invokespecial/invokestatic/getfield/putfield bytecode), but just look at attributes of methods.
- I have to check how to detect a synchronized block inside bytecode. For method declartion it is just access flag (as far as I remember).
- Add some setting to enable it globally.
- Make sure SuppressForbidden works.
from forbidden-apis.
Well, synchronized(something)
would use monitorenter bytecode (e.g. https://asm.ow2.io/javadoc/org/objectweb/asm/Opcodes.html#MONITORENTER )
synchronized
methods would indeed be coded as method modifiers.
On top of that, it would probably be great to include Object#wait
, Object#notify
, and Object#notifyAll
into the forbidden set as they make sense only in case synchronized
is used (they should be replaced with Condition#await
, Condition#signal
, Condition#signalAll
).
I've no idea if synchronized
methods or monitorenter
could appear in synthetic code, or in the code generated by Kotlin, Scala, or the other compilers.
However, pgjdbc is Java-only for now, so it would be nice to just forbid plain Java synchronized
from forbidden-apis.
Kotlin must also use monitor enter or attributes on methods, unless they use locks internally. Groovy at least uses it.
from forbidden-apis.
Related Issues (20)
- idea: check proper use of declaration-site type variance HOT 8
- (Gradle) How to avoid creation of a forbiddenApisTest task HOT 2
- Unable to suppress violation in a field declaration HOT 3
- Allow to ignore failures for some signature files only HOT 3
- Improve messsages in the bundled signatures so they are actionable HOT 1
- Forbidding constructors doesn't always work HOT 2
- build warning about parameter "localRepository" after upgrading to maven 3.9.1 HOT 28
- Remove HttpResponse.BodyHandlers.ofFile(Path) from banned method list in Java 21 signatures HOT 2
- Provide option to enabled DEBUG level logging when using the CLI HOT 12
- Clarify Maven configuration parameter "includes" and "excludes" HOT 2
- Consider JEP 400 for jdk-unsafe Bundled Signatures HOT 1
- Check fails with "Bundled signatures resource not found: jdk-unsafe-21" despite failOnUnsupportedJava/failOnViolation disabled HOT 7
- Remove jdk.jfr from non portable exceptions list HOT 1
- Require at least Maven 3.2.5 HOT 3
- static method hiding produces false positives when original method is forbidden HOT 28
- Please publish PGP signature for the plugin at Gradle Plugin Portal HOT 6
- Add commons-io 2.15.1 HOT 1
- Add new (default) signatures
- "Parsing signatures failed" if class is not found on classpath HOT 3
- Clarify what retention scope is required for forbiddenapis suppression annotations HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forbidden-apis.