Forbidding constructors doesn't always work about forbidden-apis

[uschindler]

Hi,
I can't reproduce this. Please make sure your whole setup works (e.g., supressions, directories scanned correct). The following 2 test setup work with latest released version downloaded:

• Using your provided signatures.txt file wil the CLI
• Using the bundled signatures file "jdk-deprecated-19" (which contains the same signatures as they were deprecated in Java 19) also with CLI

$ cat signatures.txt
@defaultMessage Use "java.util.Locale#forLanguageTag"
java.util.Locale#<init>(java.lang.String)
java.util.Locale#<init>(java.lang.String,java.lang.String)
java.util.Locale#<init>(java.lang.String,java.lang.String,java.lang.String)

$ cat Test.java
import java.util.Locale;

public class Test {

  public static Locale parseLocale(String localeString) {
    String[] strings = localeString.split("_");
    switch (strings.length) {
    case 1:
      return new Locale(strings[0]);
    case 2:
      return new Locale(strings[0], strings[1]);
    case 3:
      return new Locale(strings[0], strings[1], strings[2]);
    default:
      throw new AssertionError("bad locale string '" + localeString + "'");
    }
  }

}

$ javac Test.java

$ java -jar forbiddenapis-3.4.jar -d . -f signatures.txt
Scanning for classes to check...
Reading API signatures: C:\Users\Uwe Schindler\Desktop\forbiddentest\signatures.txt
Loading classes to check...
Scanning classes for violations...
ERROR: Forbidden method invocation: java.util.Locale#<init>(java.lang.String) [Use "java.util.Locale#forLanguageTag"]
ERROR:   in Test (Test.java:9)
ERROR: Forbidden method invocation: java.util.Locale#<init>(java.lang.String,java.lang.String) [Use "java.util.Locale#forLanguageTag"]
ERROR:   in Test (Test.java:11)
ERROR: Forbidden method invocation: java.util.Locale#<init>(java.lang.String,java.lang.String,java.lang.String) [Use "java.util.Locale#forLanguageTag"]
ERROR:   in Test (Test.java:13)
ERROR: Scanned 1 class file(s) for forbidden API invocations (in 0.06s), 3 error(s).
ERROR: Check for forbidden API calls failed, see log.

$ java -jar forbiddenapis-3.4.jar -d . -b jdk-deprecated-19
Scanning for classes to check...
Reading bundled API signatures: jdk-deprecated-19
Loading classes to check...
Scanning classes for violations...
ERROR: Forbidden method invocation: java.util.Locale#<init>(java.lang.String) [Deprecated in Java 19]
ERROR:   in Test (Test.java:9)
ERROR: Forbidden method invocation: java.util.Locale#<init>(java.lang.String,java.lang.String) [Deprecated in Java 19]
ERROR:   in Test (Test.java:11)
ERROR: Forbidden method invocation: java.util.Locale#<init>(java.lang.String,java.lang.String,java.lang.String) [Deprecated in Java 19]
ERROR:   in Test (Test.java:13)
ERROR: Scanned 1 class file(s) for forbidden API invocations (in 0.18s), 3 error(s).
ERROR: Check for forbidden API calls failed, see log.

So all looks fine to me. Could it be that you added some annotation to one of your test code that suppresses the error? Or excluded files?

[snuyanzin]

yes, seems the issue was on my side, thanks for the fresh look