Comments (3)
The latter should result in warnings but not in hard errors.
I think it should result in hard errors, always. If you know the use is justified, you'll have to add SuppressForbidden to the piece of code that uses those APIs. This is an explicit step (and you can grep your code for those annotations). Realistically, nobody looks at the log scroll...
from forbidden-apis.
The latter should result in warnings but not in hard errors.
I think it should result in hard errors, always
That is a matter of policy. The ignoreFailures
property exists, so obviously it is useful for some people.
If you know the use is justified, you'll have to add SuppressForbidden to the piece of code that uses those APIs. This is an explicit step (and you can grep your code for those annotations.
That is one option but not the only one. Note that I am not talking about “forbidden APIs that can be used in exceptional cases”, which is a perfect use case for annotations, but about APIs that are not recommended (but allowed), have known pitfalls, etc, where a warning is ok but failing the build would be too much.
Realistically, nobody looks at the log scroll...
Then ignoreFailures
would not exist.
In any case what I am proposing here is a way to add flexibility to an existing option, in a backwards compatible way. If someone does not want to use it, they don’t need to.
from forbidden-apis.
The ignoreFailures property exists, so obviously it is useful for some people.
Maybe - I didn't add it, Uwe did. I just expressed my opinion. :)
from forbidden-apis.
Related Issues (20)
- (Gradle) How to avoid creation of a forbiddenApisTest task HOT 2
- Unable to suppress violation in a field declaration HOT 3
- Improve messsages in the bundled signatures so they are actionable HOT 1
- Forbidding constructors doesn't always work HOT 2
- build warning about parameter "localRepository" after upgrading to maven 3.9.1 HOT 28
- Remove HttpResponse.BodyHandlers.ofFile(Path) from banned method list in Java 21 signatures HOT 2
- Provide option to enabled DEBUG level logging when using the CLI HOT 12
- Clarify Maven configuration parameter "includes" and "excludes" HOT 2
- Consider JEP 400 for jdk-unsafe Bundled Signatures HOT 1
- Check fails with "Bundled signatures resource not found: jdk-unsafe-21" despite failOnUnsupportedJava/failOnViolation disabled HOT 7
- Remove jdk.jfr from non portable exceptions list HOT 1
- Require at least Maven 3.2.5 HOT 3
- static method hiding produces false positives when original method is forbidden HOT 28
- Please publish PGP signature for the plugin at Gradle Plugin Portal HOT 6
- Add commons-io 2.15.1 HOT 1
- Add new (default) signatures
- "Parsing signatures failed" if class is not found on classpath HOT 3
- Clarify what retention scope is required for forbiddenapis suppression annotations HOT 3
- compatibility with Gradle 9.x HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forbidden-apis.