plaans / gobot-sim Goto Github PK

https://github.com/VictorB00/Simulation-Factory-Godot/blob/6ec6f14cbaddda916fdebaa45d9ca164e53ab223/python_client/CompleteClient.py#L10

Expected behavior:
The popup is hidden and the simulation continues

What happens:
When clicking outside of the popup or on the "close" sign, the popup is hidden but the simulation stays frozen.

Due to asynchronous events (I think), we can enter into a situation where an operation on the file tries to be made while the file is not open.

To reproduce it, click anywhere multiple time, at a moment the robot will stop moving because of this issue.

To be able to make more varied scenarios, here's a list of existing parameters that should be exposed in scenario files as optional parameters:

For Belts (accessible after initialization through input_belt and output_belt in Machines):

• size (default = number of tiles, defined by the environment)

For InputMachines

• infinite (default = false)
• create_order (default = 0, values = 0,1,2) - invalid values are treated as 0
• create_time (default = 0, values = 0,1) - invalid values are treated as 0
• time_step (default = 15)

Currently, it seems that only one client can be connected.

When running the project with version 3.3, when the robot is stopped and the mouse is used to click another location to go to, a crash occurs. This does not occur at the start of the simulation when the robot has not moved yet, but after it has stopped after moving at least once.

The error message is : "Attempt to call function 'free' in base 'null instance' on a null instance." and happens in the stop_path function in Robot.

To reproduce the bug, simply run a simulation and move the robot to a location, then wait for the robot to stop and click another location.

Try to avoid committing pyc files. You should consider putting them in the gitignore file.

https://github.com/VictorB00/Simulation-Factory-Godot/blob/2f4e897eb11fe89863e2dca6932c787774a68ac2/protobuf/python_client/messages_pb2.pyc

https://github.com/VictorB00/Simulation-Factory-Godot/blob/2f4e897eb11fe89863e2dca6932c787774a68ac2/protobuf/python_client/__pycache__/messages_pb2.cpython-36.pyc

https://github.com/VictorB00/Simulation-Factory-Godot/blob/2f4e897eb11fe89863e2dca6932c787774a68ac2/protobuf/python_client/__pycache__/messages_pb2.cpython-38.pyc

Expected behavior:
The simulator runs without pause

What happens:
When launching the executable file after exporting the project (Project > Export > Linux...), the exported version shows an error popup every 7 seconds. It seems the error is linked to the logger.

The executable is saved outside of the project's folder, it runs on Ubuntu 16.04.

Godot has been updated to the version 3.3 the 21st April 2021.
This update brings optimizations along with several QOL features to the engine, and is a "recommended upgrade for all 3.2.x users".
It claims to be fully compatible with Godot 3.2.x, and initial testing shows no errors or incompatibility. However, a bit more testing is required to definitively switch versions.

https://godotengine.org/article/godot-3-3-has-arrived