phadej / tdigest Goto Github PK

Does it make sense to implement an API for non-empty TDigest so quantile returns a plain Double rather than Maybe Double, and (minimum|maximum)Value never return infinity?

The non-empty TDigest wouldn't have the Monoid instance and also tdigest would look like either of

• tdigest :: (KnownNat comp) => NonEmpty Double -> TDigest comp or
• tdigest :: (Foldable f, KnownNat comp) => f Double -> Maybe (TDigest comp).

I don't think the Semigroup (TDigest comp) instance follows Semigroup laws, let alone Monoid laws

I have an application where I use this, and have observed that the memory usage increases linearly (slowly) as I insert more data in the t-digest.

Is this expected? I thought that by being an online stats calculator it would keep the memory constant

Any intention of uploading this to hackage?

It works with allow-newer, so a revision might be sufficient. This is dependency of servant, which is how I stumbled upon this.

I see you have updated the tasty dependencies in your code, but the version on hackage still depends on tasty < 1.2. This means that tdigest does not currently build on nixpkgs master, where tasty-1.2 has landed.

Would you be able to push metadata revisions for fixed packages? Thanks.

Can tdigest get a bump on the base constraint please? On hackage, base is <4.11

https://hackage.haskell.org/package/tdigest