Comments (5)
Validation using schemas temporarily disabled while they get updated.
from hamronization.
@cimendes do you have a preferred schema to use as base? Considering JSON output is provided shall we just use JSON schema for now?
from hamronization.
I've discussed this a bit with @dfornika and it would be great if the the other schemas could be generated from a single "rule them all" schema, namely the SALAD one. I've trying to do some research and I think it is possible to have the SALAD schema and then convert to the other ones, including JSON. Unfortunately I haven't had the time to give this the propper attention it deserves... I'm sorry.
To me we can follow two paths:
- Focus efforts on the SALAD schema implementation and use that to generate all others
- Implement JSON schema validation (our bread and butter from the SARS-CoV-2 project)
The time commitment necessary for each if very different, and there are certain advantages of using one over the other, such as ontology integration.
I would like to hear your input on this, @fmaguire
from hamronization.
I'm not too bothered, why don't we do a quick JSON schema and if we need other features later we can revisit? Seems the quick pragmatic option given that only a tiny fraction of users are likely to even touch the schema directly.
from hamronization.
Closing issue as we're going for the good old JSON format
from hamronization.
Related Issues (20)
- staramr issue HOT 1
- Implementing logging and debug flag to simplify exception messages HOT 2
- help understanding resfinder run HOT 1
- ORF_ID missing once RGI report hAMRonized HOT 1
- RgiIO.py: Typo in line 79 HOT 1
- Fix issue of very similar runs falsely combining results in summary
- Genetic_variation_type HOT 1
- hamronize summarize - local variable 'parsed_report' reference before assignment HOT 3
- Flag overlapping ranges in hAMRonization
- AMR Variant detection - Parsers to be updated HOT 1
- Obtain specification field data information from JSON schema HOT 1
- Update README
- Add xlsx output HOT 1
- Add CONTRIBUTING.md
- Add fARGene
- PyPi not updated, 1.0.4 tarball reports version 1.0.3 HOT 2
- [BUG] `KeyError: 'reference_database_name'` when running summarize HOT 9
- [BUG] Generated output does not follow CSP rules HOT 1
- Request for Zenodo archive
- [BUG] - RGI bwt gene_mapping HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hamronization.