Comments (3)
Sorry about the delay, didn't realise people were actually running into this issue in the wild!
This should now work as intended (release to follow imminently).
from hamronization.
this bug is still present in the latest version (1.0.4)
from hamronization.
I would like to report the same issue, which is a problem for pipelines when we try to automate a lot of these. We are using hAMRonization heavily (because it's an awesome tool, thank you for it!) in nf-core/funcscan, but when testing this in a large pipeline run with ~126 samples, it caused the whole pipeline to fail due to this error.
The actual error arguably comes from the upstream per-tool subcommands, which produce 'nonsense' output of a single ]
Example, for abrigate output:
$ cat ABM006-megahit.txt
#FILE SEQUENCE START END STRAND GENE COVERAGE COVERAGE_MAP GAPS %COVERAGE %IDENTITY DATABASE ACCESSION PRODUCT RESISTANCE
$ hamronize \
abricate \
ABM006-megahit.txt \
\
--format json \
--analysis_software_version 1.0.1 \
--reference_database_version 2021-Mar-27 \
> ABM006-megahit.txt.abricate.json
$ cat ABM006-megahit.txt.abricate.json
]
So from a pipeline perspective, alternatively, it would also work at pipeline levels to have the check/failure at the tool specific subcommand. If it could produce an error message and a exit code other than 0 or 1, it would allow us to 'ignore' if the tool-level command fails.
from hamronization.
Related Issues (20)
- help understanding resfinder run HOT 1
- ORF_ID missing once RGI report hAMRonized HOT 1
- RgiIO.py: Typo in line 79 HOT 1
- Fix issue of very similar runs falsely combining results in summary
- Genetic_variation_type HOT 1
- Flag overlapping ranges in hAMRonization
- AMR Variant detection - Parsers to be updated HOT 1
- Obtain specification field data information from JSON schema HOT 1
- Update README
- Add xlsx output HOT 1
- Add CONTRIBUTING.md
- Add fARGene
- PyPi not updated, 1.0.4 tarball reports version 1.0.3 HOT 2
- [BUG] `KeyError: 'reference_database_name'` when running summarize HOT 9
- [BUG] Generated output does not follow CSP rules HOT 1
- Request for Zenodo archive
- [BUG] - RGI bwt gene_mapping HOT 3
- Updating version support for starmar, amrfinderplus, kmerresistance - summarize output breaks HOT 4
- nucleotide specific fileds are empty while importing AmrFinderPlus results based on nucleotide sequences HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hamronization.