Coder Social home page Coder Social logo

Comments (3)

fmaguire avatar fmaguire commented on August 28, 2024 2

Sorry about the delay, didn't realise people were actually running into this issue in the wild!
This should now work as intended (release to follow imminently).

from hamronization.

gdemoro avatar gdemoro commented on August 28, 2024

this bug is still present in the latest version (1.0.4)

from hamronization.

jfy133 avatar jfy133 commented on August 28, 2024

I would like to report the same issue, which is a problem for pipelines when we try to automate a lot of these. We are using hAMRonization heavily (because it's an awesome tool, thank you for it!) in nf-core/funcscan, but when testing this in a large pipeline run with ~126 samples, it caused the whole pipeline to fail due to this error.

The actual error arguably comes from the upstream per-tool subcommands, which produce 'nonsense' output of a single ]

Example, for abrigate output:

$ cat ABM006-megahit.txt
#FILE	SEQUENCE	START	END	STRAND	GENE	COVERAGE	COVERAGE_MAP	GAPS	%COVERAGE	%IDENTITY	DATABASE	ACCESSION	PRODUCT	RESISTANCE
$ hamronize \
    abricate \
    ABM006-megahit.txt \
     \
    --format json \
    --analysis_software_version 1.0.1 \
    --reference_database_version 2021-Mar-27 \
    > ABM006-megahit.txt.abricate.json
$ cat ABM006-megahit.txt.abricate.json 
]

So from a pipeline perspective, alternatively, it would also work at pipeline levels to have the check/failure at the tool specific subcommand. If it could produce an error message and a exit code other than 0 or 1, it would allow us to 'ignore' if the tool-level command fails.

from hamronization.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.