Coder Social home page Coder Social logo

paissaheavyindustries / triggernometry Goto Github PK

View Code? Open in Web Editor NEW
250.0 8.0 49.0 9 MB

Triggernometry is a plugin for Advanced Combat Tracker, intended to extend its built-in trigger system with a variety of different actions and configuration options.

License: MIT License

C# 99.98% Shell 0.02%
act ffxiv triggernometry telesto plugin raiding triggers advanced-combat-tracker ffxiv-act

triggernometry's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

triggernometry's Issues

Could not load file or assembly DX.Direct2D1,=version4.2.0.0

Hello

I'm getting the following error whenever I try to update Triggernomety.

image
This is what my Trig folder looks like.
image

There's more files in this version than my older 1.0.9.1. I just put them in as I usually would.
Is there any other directions I should be taking?
Edit: Just woke up and kept glancing over the READ ME file. Haaah.

Disabling "all" remote triggers does not work

If you want to disable remote triggers, you would assume that this:
grafik
disables them. It doesn't though.

For instance:
grafik
Would still make the callouts for Aho's Jobs + Raids. When I disable for instance the Jobs repository aswell, then it will stop triggering the job triggers.

Version 1.1.3.1

Table Values can't be retrieved in beta 5

Can't seem to be able to retrieve table vars
Testtrigger: Active Text Aura
Text to Display: Number: ${tvar:Test[3][2]}
Text Aura Output:Number:
Triggernometry_1_1_4_0_b5

Table value is set in view state - also tried a different table with values and a Repo trigger that retrieves tvar for X & Y values for image auras, none work for me atm, probably a trig beta bug

Some gif animations have an issue with bgcolor and trcolor

Some optimized gif animations apparently replace transparency color with background color, but these are not the same. Result is that when Triggernometry loads the gif in hw accel, the trcolor is replaced by an opaque bgcolor and transparency doesn't work.

An issue and a requirement

When I use the source of FFXIVNetwork I can't get "Line 38 (0x26): NetworkStatusEffects". But if I use the default source, I am able to get.
Also, I would like to have a function to convert timestamp and time in string format to and from each other.
I'm not good at English. I apologize if the useful words are wrong
Version: 1.1.4.4

Allow zone locking via zone ID

By zone ID I mean the number shown in the network version of line type 01 as shown here with 337 for TEA:
01|2020-07-21T17:47:26.6590000+02:00|377|The Epic of Alexander (Ultimate)|
If there's only some kind of other zone specific ID you can pull from the parsing plugin that's fine too as long as there's a way to figure out what it should be for each zone.

Suggestion List

Hey there, making a list here of things that I'd like to see in Triggernometry.
I understand that there are going to be things that you'll simply not implement or will take quite a bit of time but it's all food for thought.

General options:

  • Allow us to copy more then one action at a time.
  • Allow us to fire a trigger manually (add it in the context menu when rightclicking a trigger or something).

Relating to image auras:

  • Add more display modes:
  1. Zoomed to fill respecting Aspect Ratio horizontally only.
  2. Zoomed to fill respecting Aspect Ratio vertically only.
  • Add a rotation property (0 - 360 degrees)
  • Add support for animated PNG's
  • Add a mask mode where you can input an images aura ID and overlay on top of that.
  • Allow us to set the framerate/speed for GIF's

Relating to variables and unique identifiers:

  • Create a for loop action where we can execute other actions.
  • Allow us to target certain triggers / folders or use a regex to deactivate certain auras (I want to avoid using deactivate all auras as much as possible).
  • Allow us to set a vector (X and Y) variable that has the visual placement guide, this will probably greatly enhance making setting files and allowing newer users to move stuff around without manually setting 2 variables (A VERY COMMON QUESTION).
  • Allow us to resize the columns in the View Variables window.
  • Allow us to delete certain variables through the View Variables window (just letting us select one and allowing the delete key would be enough).
  • Allow us to access the triggers display name or give us a way to set a trigger specific variable.

I think that's everything I can thing of for now.

some mistakes about ${_ffxiventity} and it's property “targetid” version 1.1.4.1

${_ffxiventity[_ffxivplayer].targetid} will return the object id of my player's target

When my character is in a non combat state,it works good ,if i change my target in the game,it return the right id

But when my character is in combat,if i change my target in the game,the value it return to me would not change

However, there is one exception,some monsters linked by hate value,if i change my target Among them,it can return the right id to me

i very look forward to your reply,t4t

Figure out a better solution for the overlay & start menu issue

[14:26] kanetw: trying to see how to fix it without fucking up start menu but i'm wondering if that kind of all-screen overlay is the right decision anyhow
[14:26] kanetw: what does spespe do?
[14:26] kanetw: might be worth copying that :paissapeek:

Triggernometry Kills Audio / Discord Audio

As of 2 patches ago, triggernometry will cause audio to basically die, game performance runs poorly and requires a client reset, even discord will need to reassign the default audio devices. I have both Triggernometry and Triggernometry discord bot and have tried with the bot disabled.

Unhandled exeption when refreshing repos when no repo is selected

   at Triggernometry.CustomControls.UserInterface.UpdateRepository(TreeNode tnupdate)
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripButton.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Triggernometry.CustomControls.UserInterface, TriggernometryPlugin, Version=1.1.3.1, Culture=neutral, PublicKeyToken=null

After installing a repo and unchecking the readme, i had the possibility to hit refresh but nothing was selected, leading to that exeption

Crashes

Hello,

I've some issues with the plugin since few days, i'll try to explain it as best as i can.

It happens randomly during any type of gameplay, but mostly in dungeons / raids, i'm hearing a weird sound from my headset, the sound drivers seems to be crashing (No more sounds at all on game / discord, but half of the time, i can still hear the trigger's TTS) and i'm lagging a lot (looks like i've 10 fps even tho' the game shows 100+).

I disabled HW acceleration and it doesn't seems to be crashing anymore (I need to try more). (I enabled it because some aura had some pink borders without it)
I'm using a 144hz g-sync monitor and all my drivers/plugins are up-to-date.
It looks like either a problem with HW acce, or with some drivers? Dunno if there's any way to debug this and provide logs.

Could not create SSL/TLS secure channel.

2019-12-29 04:54:49.763 Error Version update check failed: The request was aborted: Could not create SSL/TLS secure channel.

Just set it up today along with ACT
keeps showing up in logs

build instructions for triggernometry please!

cloning the repo in visual studio and trying to build fails with packages unable to download (forcibly closed for things like sharpdx and such..

Severity Code Description Project File Line Suppression State
Error NuGet Package restore failed for project TriggernometryPlugin: Unable to find version '4.5.0' of package 'Microsoft.CSharp'.
C:\Program Files (x86)\Microsoft SDKs\NuGetPackages: Package 'Microsoft.CSharp.4.5.0' is not found on source 'C:\Program Files (x86)\Microsoft SDKs\NuGetPackages'.
https://api.nuget.org/v3/index.json: Unable to load the service index for source https://api.nuget.org/v3/index.json.
An error occurred while sending the request.
The underlying connection was closed: An unexpected error occurred on a send.
Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host.
An existing connection was forcibly closed by the remote host
. Please see Error List window for detailed warnings and errors.

anything you can mention on how to get it set to build?

thanks in advance
Techno

Text aura refresh rate has been reduced

Context

Text auras have a property "Text to display" that can contain a string expression. As the variables used in the expression change values over time, so does the displayed text.

The issue

The refresh rate of the displayed text in Triggernometry version 1.1.4.1 is now much slower; around one update per second. It used to be higher (multiple updates per second) in older versions, allowing displays of highly volatile variables in real-time (like a player position).

The trigger to reproduce the issue

<?xml version="1.0"?>
<TriggernometryExport Version="1">
  <ExportedTrigger Enabled="true" Name="Position-Show" Id="ed2ab636-16be-4beb-9e48-f7445c0fe0ea" RegularExpression="position-show" PrevActions="Interrupt">
    <Actions>
      <Action OrderNumber="1" LogLevel="-1" TextAuraAlignment="MiddleLeft" TextAuraFontSize="15.75" TextAuraForeground="White" TextAuraBackground="Black" TextAuraName="PositionText" TextAuraExpression="Position: (x: ${numeric:round(${_ffxivparty[${_ffxivplayer}].x}, 1)}, y: ${numeric:round(${_ffxivparty[${_ffxivplayer}].y}, 1)})" TextAuraXIniExpression="1539" TextAuraYIniExpression="386" TextAuraWIniExpression="319" TextAuraHIniExpression="42" TextAuraOIniExpression="100" TextAuraFontName="Microsoft Sans Serif" ActionType="TextAura" Description="Position: (x: ${numeric:round(${_ffxivparty[${_ffxivplayer}].x}, 2)}, y: ${numeric:round(${_ffxivparty[${_ffxivplayer}].y}, 2)})&#xD;&#xA;&#xD;&#xA;${numeric:round(&#xD;&#xA;, 2)}">
        <Condition Enabled="false" Grouping="Or" />
      </Action>
    </Actions>
    <Condition Enabled="false" Grouping="Or" />
  </ExportedTrigger>
</TriggernometryExport>

Text aura width update tick do not handle a value of zero

In the latest version (1.1.3.1), the following trigger will crash (not be fully executed) :

<?xml version="1.0"?>
<TriggernometryExport Version="1">
  <ExportedTrigger Enabled="true" Name="ShowTextWidth0Bug" Id="93bcd1c1-cfdc-4873-8690-2a5c76480353" RegularExpression="showtextwidth0bug">
    <Actions>
      <Action OrderNumber="1" LogLevel="-1" TextAuraFontSize="15.75" TextAuraBackground="Lime" TextAuraName="ShowTextWidth0BugTextAura" TextAuraExpression="Some text aura" TextAuraXIniExpression="20" TextAuraYIniExpression="20" TextAuraWIniExpression="0" TextAuraHIniExpression="30" TextAuraOIniExpression="100" TextAuraWTickExpression="if (${_sincems}&lt;1000, (0), (${_sincems}))" TextAuraFontName="Microsoft Sans Serif" ActionType="TextAura">
        <Condition Enabled="false" Grouping="Or" />
        <Conditions />
      </Action>
      <Action OrderNumber="2" LogLevel="-1" TextAuraOp="DeactivateAura" TextAuraFontSize="8.25" TextAuraName="ShowTextWidth0BugTextAura" TextAuraFontName="Microsoft Sans Serif" ActionType="TextAura" ExecutionDelayExpression="5000">
        <Condition Enabled="false" Grouping="Or" />
        <Conditions />
      </Action>
    </Actions>
    <Condition Enabled="false" Grouping="Or" />
    <Conditions />
  </ExportedTrigger>
</TriggernometryExport>

A workaround is to change the if instruction and remove paths that will lead to a value of zero.

This will not work : if (${_sincems}<1000, (0), (${_sincems}))
This will work : if (${_sincems}<1000, (1), (${_sincems}))

It was previously possible to assign a width of zero in the update tick, so it is a possible regression case.

The issue also happens for image auras.

Suggestion: Reproduce what Special Spell Timers does/did

I loved the Special Spell Timers when it would work for ACT but I've had a very hard time trying to get help as it's always crashing my ACT now. Also it comes with a LOT of other features that kinda bloat the plugin now.

Would it be possible to add something to this plugin to do the same thing? I would assume it would be similar to an Aure Operation but also include a progress bar that you can either have fill-up or empty depending on option.

Here are some examples if what it looks like:

https://i.imgur.com/sdjnzJh.gifv
https://i.imgur.com/du65DTh.gifv

https://i.imgur.com/Tvqzf7d.jpg
https://i.imgur.com/oBAdCfm.jpg

Discord notifications go missing in hw accel?

[21:00] TechnoHunter: just got a report and verification, HW enabled keeps discord notifications from popping up on a user from the ACT_FFXIV discord.. he disabled it, notifications show..

Error when trying to set a cell in a table variable with no value in the variable editor

If a cell already have a value, trying to remove it and leave it blank catches an error

   at Triggernometry.Forms.VariableEditorForm.dgvVariableData_CellValuePushed(Object sender, DataGridViewCellValueEventArgs e)
   at System.Windows.Forms.DataGridView.OnCellValuePushed(DataGridViewCellValueEventArgs e)
   at System.Windows.Forms.DataGridViewCell.SetValue(Int32 rowIndex, Object value)
   at System.Windows.Forms.DataGridView.PushFormattedValue(DataGridViewCell& dataGridViewCurrentCell, Object formattedValue, Exception& exception)
   at System.Windows.Forms.DataGridView.CommitEdit(DataGridViewCell& dataGridViewCurrentCell, DataGridViewDataErrorContexts context, DataGridViewValidateCellInternal validateCell, Boolean fireCellLeave, Boolean fireCellEnter, Boolean fireRowLeave, Boolean fireRowEnter, Boolean fireLeave)
   at System.Windows.Forms.DataGridView.CommitEdit(DataGridViewDataErrorContexts context, Boolean forCurrentCellChange, Boolean forCurrentRowChange)
   at System.Windows.Forms.DataGridView.OnCellMouseDown(HitTestInfo hti, Boolean isShiftDown, Boolean isControlDown)
   at System.Windows.Forms.DataGridView.OnCellMouseDown(DataGridViewCellMouseEventArgs e)
   at System.Windows.Forms.DataGridView.OnMouseDown(MouseEventArgs e)
   at System.Windows.Forms.Control.WmMouseDown(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.DataGridView.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Triggernometry.Forms.VariableEditorForm, TriggernometryPlugin, Version=1.1.3.2, Culture=neutral, PublicKeyToken=null```

The numeric parser doesn't recognize negative numbers after commas correctly

I was trying to using a numeric expression similar to ${numeric: and(${var:x} > 0, ${var:x} < 15) } where x was a negative number. After substituting, the expression reads and(-1 > 0, -1 < 15), which breaks the parser.

The second negative number is instead treated as an operator and a positive number (assuming I'm reading the source code correctly for the Lexer).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.