[Bug] i.sentinel.import deletes the unzipped folder without any warning about grass-addons

[ninsbl]

#137 writes metadata to json and allows to read that json in i.sentinel.mask. so with that PR merged there should be no more need to keep the unzipped safe. That said the metadata file could also be read directly from zip file...

[neteler]

I suggest to have a "keep ZIP file(s)" flag.

The flag can then be used here:

grass-addons/grass7/imagery/i.sentinel/i.sentinel.import/i.sentinel.import.py

Line 77 in 2f05e5b

# otherwise unzipped directory can be removed (?)

@ninsbl , @landam any opinion?

[ninsbl]

No objections. A flag could be a simple solution.

The reason for this bug report will however be addressed with #137, no?

Most elegant / efficient would be probably to never unzip but use GDALs virtual file system and adding /vsizip/in front of import paths (at least when data is not just linked)...

[veroandreo]

The problem reported is that i.sentinel.import deletes the unzipped directories, not the zip file. Hence when using it together with i.sentinel.mask one needs to go through unzipping once again. Ideally we should have a flag then to keep the unzipped files.

If you never unzip by using the gdal vsizip as suggested, how would you then find the metadata file needed for i.sentinel.mask?? Does it also allow to read other types of files? Seems to me the unzipping is needed, or much better, a way to write and read the relevant info for i.sentinel.mask somewhere else, so we don't need that metadata file anymore.

[lucadelu]

@veroandreo could this issue be closed?

[veroandreo]

yes, closing