[Bug] v.surf.nnbathy: NameError: `StandardError` is not defined about grass-addons

[mxkpp]

@wenzeslaus understood. I'd be glad to revisit and open a PR when I'm able.

[neteler]

Please note that the GRASS GIS 7 addons are available in a different branch ("grass7/"):

https://github.com/OSGeo/grass-addons/blob/grass7/src/vector/v.surf.nnbathy/nnbathy.py

Can you try that first? (of course the recommendation is to use GRASS GIS 8).

[mxkpp]

Yes, that's the branch I took the permalink from. It's the same in the grass8 branch too though. Unless this is supposed to run in Python 2, I don't see how it could work if StandardError is not in the Python 3 namespace.

[tmszi]

According doc for porting Python 2 code to version 3: "The recommended fixer will replace all uses of StandardError with Exception. Review the result to check if this is correct".

Could @mxkpp share full Python command for running v.surf.nnbathy module, please?

[mxkpp]

Sorry for the delay. Below is the way the v.surf.nnbathy module is being invoked. Unfortunately I'm not able to share input data or more of the code context (though I don't think that is necessary to see how the existing module would have a problem in Python 3).

from grass_session import Session
import grass.script as gs

gs.set_raise_on_error(True)
gs.set_capture_stderr(True)

session_args = {"gisdb": "/app/data/grassdata/foobar", "location": "foobar", "mapset": "PERMANENT", "create_opts": ""}

with Session(**session_args):
    gs.run_command(
            "v.surf.nnbathy",
            input_="input_foobar",
            output="output_foobar",
            column="column_foobar",
            algorithm="nn",
            overwrite="true"
        )

[wenzeslaus]

Fix is now in #981. @mxkpp or @rmarzocchi84 if you want to give thumbs up for the PR or even pick up implementing an actual fix or fixing some of the Pylint warnings, this would be a good time. In any case, #981 can be merged soon.

[mxkpp]

Thanks all, I did not get a chance to look but I see it was merged into grass8 branch. btw it affects grass7 too (and maybe others), anything using Python 3.

[wenzeslaus]

If you want to update it for v7 or anything else, please open an PR and feel free to cherry pick (git cherry-pick) the commit from grass8 branch. We will be happy to merge it, but we can't go beyond that in supporting the legacy version given the resources we have at our disposal.