[Bug] testsuite: do not run tests for deprecated module about grass-addons

[neteler]

2. Consider removing the deprecated code. You can't get that with g.extension anyway, no? If that's the case, you need to use Git to get the code. In that case, you can dig up the code from an old version using Git if you really need it.

Agreed. So:

ag -g DEPRECATED
src/raster/r.in.pdal/DEPRECATED
src/raster/r.le.patch/DEPRECATED
src/raster/r.le.pixel/DEPRECATED
src/raster/r.le.setup/DEPRECATED
src/raster/r.le.trace/DEPRECATED
src/raster/r.out.tiff/DEPRECATED

I suggest to remove all of them. Git preserves the history anyway.

[neteler]

I guess that things happen here:

grass-addons/.github/workflows/ci.yml

Line 91 in 82d59ce

cd grass-addons/src

which calls make in the respective subdirs of src/.

Here it appears that DEPRECATED modules should be ignored:

grass-addons/src/raster/Makefile

Line 5 in 82d59ce

SUBDIRS := $(filter-out $(DEPRECATED_SUBDIRS), $(ALL_SUBDIRS))

but apparently that mechanism isn't used?

[ninsbl]

It seems to me, that r.in.pdal is not compiled, so the DEPRECATED file is taken into account in the make step.

When the unittest is started here: https://github.com/OSGeo/grass-addons/blob/82d59ce1424be8d7fac485836b3af5c00bba3b33/.github/workflows/test.sh#L15C16-L15C34
I guess all testsuite directory in the source tree are picked up. Maybe a solution could be to add an exception for a DEPRECATED file in the function here:
https://github.com/OSGeo/grass/blob/7089dc6ef72591b807c8ab430e9b94f74f55f38b/python/grass/gunittest/loader.py#L67

[wenzeslaus]

Before adding more code to grass.gunittest, I suggest:

1. Add .gunittest.cfg and exclude those tests. Deprecated code is to be removed some day which nicely fits with the line in the configure file which also should be removed eventually (other ignored files mean failing tests, so these need to be resolved too just like the line for deprecated code).
2. Consider removing the deprecated code. You can't get that with g.extension anyway, no? If that's the case, you need to use Git to get the code. In that case, you can dig up the code from an old version using Git if you really need it.