Comments (9)
I still didn't see anywhere where it was written that this was the case :(
@GreenAsJade, I looked it up in the Chromium sources to confirm @benjaminpjones's comment in the forum thread:
public boolean performEditorAction(int actionCode) {
if (!isValid()) return false;
// If mTextInputAction has been specified (indicating an enterKeyHint
// has been specified in the HTML) then we do will send the enter key
// events. Otherwise we fallback to having the enter key move focus
// between the elements.
if (mTextInputAction == TextInputAction.DEFAULT) {
switch (actionCode) {
case EditorInfo.IME_ACTION_NEXT:
advanceFocusForIME(FocusType.FORWARD);
return true;
case EditorInfo.IME_ACTION_PREVIOUS:
advanceFocusForIME(FocusType.BACKWARD);
return true;
}
}
sendSyntheticKeyPress(
KeyEvent.KEYCODE_ENTER,
KeyEvent.FLAG_SOFT_KEYBOARD
| KeyEvent.FLAG_KEEP_TOUCH_MODE
| KeyEvent.FLAG_EDITOR_ACTION);
return true;
}
EDIT: seems to me that the logic of the Chromium change is:
- If the developer is savvy enough to specify an intent for the enter key (enterkeyhint), trust the developer to handle input navigation for the form.
- Else, turn on "smart go next" to avoid accidental early form submission in the common case.
The recent change that broke chat (60f5f4f0c78e55c46617bcbeccfce322c6730e88) is:
- If there's no form, treat it as if there's one form for the whole page.
But it still defers to the developer if there's an intent specified via enterkeyhint
, as shown above in the code snippet.
from online-go.com.
@GreenAsJade , any chance this was caused by #2595?
from online-go.com.
There's also some new thing you where you can see
Actually, probably not new (probably I just didn't notice it when it was flush right instead of taking up space in the chat box)
from online-go.com.
If you checkout the revision right before does it go away? Seems like a pretty likely candidate. I broke something with my mac so it'll be a little bit before I can look into it myself.
from online-go.com.
If you checkout the revision right before does it go away? Seems like a pretty likely candidate. I broke something with my mac so it'll be a little bit before I can look into it myself.
Confirmed:
I don't have time to try to fix myself right now (hopping on a call).
from online-go.com.
But my guess it's the <form>
part of it, rather than the "...hint" thing (the latter of which sounded like a sufficient change to fix the bug)
from online-go.com.
he latter of which sounded like a sufficient change to fix the bug
I still didn't see anywhere where it was written that this was the case :(
I'm checking it out now.
from online-go.com.
I still didn't see anywhere where it was written that this was the case :(
Not sure what the ultimate source was, but I saw it here in the thread at https://forums.online-go.com/t/unable-to-reply-to-group-chat/49861/14:
It’s an implementation detail of Chromium/Android but this is what they’ve done:
- If there are multiple text inputs in a form, send a Tab event instead of Enter for all but the last input element
- If enterkeyhint is set, send Enter no matter what. (even if it’s enterkeyhint=“next” 🤔)
from online-go.com.
I've closed this because the change that caused this bug has been backed out
from online-go.com.
Related Issues (20)
- Blank board with no grid or stones when clicking back into tab HOT 16
- Share private sgf folders with user
- Community moderation: Stopped Playing type of report gives no actions available HOT 3
- Game-control-dock pop-out delay broken. HOT 12
- Typo on spectator waiting room page HOT 1
- Sign-in with Apple gets a "resource not found" HOT 1
- Do not require email verificaiton when user registerd via email-provider (e.g google.com) HOT 2
- Turn off autocomplete for chat HOT 2
- Request to Acknowledge Uffizzi's Contributions in README HOT 1
- finished game in game count HOT 1
- Automatic live 9x9 double-elimination tournaments have McMahon bars (!?) HOT 9
- supporterExpired is not supported (oh, the irony) as a notification
- Swiss tournaments have way too many rounds
- Tournament "strength" pairing should be primarily based on tournament performance
- If you have activated (and expired) a trial AI subscription, you still get prompts for a free AI trial HOT 1
- Unify game links HOT 1
- Cannot login using username + password on GitHub-created account
- Show handicap stones for each game in game history table
- Include a constant string in all page titles HOT 1
- Broken github "fork me" image on about page
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from online-go.com.