Comments (9)
Doing a bisection through 1991 archive pages at 25 tournaments per page:
- 1000: https://online-go.com/tournament/61206 good (no negative points, despite presence of DDKs)
- 500: https://online-go.com/tournament/87805 bad (negative points)
- 750: https://online-go.com/tournament/74347 good
- 612: skip (not seeing negative points, but not confident tournament had DDKs)
- 611: https://online-go.com/tournament/81966 good
- 550: https://online-go.com/tournament/85204 good
- 525: https://online-go.com/tournament/86478 bad
- 537: https://online-go.com/tournament/85824 bad
- 543: https://online-go.com/tournament/85557 bad
- 547: https://online-go.com/tournament/85377 bad
- 548: https://online-go.com/tournament/85338 bad
- 548: https://online-go.com/tournament/85327 bad
- 548: https://online-go.com/tournament/85308 bad
- 548: https://online-go.com/tournament/85303 bad
- 548: https://online-go.com/tournament/85279 good
- 548: https://online-go.com/tournament/85299 bad
- 548: https://online-go.com/tournament/85295 skip
That means the first "bad" one I can find was "Live 9x9 Double Elimination Tournament 2022-01-25 14:30", https://online-go.com/tournament/85299.
That's pretty close to when two backend changes were committed related to setting initial points in McMahon bars:
- f9b40a50841de263e8120c40e0a0c19a32dcc9d4 (committed January 21, 2022)
- 07b0d6eaf16d619d175852d63393b876d156c797 (committed January 26, 2022)
After staring for a while, I can't see how they triggered the bug. I actually found those changes before doing the bisection, since they were obviously touching related code, but decided they couldn't be the problem. It looks to me like the bug was always there: if a double elimination tournament somehow had McMahon bars set, they'd be used.
from online-go.com.
Interesting, thanks for finding and (presumably) fixing, i'll do some testing with it and get it deployed tomorrow if it all looks good.
from online-go.com.
ogs #1959 has been merged and deployed, new tournaments going forward should be good to go
from online-go.com.
Note that you can see the negative points at this other API endpoint: https://online-go.com/termination-api/tournament/105862/players
In case it helps here's an ancient one where there don't seem to have been negative points awarded (e.g. to user stargrazerfairy who would have probably been DDK): https://online-go.com/tournament/3565 https://online-go.com/termination-api/tournament/3565/players
But it does have the bars in the settings: https://online-go.com/api/v1/tournaments/3524
More recent ones like https://online-go.com/termination-api/tournament/103270/players (2023) show negative points.
from online-go.com.
Huh, nothing has changed with those configurations in many many years, odd we're seeing stuff now..
from online-go.com.
If there are old ones without negative points, then maybe some refactor related to the backend changes a few months ago triggered this.
from online-go.com.
After staring for a while, I can't see how they triggered the bug. I actually found those changes before doing the bisection, since they were obviously touching related code, but decided they couldn't be the problem. It looks to me like the bug was always there: if a double elimination tournament somehow had McMahon bars set, they'd be used.
Just to clarify: it looks to me like the bug was always there, from looking at the code. But the bisection has convincing evidence that somehow those two commits changed the behaviour; before those commits, McMahon bars in D.E. tournaments were ignored; after those commits, they caused negative points.
from online-go.com.
@anoek, looking at other automatic tournaments (not just "live 9x9"), I'm also seeing McMahon bars also in:
- https://online-go.com/tournament/116084 (Blitz 19x19 Elimination)
- https://online-go.com/tournament/116030 (Live 19x19 Swiss)
- https://online-go.com/tournament/115877 (Blitz 13x13 Swiss)
Combined with "Live 9x9", that's the full set of live/blitz.
For automatic correspondence (I didn't find any in the first two pages of archive, but...):
- The simultaneous round robins won't hit the issue since they don't share a code path, but it might be nice to remove bogus McMahon bars from them too if they're there.
- The simultaneous McMahons should have bars, presumably.
from online-go.com.
Just to clarify: it looks to me like the bug was always there, from looking at the code.
Update: I figured out how f9b40a50841de263e8120c40e0a0c19a32dcc9d4 (January 21, 2022) triggered the bug. I still think it's worth cleaning up configurations to remove bars where they don't make sense, but maybe a backend change is also in order.
from online-go.com.
Related Issues (20)
- Broken github "fork me" image on about page
- Clarify cancellation message to avoid confusion for beginners
- `/me` endpoint returning invalid links with missing `/` HOT 1
- Newly created challenges via API automatically removed HOT 8
- Consolidate OGS API documentations into one, take the obsolete ones offline
- GoTV twitch chat cookies prompt HOT 6
- Stone removal matrix from the end of game is incorrectly used during analysis and score estimation of old moves HOT 4
- end game details are all broken HOT 7
- Live AI review for IRL relays HOT 2
- Ignoring a report causes incident report tracker count to include un-escalated reports
- Ignored reports are no longer ignored after reloading page
- Group incorrectly shown on group list HOT 2
- New X for captured stones - yuck! HOT 3
- Blocked users not blocked enough
- Incorrect rank determination in played matches.
- Title shows (0) moves made which isn't that helpful
- incorrectly displayed strength on the chart. Incorrectly classifies opponent in matches played Stronger/weaker opponents.
- Incorrect "You have won!" announcement for a tied game
- Keyboard shortcuts during AI review
- relocate global toggle for coordinatea
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from online-go.com.