Coder Social home page Coder Social logo

Comments (16)

anoek avatar anoek commented on September 4, 2024 1

On mobile it's a canvas allocation issue (out of memory). It only happens on iOS, and it'll happen after a couple of allocations or several hundred, sometimes it'll be a very tiny allocation (like we do for the stones), or sometimes the whole board. It feels to me like the browser isn't reclaiming some form of memory browser-wide, causing seemingly random failures on our site in particular, but I don't know for sure.

from online-go.com.

anoek avatar anoek commented on September 4, 2024 1

Yeah, shadows were a big pain. We'll see how it goes, I went with canvas originally because SVG support was inconsistent and glitchy way back when, but it's pretty solid now so I think it'll probably be an overall win these days.

from online-go.com.

adamreisnz avatar adamreisnz commented on September 4, 2024 1

Thanks, I have switched it on, and so far no issues it seems 👍🏼

from online-go.com.

adamreisnz avatar adamreisnz commented on September 4, 2024

The same thing is happening on the home page with the games overview:

image

from online-go.com.

ChrisMoutsos avatar ChrisMoutsos commented on September 4, 2024

I am experiencing this bug as well. I am not sure what causes it exactly, either.

from online-go.com.

anoek avatar anoek commented on September 4, 2024

Are you also on Mac, and also using Chrome @ChrisMoutsos ?

Chrome version 124, are you both still seeing this?

from online-go.com.

adamreisnz avatar adamreisnz commented on September 4, 2024

Hi @anoek thanks for checking in. I have just checked it with Chrome 124, and have not run into the issue yet. Will post again if it does return, thanks!

Do you reckon it was a Chrome/webkit canvas rendering bug?

from online-go.com.

adamreisnz avatar adamreisnz commented on September 4, 2024

Ah, looks like I spoke to soon, it's still happening unfortunately, on all 3 tabs that I had opened

image image

from online-go.com.

anoek avatar anoek commented on September 4, 2024

Bummer.

Whelp, I think the immediate workaround is to switch to a browser that doesn't have that bug, Firefox has always performed quite well.

Longer term the workaround site side is to switch rendering to use SVG's instead of Canvases. That seems to be an increasing priority, so I'll be working on that soon I think - however that's a fair undertaking so in the interim I'd suggest using Firefox.

from online-go.com.

adamreisnz avatar adamreisnz commented on September 4, 2024

Ok, all good. Nah, I'll stick with Chrome. Will just have to refresh the page every now and then.
Interestingly enough mobile Chrome doesn't seem to be affected?

Do you have any insights into what is actually causing the bug?

And what else has been driving the switch from Canvas to SVG? Curious about that direction.
I didn't think you could do everything you can with Canvas with SVG, but I might be wrong.

from online-go.com.

anoek avatar anoek commented on September 4, 2024

And yeah, SVG can't do everything canvas can do, but I think it can do everything we need it to do. This, amongst other anti-canvas issues that browsers have (canvases can/are used for fingerprinting in browsers, and so we've had to deal with working around issues that were introduced by browers attempting to combat fingerprinting). SVG's should work better for all of that, and make things usable when strict privacy modes are on (which results in our board looking like garbled static on those browsers sometimes). Should, in theory, fix issues like this too.

from online-go.com.

adamreisnz avatar adamreisnz commented on September 4, 2024

Interesting, thanks. I'll have a look into that for my own project (Let's play go) as well. Currently using canvas, but it does have its quirks.
Especially when dealing with rendering drop shadows for stones etc it can be a bit of a pain to clear/redraw them properly. If that can be just an SVG with a CSS applied drop shadow that would be so much cleaner.

from online-go.com.

ChrisMoutsos avatar ChrisMoutsos commented on September 4, 2024

Are you also on Mac, and also using Chrome @ChrisMoutsos ?

Chrome version 124, are you both still seeing this?

Yes, I am on a Mac (Ventura 13.4) and using Chrome (Version 124.0.6367.119 (Official Build) (arm64)). I am still seeing it as well.

from online-go.com.

anoek avatar anoek commented on September 4, 2024

There is now an SVG renderer available that should resolve this issue, see https://forums.online-go.com/t/new-experimental-svg-based-goban-renderer/51831

With that option enabled, can either or both of you check things out and see if it's fixed for you? Thanks!

from online-go.com.

ChrisMoutsos avatar ChrisMoutsos commented on September 4, 2024

Late reply, sorry... It seems like the original issue for me DID go away at some point, but I never switched the goban renderer to SVG! My Chrome updated in the meantime, to Version 125.0.6422.176 (Official Build) (arm64), so maybe that was a contributing factor.

In any case, the SVG renderer feature is awesome, thank you for that. It might help issue #1366 as well?

from online-go.com.

anoek avatar anoek commented on September 4, 2024

I think it's a step in the right direction for #1366 for sure. It's unclear to me how close it gets us, but at at least all the tools available for dealing with the dom become available for that purpose.

from online-go.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.