Comments (16)
On mobile it's a canvas allocation issue (out of memory). It only happens on iOS, and it'll happen after a couple of allocations or several hundred, sometimes it'll be a very tiny allocation (like we do for the stones), or sometimes the whole board. It feels to me like the browser isn't reclaiming some form of memory browser-wide, causing seemingly random failures on our site in particular, but I don't know for sure.
from online-go.com.
Yeah, shadows were a big pain. We'll see how it goes, I went with canvas originally because SVG support was inconsistent and glitchy way back when, but it's pretty solid now so I think it'll probably be an overall win these days.
from online-go.com.
Thanks, I have switched it on, and so far no issues it seems 👍🏼
from online-go.com.
The same thing is happening on the home page with the games overview:
![image](https://private-user-images.githubusercontent.com/490562/322779957-cfa65472-ee8c-4957-bca1-f2f223754a99.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUzOTEyMTIsIm5iZiI6MTcyNTM5MDkxMiwicGF0aCI6Ii80OTA1NjIvMzIyNzc5OTU3LWNmYTY1NDcyLWVlOGMtNDk1Ny1iY2ExLWYyZjIyMzc1NGE5OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwM1QxOTE1MTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNTNiZTc5MmE0N2U3ZjhhY2NkODQyYzc5YzgzOTI1ODU1ZjgzMTVjZDA3YTM4N2Y3ZDI2ZjJlZDJlMWI3NjQ5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Sx50xDaXKW0j94wwlKAwvky3RQ58hh-rM15Imm-q8q8)
from online-go.com.
I am experiencing this bug as well. I am not sure what causes it exactly, either.
from online-go.com.
Are you also on Mac, and also using Chrome @ChrisMoutsos ?
Chrome version 124, are you both still seeing this?
from online-go.com.
Hi @anoek thanks for checking in. I have just checked it with Chrome 124, and have not run into the issue yet. Will post again if it does return, thanks!
Do you reckon it was a Chrome/webkit canvas rendering bug?
from online-go.com.
Ah, looks like I spoke to soon, it's still happening unfortunately, on all 3 tabs that I had opened
![image](https://private-user-images.githubusercontent.com/490562/328280283-dc03eaca-ad2b-440a-9748-ba0b6ade57b1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUzOTEyMTIsIm5iZiI6MTcyNTM5MDkxMiwicGF0aCI6Ii80OTA1NjIvMzI4MjgwMjgzLWRjMDNlYWNhLWFkMmItNDQwYS05NzQ4LWJhMGI2YWRlNTdiMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwM1QxOTE1MTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNGFhZmIzY2MyNWIzODc3YTY3M2MwYjAyNGI0YzQ3MjE0OWY5ZmNhNzcwYmI5NjE3ODA1MjkyMzM3NzM0NjljJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.aLS1uZuRa5o2mG7SCLet-zgW6Bwinn_NWcvDhx5LWoA)
![image](https://private-user-images.githubusercontent.com/490562/328280407-c0b55679-7bb3-4e34-ba36-96f4ad1b2b36.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUzOTEyMTIsIm5iZiI6MTcyNTM5MDkxMiwicGF0aCI6Ii80OTA1NjIvMzI4MjgwNDA3LWMwYjU1Njc5LTdiYjMtNGUzNC1iYTM2LTk2ZjRhZDFiMmIzNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwM1QxOTE1MTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMmMwOWY4NjhmYTVjNzcyYzZkNzQ1MmNkN2EzMDNjYTM1ZmM5MmJjNWE2NDQwZmFlZGNhZjk0ZDlmMTdhNmRiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.ZBk9soqTADV4pWkKtxOHeNocA39RnKIHMlc2dYFeQzk)
from online-go.com.
Bummer.
Whelp, I think the immediate workaround is to switch to a browser that doesn't have that bug, Firefox has always performed quite well.
Longer term the workaround site side is to switch rendering to use SVG's instead of Canvases. That seems to be an increasing priority, so I'll be working on that soon I think - however that's a fair undertaking so in the interim I'd suggest using Firefox.
from online-go.com.
Ok, all good. Nah, I'll stick with Chrome. Will just have to refresh the page every now and then.
Interestingly enough mobile Chrome doesn't seem to be affected?
Do you have any insights into what is actually causing the bug?
And what else has been driving the switch from Canvas to SVG? Curious about that direction.
I didn't think you could do everything you can with Canvas with SVG, but I might be wrong.
from online-go.com.
And yeah, SVG can't do everything canvas can do, but I think it can do everything we need it to do. This, amongst other anti-canvas issues that browsers have (canvases can/are used for fingerprinting in browsers, and so we've had to deal with working around issues that were introduced by browers attempting to combat fingerprinting). SVG's should work better for all of that, and make things usable when strict privacy modes are on (which results in our board looking like garbled static on those browsers sometimes). Should, in theory, fix issues like this too.
from online-go.com.
Interesting, thanks. I'll have a look into that for my own project (Let's play go) as well. Currently using canvas, but it does have its quirks.
Especially when dealing with rendering drop shadows for stones etc it can be a bit of a pain to clear/redraw them properly. If that can be just an SVG with a CSS applied drop shadow that would be so much cleaner.
from online-go.com.
Are you also on Mac, and also using Chrome @ChrisMoutsos ?
Chrome version 124, are you both still seeing this?
Yes, I am on a Mac (Ventura 13.4) and using Chrome (Version 124.0.6367.119 (Official Build) (arm64)). I am still seeing it as well.
from online-go.com.
There is now an SVG renderer available that should resolve this issue, see https://forums.online-go.com/t/new-experimental-svg-based-goban-renderer/51831
With that option enabled, can either or both of you check things out and see if it's fixed for you? Thanks!
from online-go.com.
Late reply, sorry... It seems like the original issue for me DID go away at some point, but I never switched the goban renderer to SVG! My Chrome updated in the meantime, to Version 125.0.6422.176 (Official Build) (arm64), so maybe that was a contributing factor.
In any case, the SVG renderer feature is awesome, thank you for that. It might help issue #1366 as well?
from online-go.com.
I think it's a step in the right direction for #1366 for sure. It's unclear to me how close it gets us, but at at least all the tools available for dealing with the dom become available for that purpose.
from online-go.com.
Related Issues (20)
- Broken github "fork me" image on about page
- Clarify cancellation message to avoid confusion for beginners
- `/me` endpoint returning invalid links with missing `/` HOT 1
- Newly created challenges via API automatically removed HOT 8
- Consolidate OGS API documentations into one, take the obsolete ones offline
- GoTV twitch chat cookies prompt HOT 6
- Stone removal matrix from the end of game is incorrectly used during analysis and score estimation of old moves HOT 4
- end game details are all broken HOT 7
- Live AI review for IRL relays HOT 2
- Ignoring a report causes incident report tracker count to include un-escalated reports
- Ignored reports are no longer ignored after reloading page
- Group incorrectly shown on group list HOT 2
- New X for captured stones - yuck! HOT 3
- Blocked users not blocked enough
- Incorrect rank determination in played matches.
- Title shows (0) moves made which isn't that helpful
- incorrectly displayed strength on the chart. Incorrectly classifies opponent in matches played Stronger/weaker opponents.
- Incorrect "You have won!" announcement for a tied game
- Keyboard shortcuts during AI review
- relocate global toggle for coordinatea
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from online-go.com.