Coder Social home page Coder Social logo

Comments (2)

anoek avatar anoek commented on September 4, 2024 1

I think both are good, I don't recall why we had 3s for mobile still, if asked today I'd say they should just be the same.

Re (a) though I very much so agree, it shouldn't make you wait if nothing changed. I am not sure if that was on purpose a decade ago for some silly reason, or if it was just lazyness to blindly set the timer when a message came in kind of thing. But yes, if nothing changed, you should be able to click accept.

from online-go.com.

benjaminpjones avatar benjaminpjones commented on September 4, 2024

LOL I just looked at the code that disables the button, and I found the answer to "why does this happen sometimes?"

device.is_mobile ? 3000 : 1500,

The timer is 1.5s on desktop and 3s on mobile. I believe there is still an improvement to be made, but I will remove the bug tag since it looks like this long delay is introduced on purpose on mobile.

Two proposals to improve the wait time:

a) Don't disable when opponent accepts (only disable it when territory markings changed)
b) Reduce the time on mobile (I think the desktop limit of 1.5s is fine, but even 2.5s would be an improvement)

from online-go.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.