Comments (2)
I think both are good, I don't recall why we had 3s for mobile still, if asked today I'd say they should just be the same.
Re (a) though I very much so agree, it shouldn't make you wait if nothing changed. I am not sure if that was on purpose a decade ago for some silly reason, or if it was just lazyness to blindly set the timer when a message came in kind of thing. But yes, if nothing changed, you should be able to click accept.
from online-go.com.
LOL I just looked at the code that disables the button, and I found the answer to "why does this happen sometimes?"
online-go.com/src/views/Game/PlayControls.tsx
Line 158 in e5fdc87
The timer is 1.5s on desktop and 3s on mobile. I believe there is still an improvement to be made, but I will remove the bug
tag since it looks like this long delay is introduced on purpose on mobile.
Two proposals to improve the wait time:
a) Don't disable when opponent accepts (only disable it when territory markings changed)
b) Reduce the time on mobile (I think the desktop limit of 1.5s is fine, but even 2.5s would be an improvement)
from online-go.com.
Related Issues (20)
- Show next move and his value in review mode
- UI Nit: Challenge Dialog "Close" button hard to see when using Dark theme HOT 2
- Statisctics for blitz games does not display
- Add convenience link to AI Player profile when creating a computer challenge HOT 1
- "Save tournament" request aborted on success, leaving tournament in edit mode HOT 2
- Filter games by time settings in the "watch" dashboard
- Capture time usage in SGF HOT 1
- Declining Tournament Invite results in Error
- Add a player count to the tournament screen
- Game chat has no space for typing (seems almost unusable!) HOT 9
- Tournament moderation tools broken by f0a617aa009781d1fcbb7074df04e0ac7b68edb2
- Not-loading image in link to GitHub from About page HOT 2
- Displaying numbered moves
- Accepted match shows incorrect players HOT 1
- Please make hover text over the Trophy Icon show the name of tournament.
- Game sorting shows a rengo game where it isnt my turn at the top
- Cheat alert tooltips are not displaying
- Analysis misses some numbered moves when suggesting HOT 1
- Blank board with no grid or stones when clicking back into tab HOT 16
- Share private sgf folders with user
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from online-go.com.