Coder Social home page Coder Social logo

weasis-dicom-tools's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

weasis-dicom-tools's Issues

in JPEG2000, CompressionRatioFactor is different in the image

problem:

  • compress a dicom image with org.dcm4che3.img.Transcoder.dcm2dcm in JPEG2000 (1.2.840.10008.1.2.4.91)
  • check dicom tag LossyImageCompressionRatio

result:
default value for CompressionRatioFactor is 10
LossyImageCompressionRatio is 13.332180546726

expected:
LossyImageCompressionRatio should be 10

Free native memory issue

The native memory is not visible by the java process. The native memory is freed by the "finalize" method managed by the GC (deprecated from Java 9 and removal candidate in Java 19).

See opencv/opencv#22260

error on Windows OS with the processStudy function

Hello,
first of all congratulations for the excellent work.

I have a problem in retrieving images from dicom server with Windows OS. When i execute the CGetForward.processStudy function i get status 65280 as response without any errors; the node called responds correctly by returning the file.
In Linux OS it works.

What could be the problem?

PS. I am using version 5.27.0.2-SNAPSHOT

Can't build version 1.0.0

I've been trying to compile the version 1.0 source code but it doesn't seem to be compatible with the last released build (3.3.7) of dcm4che3 which it relies on. I also tried the current master branch of dcm4che3 but I couldn't get that to build either.
Please could you clarify which version of dcm4che3 it builds against.

CMove.process Passing SOPInstanceUID parameters,obtain the result error

Hello, thank you very much to use your tools version 1.2.0. I found some problems in the use of CMove.process(), need your help.
When I passed StudyInstanceUID parameters, the results correctly;
When I passed SOPInstanceUID parameters, the result error.
the code is as follows:

DicomParam[] params = { new DicomParam(Tag.SOPInstanceUID, "1.2.826.0.3.93.95.201705090910533.6") }; DicomNode calling = new DicomNode("WEASIS-SCU"); DicomNode called = new DicomNode("TRPACS", "192.168.3.120", 11246); DicomState state = CMove.process(calling, called, "DWV-SCP", progress, params);

CLIUtils out of date

The version of CLIUtils seems to be out of date. This creates a conflict because I'm trying to use the weasis-dicom-tools:5.26.0 in combination with Dcm2Jpg org.dcm4che.tool:dcm4che-tool-dcm2jpg:5.26.0, which tries to call public static CommandLine parseComandLine(String[] args, Options opts, rb2, Class<?> clazz), but it doesn't exist.
What's the best way to convert DICOM to JPG in this configuration?

No binary

Am I missing something, or is there no binary (.jar) file for version 1.0.0? I'm trying to build it from source but failing.

dicomizer not coping with jpegs

I'm trying to use the dicomezer.jpg method to convert a jpg to dicom, but it fails with "Missing SOS segment in JPEG stream". I have used 3 different programs to create a jpg, it failed the same way with all 3 files.
I'm confused because I can see that the code is the same as that in dcm4che2.jpg2dcm, which does successfully process the same files.
Example file attached.
report_round_jpg

CStore returned success code despite failing

Calling the CStore method, it failed because the PACS refused the dicom file. An error was printed to the console, but the DicomState object returned by CStore contained status SUCCESS.

The error on the console was:
ERROR: Received C-STORE-RSP with Status A900H for /tmp/7186333108425645099.tmp

CGet.STORAGE_SOP needs to be modifieable

There is no way to extend this array so that CGet can be used for other (less common) data classes.
Also, for those only interested in one type of data, they still have to accept all types which makes the DICOM Conformance Statement look bizarre.

I'm using Weasis tools v1.0.2. Note that ours is a medical product so we want to use a formally released version.

ImageAdapter cannot deal with IncludeBulkData.YES and compressed image data

It is my understanding that the flag IncludeBulkData.YES of the dcm4che DicomInputStream results in the image data being stored in the as a Fragments object with each element being a byte array, while weasis-dicom-tools attempts to cast the byte array into BulkData here:


I am getting the exception on the getBytes call:
Exception in thread "main" java.lang.ClassCastException: class [B cannot be cast to class org.dcm4che3.data.BulkData ([B is in module java.base of loader 'bootstrap'; org.dcm4che3.data.BulkData is in unnamed module of loader 'app')

    ```
    File src =  new File("input.dcm");
    File dest = new File("output.dcm");

    DicomImageReader reader = new DicomImageReader(new DicomImageReaderSpi());
    try (FileInputStream fis = new FileInputStream( src ); DicomInputStream dicomInputStream = new DicomInputStream( fis ))
    {
        dicomInputStream.setIncludeBulkData( DicomInputStream.IncludeBulkData.YES );
        ImageAdapter.AdaptTransferSyntax syntax = new ImageAdapter.AdaptTransferSyntax( UID.JPEGLossless, UID.ExplicitVRLittleEndian );
        Attributes data = dicomInputStream.readDataset();
        AttributeEditorContext context =
                new AttributeEditorContext(syntax.getOriginal(), null, null);
        BytesWithImageDescriptor bytesWithImageDescriptor = ImageAdapter.imageTranscode( data, syntax, context );
        var bytes = bytesWithImageDescriptor.getBytes( 0 );

Publish new versions on maven central

Hi guys,

why do not you publish the jars on maven central? The only version there is 5.22.4. Is that a problem to publish on maven?

maven.scijava.org is pretty often dead, and I am not able to pull the jars. Central repo on the other hand is much more stable and resilent.

Cherrs,
Vlad

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.