Extract Variable refactoring screws up code about abracadabra

[nicoespeon]

Great news @automatensalat 👉 we have a fix!

Fabien and I did a pair-programming session and we found what the problem was. In short, recast (the library that parses the code on top of Babel) counted 4 characters per tab per default. But VS Code counts one. We fixed that discrepancy and everything works fine now.

I'll ship that fix by tomorrow (need to refactor something, update the changelog and ship) 😉

[nicoespeon]

Hi @automatensalat 👋

Thanks for reporting. I'm really curious about this one because I can't reproduce it. I recorded a gif from my editor to show what it looks like with just this code:

So for this specific example, I'm wondering why it doesn't work for you. My main hypothesis is: if it takes time for the editor to trigger the renaming for some reason (it's busy) and you start typing in the meantime, it may mess up the code? Is it what happened?

[automatensalat]

Hey @nicoespeon, that's not what happened, the refactoring executes immediately and I don't do any typing in the meantime. I'm going to look into it today to see what happens.

[automatensalat]

I believe this has to do with indention. As can be seen in your gif, you use two spaces for indention. The tabs from the example code probably get converted to spaces when saving. The refactoring works when used with spaces or no indention at all; it fails if indented with tabs.
I'll look into it and try to find a solution.

Edit: The node.loc seems to be screwed up when used with tabs. But that part is Babel, right?

[nicoespeon]

Edit: The node.loc seems to be screwed up when used with tabs. But that part is Babel, right?

Oooooh, great catch!

Yeah, that's probably Babel since it does the parsing. But I don't get why tabs would screw up the node.loc. If it does, there might be another attribute we could use.

You make me realize we never wrote unit tests with tabs inside. I think I can simulate that easily now. Will see if we can find a fix 👍

[automatensalat]

That's great, thanks! 👋

[nicoespeon]

Fixed in the last release (v3.2.3) 👍