Comments (2)
Indeed, there is an issue when computing the position for the extraction. It's probably looking for the highest possible scope (I don't recall the details) and doesn't consider the position of the references it has.
We probably can refine this so it's created just before the highest reference, like illustrated in your expect
.
Thanks for reporting @tjx666, always appreciated!
from abracadabra.
That was a specific one. Hopefully, your test was really helpful to repro. It was a combination of:
- Replacing multiple occurrences
- Extracting an expression that refers to a variable
- Having the variable declared in the common ancestor of all extracted occurrences
By default, we were declaring the new variable at the top of that ancestor, resulting in the reported bug.
I fixed that so if there is a variable referenced that is declared in the scope, we make sure to declare the extracted variable after.
I captured that with a test and it's passing now 👍
Thank you @tjx666 for the detailed report. That was really, really helpful ❤️
from abracadabra.
Related Issues (20)
- Automatically "Convert to Template String" if we write ${} in a string HOT 2
- Abracadabra does not play nice with cursorless HOT 29
- Inline variable overwrites unrelated parameter
- New refactoring: Simplify boolean logic HOT 9
- abracadabra renameSymbol not found HOT 6
- Refactorings don't work on a specific .ts file HOT 6
- change activationEvent to onLanguage
- Idea: Migrate to TypeScript plugin HOT 4
- "Change Signature" doesn't work on a nested function HOT 3
- "Add explicit type" refactoring HOT 1
- Inline variable if ternary misses parens HOT 5
- split declaration & init when working inside class
- JS and TS code without `;` is broken after refactoring HOT 3
- Abracadabra extension causes performance issues with other extensions (prettier formatting, etc.) HOT 7
- More inline variable missing parentheses edge-cases HOT 1
- Can't move class to an existing file HOT 2
- Move to new file: configure case of the new filename HOT 3
- Upgrade babel/traverse ti eliminate vulnerability. HOT 1
- Convert to Arrow Function: Does not work with a `export default function` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abracadabra.