"Change Signature" doesn't work on a nested function about abracadabra

[nicoespeon]

Hey @SamB, thanks for reporting and creating a test. This was really helpful to debug!

The test was fine. We are not using the actual VS Code editor in most tests so they can run fast. That jest-environment-vscode-extension looks interesting, but is not necessary IMO. Involving the actual VS Code API for most tests will mechanically make them slow. The trade-off is to use the in-memory editor indeed. It replicates the behavior we depend on.

In theory, the behavior we replicate should be covered with a few contract tests: https://github.com/nicoespeon/abracadabra/blob/main/src/editor/editor-contract-test.ts
These tests DO involve the actual VS Code environment. So they are slow, but hopefully there is only a handful. They confirm that the in-memory editor behaves the same as the actual VS Code editor. And indeed, one of the contract test was wrong (our Selection counts lines starting from 0, not 1, and I missed that when reviewing the code).

Interestingly, it wasn't a problem until we get to nested functions. I fixed it (at least, it passes your test + all the existing ones).

So this has been fixed and everything looks good to me now!

[nicoespeon]

@all-contributors please add SamB for bugs

[allcontributors]

@nicoespeon

I've put up a pull request to add @SamB! 🎉