nepnep21 / msa4legacy

Patches for the old minecraft official launcher to add microsoft account support

Frontend hater catgirl who codes sometimes and has many side projects nyaa~

I also occasionally do freelancing, types of projects can be varied (except frontend), currently only accepting bitcoin and monero. Contact me on discord (@nepnepcat) or matrix (@nep_nep:matrix.bottomservices.club).

msa4legacy's Issues

Allow using interactive oauth with a WebView instead of device flow, with device flow still available with a system property

Currently looking for help with this, since i haven't been able to get a WebView to show up in the LogInPopup yet

Launcher straight up stalls after first step of login. Not unresponsive but not working either.

So, I was trying to use the launcher, and log in, but then nothing worked. I clicked on "Microsoft Account", put in my email, clicked "Log In", and there was a text saying to go to a website and enter a code. So far so good. When, though, I entered said code, nothing happened. The website said that I was logged in "Nepauth", but the launcher did nothing. I could still press the buttons, but that's it. As of right now, the "Log In" button does nothing and I cannot log in.

Tried:

• Redownloading the patch file, on multiple versions
• Redownloading the launcher
• Redownloading the installer
• Restarting the launcher several times
• Killing Java and restarting it.

Am I doing something wrong or is there a problem with the launcher.

The installer is missing error message/popup when not all requirements are met

After selecting the launcher.jar and clicking "Save" file select window closes and the "Select launcher jar to install"
stays.

Inconsistent player info states

The player info state (the play button, and the welcome text) are acting inconsistently.

I noticed one of these three would happen:

• It would work perfectly fine
• It would say "Play" but also say "Welcome, guest! Please log in."
  
• The button never stops saying "Loading...", and the side text says "Welcome, guest! Please log in."
  

If it's the second, or third one, then selecting a different profile would typically fix it. The second one still lets you play, even though the side text says you're not logged in.

Due to it being inconsistent, this feels very much like a race condition.

Cannot launch the game

[22:38:44 FATAL]: Unhandled exception in thread Thread[pool-2-thread-3,5,main]
java.lang.reflect.InaccessibleObjectException: Unable to make field private final int java.lang.ThreadLocal.threadLocalHashCode accessible: module java.base does not "opens java.lang" to unnamed module @4df828d7
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354) ~[?:?]
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297) ~[?:?]
        at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178) ~[?:?]
        at java.base/java.lang.reflect.Field.setAccessible(Field.java:172) ~[?:?]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:116) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:72) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.getAdapter(Gson.java:356) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.<init>(ReflectiveTypeAdapterFactory.java:82) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.createBoundField(ReflectiveTypeAdapterFactory.java:81) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:118) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:72) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.getAdapter(Gson.java:356) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.<init>(ReflectiveTypeAdapterFactory.java:82) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.createBoundField(ReflectiveTypeAdapterFactory.java:81) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:118) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:72) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.getAdapter(Gson.java:356) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.fromJson(Gson.java:802) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.fromJson(Gson.java:768) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.fromJson(Gson.java:717) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.fromJson(Gson.java:689) ~[launcher-patched.jar:1.6.93]
        at net.minecraft.launcher.updater.RemoteVersionList.getCompleteVersion(RemoteVersionList.java:41) ~[launcher-patched.jar:1.6.93]
        at net.minecraft.launcher.updater.MinecraftVersionManager.getLatestCompleteVersion(MinecraftVersionManager.java:223) ~[launcher-patched.jar:1.6.93]
        at net.minecraft.launcher.updater.MinecraftVersionManager.getLatestCompleteVersion(MinecraftVersionManager.java:53) ~[launcher-patched.jar:1.6.93]
        at com.mojang.launcher.game.runner.AbstractGameRunner.playGame(AbstractGameRunner.java:76) ~[launcher-patched.jar:1.6.93]
        at net.minecraft.launcher.game.GameLaunchDispatcher$1.run(GameLaunchDispatcher.java:127) ~[launcher-patched.jar:1.6.93]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at java.base/java.lang.Thread.run(Thread.java:833) [?:?]

It also can't seem to load any version of Minecraft

[22:38:22 ERROR]: Couldn't load local version C:\Users\stick\AppData\Roaming\.minecraft\versions\1.8.9\1.8.9.json
java.lang.reflect.InaccessibleObjectException: Unable to make field private final int java.lang.ThreadLocal.threadLocalHashCode accessible: module java.base does not "opens java.lang" to unnamed module @4df828d7
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354) ~[?:?]
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297) ~[?:?]
        at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178) ~[?:?]
        at java.base/java.lang.reflect.Field.setAccessible(Field.java:172) ~[?:?]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:116) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:72) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.getAdapter(Gson.java:356) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.<init>(ReflectiveTypeAdapterFactory.java:82) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.createBoundField(ReflectiveTypeAdapterFactory.java:81) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:118) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:72) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.getAdapter(Gson.java:356) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.<init>(ReflectiveTypeAdapterFactory.java:82) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.createBoundField(ReflectiveTypeAdapterFactory.java:81) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.getBoundFields(ReflectiveTypeAdapterFactory.java:118) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory.create(ReflectiveTypeAdapterFactory.java:72) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.getAdapter(Gson.java:356) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.fromJson(Gson.java:802) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.fromJson(Gson.java:768) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.fromJson(Gson.java:717) ~[launcher-patched.jar:1.6.93]
        at com.google.gson.Gson.fromJson(Gson.java:689) ~[launcher-patched.jar:1.6.93]
        at net.minecraft.launcher.updater.LocalVersionList.refreshVersions(LocalVersionList.java:58) [launcher-patched.jar:1.6.93]
        at net.minecraft.launcher.updater.MinecraftVersionManager.refreshVersions(MinecraftVersionManager.java:80) [launcher-patched.jar:1.6.93]
        at net.minecraft.launcher.Launcher$2.run(Launcher.java:175) [launcher-patched.jar:1.6.93]
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) [?:?]
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
        at java.base/java.lang.Thread.run(Thread.java:833) [?:?]

Modded Jars Won't Launch

Modifying [version].json by removing all of the contents following "MinimumLauncherVersion: 4" is supposed to prevent the launcher from attempting to overwrite the version's .jar file. For some reason, when trying to run my old modified .jar versions from prior to migration, the launcher hangs at "Downloading [version].jar," even though it's been told not to.

I hope to high heaven that this behavior isn't forced by Microsoft, I wouldn't have migrated if I knew this was going to happen.

Checksum issue creates useless patched JAR (with a smaller filesize)

Info

Launch Command: java -jar launcher-1.0.0.jar > output.log, run in directory /home/user/Downloads/launcher/

/home/user/Downloads/launcher/ File Tree

• launcher.jar (4.3 MiB)
• patches.lzma
• installer-1.0.0.jar
  (After run:)
• launcher-patched.jar (219.9 KiB)
• output.log

pacman -Q java-openjfx jre-openjdk jre8-openjdk

java-openjfx 17.0.0.1.u1-1
jre-openjdk 17.0.1.u12-1
jre8-openjdk 8.u312-2

archlinux-java status

Available Java environments:
  java-11-openjdk
  java-17-openjdk
  java-7-openjdk/jre
  java-8-openjdk/jre (default)

uname -r

5.16.5-arch1-1

[Start of] Stack Trace

java.io.IOException: Patch expected net/minecraft/launcher/updater/CompleteMinecraftVersion to have the checksum 74c8a9d but it was eea83fd
	at net.minecraftforge.binarypatcher.Patcher.patch(Patcher.java:197)
	at net.minecraftforge.binarypatcher.Patcher.process(Patcher.java:149)
	at net.minecraftforge.binarypatcher.ConsoleTool.main(ConsoleTool.java:161)
	at me.nepnep.msa4legacy.installer.Main$1$1.actionPerformed(Main.java:29)

Full output at: pastebin.com/tLck8jEt (Almost 5,000 lines)

---

Description

I can only think that a checksum error is because of the version of the launcher I'm using. I got it from this Stack Exchange answer, which gave this link:
launcher.mojang.com/mc/launcher/jar/fa896bd4c79d4e9f0d18df43151b549f865a3db6/launcher.jar.lzma
I lost the original YouTube tutorial I used to get my legacy launcher from. One thing I have noticed is that the usual red text I had at the top of the launcher (saying that it was outdated) isn't there. I think it may be an older launcher version.


Where do I find the right version? (And if this is the cause of my issue, shouldn't there be a note in the README detailing version dependency?)

Do I need to provide any other information?

Doesn't seem to function properly

I followed the instructions in the README and I got an error because patches.lzma wasn't found in my home directory. Ok, I git clones and ran tar -cf patches.lzma --lzma patches/* and copied the lzma file I got into my home directory, reran the installer and it worked. Launched the "patched" launcher and I couldn't log in. Please fix this.

The launcher pesters for login every time it is opened

Every time I open the launcher, I am prompted with the user switcher screen that asks if I want to use the previous account or switch to a different one. I'm not aware of why this launcher has such trouble with saving the login session like the vanilla one did with the Mojang accounts, but it is quite annoying every time I want to play the game.