Checksum issue creates useless patched JAR (with a smaller filesize) about msa4legacy

[NepNep21]

The original launcher version used here can be found in a bug report in mojang's bug tracker, the direct link is https://launcher.mojang.com/v1/objects/eabbff5ff8e21250e33670924a0c5e38f47c840b/launcher.jar and can also be found in the buildscript

MSA4Legacy/build.gradle.kts

Line 83 in a86231d

sourceUrl = "https://launcher.mojang.com/v1/objects/eabbff5ff8e21250e33670924a0c5e38f47c840b/launcher.jar"

I will add it to the README

[toydotgame]

Thanks. That seems to have got the launcher working. It patches correctly and with no errors.
Also, not to be a pain, but, I'm now getting another stack trace:

[16:59:50 ERROR]: Unexpected exception refreshing profile list
java.lang.NullPointerException
	at net.minecraft.launcher.Launcher$2.run(Launcher.java:182) [launcher-patched.jar:1.6.93]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_312]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_312]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_312]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_312]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_312]
[16:59:50 FATAL]: Unhandled exception in thread Thread[AWT-EventQueue-0,6,main]
java.lang.NullPointerException
	at net.minecraft.launcher.ui.bottombar.ProfileSelectionPanel.populateProfiles(ProfileSelectionPanel.java:90) ~[launcher-patched.jar:1.6.93]
	at net.minecraft.launcher.ui.bottombar.ProfileSelectionPanel$1.run(ProfileSelectionPanel.java:84) ~[launcher-patched.jar:1.6.93]
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311) ~[?:1.8.0_312]
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758) ~[?:1.8.0_312]
	at java.awt.EventQueue.access$500(EventQueue.java:97) ~[?:1.8.0_312]
	at java.awt.EventQueue$3.run(EventQueue.java:709) ~[?:1.8.0_312]
	at java.awt.EventQueue$3.run(EventQueue.java:703) ~[?:1.8.0_312]
	at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_312]
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74) ~[?:1.8.0_312]
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728) ~[?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205) [?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) [?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) [?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) [?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) [?:1.8.0_312]
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) [?:1.8.0_312]
[16:59:50 ERROR]: Unhandled exception in executor com.mojang.launcher.updater.ExceptionalThreadPoolExecutor$ExceptionalFutureTask@253cd585
java.util.concurrent.ExecutionException: java.lang.NullPointerException
	at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_312]
	at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_312]
	at com.mojang.launcher.updater.ExceptionalThreadPoolExecutor$ExceptionalFutureTask.done(ExceptionalThreadPoolExecutor.java:72) [launcher-patched.jar:1.6.93]
	at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:384) [?:1.8.0_312]
	at java.util.concurrent.FutureTask.setException(FutureTask.java:251) [?:1.8.0_312]
	at java.util.concurrent.FutureTask.run(FutureTask.java:271) [?:1.8.0_312]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_312]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_312]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_312]
Caused by: java.lang.NullPointerException
	at net.minecraft.launcher.profile.ProfileManager.saveProfiles(ProfileManager.java:70) ~[launcher-patched.jar:1.6.93]
	at net.minecraft.launcher.SwingUserInterface.showLoginPrompt(SwingUserInterface.java:189) ~[launcher-patched.jar:1.6.93]
	at net.minecraft.launcher.Launcher.ensureLoggedIn(Launcher.java:238) ~[launcher-patched.jar:1.6.93]
	at net.minecraft.launcher.Launcher$2.run(Launcher.java:210) ~[launcher-patched.jar:1.6.93]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_312]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_312]
	... 3 more

Pressing the Switch User button prints this trace every press, too:

[17:01:02 FATAL]: Unhandled exception in thread Thread[AWT-EventQueue-0,6,main]
java.lang.NullPointerException
	at net.minecraft.launcher.profile.ProfileManager.saveProfiles(ProfileManager.java:70) ~[launcher-patched.jar:1.6.93]
	at net.minecraft.launcher.SwingUserInterface.showLoginPrompt(SwingUserInterface.java:189) ~[launcher-patched.jar:1.6.93]
	at net.minecraft.launcher.ui.bottombar.PlayerInfoPanel$1.actionPerformed(PlayerInfoPanel.java:49) ~[launcher-patched.jar:1.6.93]
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022) ~[?:1.8.0_312]
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348) ~[?:1.8.0_312]
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402) ~[?:1.8.0_312]
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259) ~[?:1.8.0_312]
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252) ~[?:1.8.0_312]
	at java.awt.Component.processMouseEvent(Component.java:6539) ~[?:1.8.0_312]
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3324) ~[?:1.8.0_312]
	at java.awt.Component.processEvent(Component.java:6304) ~[?:1.8.0_312]
	at java.awt.Container.processEvent(Container.java:2239) ~[?:1.8.0_312]
	at java.awt.Component.dispatchEventImpl(Component.java:4889) ~[?:1.8.0_312]
	at java.awt.Container.dispatchEventImpl(Container.java:2297) ~[?:1.8.0_312]
	at java.awt.Component.dispatchEvent(Component.java:4711) ~[?:1.8.0_312]
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4904) ~[?:1.8.0_312]
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4535) ~[?:1.8.0_312]
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4476) ~[?:1.8.0_312]
	at java.awt.Container.dispatchEventImpl(Container.java:2283) ~[?:1.8.0_312]
	at java.awt.Window.dispatchEventImpl(Window.java:2746) ~[?:1.8.0_312]
	at java.awt.Component.dispatchEvent(Component.java:4711) ~[?:1.8.0_312]
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:760) ~[?:1.8.0_312]
	at java.awt.EventQueue.access$500(EventQueue.java:97) ~[?:1.8.0_312]
	at java.awt.EventQueue$3.run(EventQueue.java:709) ~[?:1.8.0_312]
	at java.awt.EventQueue$3.run(EventQueue.java:703) ~[?:1.8.0_312]
	at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_312]
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74) ~[?:1.8.0_312]
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:84) ~[?:1.8.0_312]
	at java.awt.EventQueue$4.run(EventQueue.java:733) ~[?:1.8.0_312]
	at java.awt.EventQueue$4.run(EventQueue.java:731) ~[?:1.8.0_312]
	at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_312]
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74) ~[?:1.8.0_312]
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:730) ~[?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205) [?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116) [?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105) [?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) [?:1.8.0_312]
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93) [?:1.8.0_312]
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82) [?:1.8.0_312]

I don't know what error this is. I think it's to do with net.minecraft.launcher.SwingUserInterface.showLoginPrompt? Any ideas?

Edit: If it helps, the stack trace when the button is pressed is the same as in the unpatched launcher (but the first stack trace, although the unpatched launcher stack-trace-es on launch too, is different). launcher.jar is 4.3 MiB and launcher-patched.jar is 7.9 MiB too, if that helps.

[NepNep21]

That is likely caused by having files from the new launcher in .minecraft, you can either delete those (but keeping a backup of course) or change this one's working directory with the --workDir argument

[toydotgame]

I specified --workDir ., and everything loads fine, but now there's a HTTP 401 when I press Log In. I authorised NepAuth in my browser and all, but after I finished that and M$ said I could close the tab, nothing changed in the client. I tried relaunching, re-entering my e-mail, and pressing Log In – same error.

Stack trace

Should I close this issue while I work through these other errors, given that AFAIK they're unrelated?

[NepNep21]

Ah i see, i don't know what error you're getting but i do know why it isn't showing, i put the 401 check and the extra logging that allows after the getInputStream call, so it never runs, i'll fix that so you can send a new stacktrace with the info that gives

[NepNep21]

Update once the action for the commit i just pushed finishes running and send the new stacktrace

[toydotgame]

Ah sorry, only saw this notification now. Build #11.

---

Re-M$-authenticated,

then after a few seconds:

[16:49:31 ERROR]: Failed to authenticate
me.nepnep.msa4legacy.patches.MicrosoftAuth$XErrException: XSTS auth returned 401 with XErr 2148916238
	at me.nepnep.msa4legacy.patches.MicrosoftAuth.xstsAuth(MicrosoftAuth.java:167) ~[launcher-patched.jar:1.6.93]
	at me.nepnep.msa4legacy.patches.MicrosoftAuth.access$200(MicrosoftAuth.java:34) ~[launcher-patched.jar:1.6.93]
	at me.nepnep.msa4legacy.patches.MicrosoftAuth$2.apply(MicrosoftAuth.java:75) [launcher-patched.jar:1.6.93]
	at me.nepnep.msa4legacy.patches.MicrosoftAuth$2.apply(MicrosoftAuth.java:57) [launcher-patched.jar:1.6.93]
	at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:616) [?:1.8.0_312]
	at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:591) [?:1.8.0_312]
	at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488) [?:1.8.0_312]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1609) [?:1.8.0_312]
	at java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1596) [?:1.8.0_312]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [?:1.8.0_312]
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [?:1.8.0_312]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) [?:1.8.0_312]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175) [?:1.8.0_312]

(Also happens on Log In button press)

Some quick googling on that XErr code gave me this:

2148916238 - The account is under the age of 18, an adult must add the account to the family.

Apparently my account is under 18? I never set a false birthdate, though, so I don't know how it got that. I haven't messed with family settings, either.

I don't remember where I read this, but it was on a Microsoft site, and it said that outside of the US, age restrictions were different. I used their tool to check for Australia, and it said there was no restriction. So even if I was under 18, it shouldn't've broken.

---

This seems like the issue is now completely on my part, now. I'll see what changing the year of birth does and wait for the API to refresh – and for it to work of for another error code. I don't know how long the info change'll take, though.

[toydotgame]

Ah! There ya go! Made myself younger by five years, waited 10 minutes, and deleted microsoft_accounts.json, and I'm good.