Comments (6)
re: dask
testing - will have to be a separate issue. It can sometimes conflict with optimizations used by numpy
, although the "parallel" option should in theory be compatible. see: #505
re: "In FSS 2D Single Field, don't use all-caps for the author names": will do this - just noting that this was the default output of the doi-based auto citation generator.
from scores.
re: FSS 2D Binary docstring needs parameters, returns, references scores.spatial.fss_2d_binary
:
@tennlee The entire function, args, references, description, typehints etc. is a verbatim copy (and essentially a wrapper, with the threshold omitted) of fss_2d
. It already has a seealso
banner to refer to the argument details from it's parent function. In my opinion, it adds too much clutter to repeat, but if you really want the duplication I can add it in.
from scores.
docstrings have some random rendering issues that need fixing. Also they seem a bit more repetitive for some args, in the new typehint style e.g. for compute_method
from scores.
re:
dask
testing - will have to be a separate issue. It can sometimes conflict with optimizations used bynumpy
, although the "parallel" option should in theory be compatible. see: #505
That's fine. Please raise an issue for that (edit - sorry I overlooked that you already have). I have various tests in other modules which detect the importability of dask and then modify the test as appropriate. Let me know if you want a walkthrough of the hows and whys of the existing test setup.
re: "In FSS 2D Single Field, don't use all-caps for the author names": will do this - just noting that this was the default output of the doi-based auto citation generator.
Understood. No need to use the default output, it's okay to go ahead without all-caps.
from scores.
re: FSS 2D Binary docstring needs parameters, returns, references
scores.spatial.fss_2d_binary
:@tennlee The entire function, args, references, description, typehints etc. is a verbatim copy (and essentially a wrapper, with the threshold omitted) of
fss_2d
. It already has aseealso
banner to refer to the argument details from it's parent function. In my opinion, it adds too much clutter to repeat, but if you really want the duplication I can add it in.
If you think it adds too much clutter, just leave it be, but please take a final look and just consider it. The see-also should help.
from scores.
docstrings have some random rendering issues that need fixing. Also they seem a bit more repetitive for some args, in the new typehint style e.g. for
compute_method
Do you need anything from me regarding this, or do you intend to go ahead and fix these yourself? Just let me know if I need to contribute or answer a question.
from scores.
Related Issues (20)
- [JOSS] Consider tracking coverage HOT 3
- [JOSS] Number scheme is not explained HOT 2
- [JOSS] JOSS statement of need should be expanded HOT 4
- [JOSS] Mention binder availability in README HOT 2
- [JOSS] Add a end-to-end example HOT 3
- [JOSS] Fix warnings in test suite and examples HOT 6
- Support for distributed testing
- Deprecation warning in tutorial for Pearson's correlation coefficient
- Add a "Key Features of `scores`" page to the documentation
- Key Features page in docs - follow up questions
- Tutorial Gallery - put headers in own cells so they render better in readthedocs
- [JOSS] Installation of jupyer kernel HOT 2
- [JOSS] Instructions for downloading example data HOT 1
- [JOSS] General explanation of reduce/preserve HOT 3
- [JOSS] Minimal pandas support HOT 4
- [JOSS] Implementation of weights is occasionally unclear HOT 1
- rename correlation HOT 1
- Badges, CI and forks
- roc_curve_data API rendering in readthedocs HOT 1
- Add threshold weighted scores
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scores.