Comments (4)
As I understand it, we're encouraged to have these discussions as we go, rather than waiting for the review to conclude.
That is also how I understand it yes, so feel free to interact with me or push changes while I'm busy, I'll then try and look at the changes when I have time :)
As for the clarifying replies, these are all really good points, and I would consider adding these in some integrated way to the paper a really good way to resolve my comments. For me this is mostly about highlighting the work you have done already
We have also been cautious in specifically saying what other packages can't do, or can't do as effectively, both to avoid implied criticism of others' work and also for clarity. We have avoided 'stating the negative' about what other packages don't do. No other package meets all the elements of our statement of need.
That is a sensible position to have. I am still on the opinion that pointing out the "weaknesses" in prior work and how this compares to your own is part of the academic process and helps newcomers to your package make an informed decision on whether your package is the right one for them, and that this can be done without being demeaning or overly negative (though that is certainly hard). I don't want to push you to make claims you're not comfortable making, but if possible I'd suggest to give this another pass. I don't consider it a hard requirement for the publication though.
from scores.
I'm happy with the updated submission, I think it highlights the strengths of scores
a lot better. Well done :)
from scores.
Thanks for these comments. As I understand it, we're encouraged to have these discussions as we go, rather than waiting for the review to conclude. We'd be very happy to amend our statement of need to address these comments. We agree the paper needs to make its points clearly. It's very helpful to get a new perspective.
I wanted to provide a brief clarifying reply, to begin answering your questions as you proceed with the rest of the review.
- Scores uses xarray, which is the most commonly used package to support the labelled, n-dimensional data utilised by the meteorological and Earth system community. Verification/stats/metrics packages that are used commonly in data science often only support 1-D data, tabular data, or unlabelled n-dimensional data (see "Data Handling" in statement of need).
- Scores handles dimensionality preferably to most other meteorological packages, and weighting (such as latitude-weighting) preferably to many general data science packages
- Scores provides some novel metrics, developed by our team, which aren't in any other package.
- Commonly-used scores are also provided for completeness and consistency, so
scores
can be used standalone, and also to meet frequent user requests for their inclusion. - It would typically take several packages to achieve most of what scores provides - and even then would not provide all the key benefits of scores.
We will take some more time to consider how to improve the paper to incorporate your feedback and respond further when we have done so.
We have also been cautious in specifically saying what other packages can't do, or can't do as effectively, both to avoid implied criticism of others' work and also for clarity. We have avoided 'stating the negative' about what other packages don't do. No other package meets all the elements of our statement of need.
from scores.
We have updated the paper (paper.md) on branch 528-joss-paper-submission so it is now ready for further review. We have also made some updates to the documentation on the develop branch which has not made its way yet to main (see https://scores.readthedocs.io/en/latest)
from scores.
Related Issues (20)
- [JOSS] Consider tracking coverage HOT 3
- [JOSS] Number scheme is not explained HOT 2
- [JOSS] Mention binder availability in README HOT 2
- [JOSS] Add a end-to-end example HOT 3
- [JOSS] Fix warnings in test suite and examples HOT 6
- Support for distributed testing
- Deprecation warning in tutorial for Pearson's correlation coefficient
- Add a "Key Features of `scores`" page to the documentation
- Key Features page in docs - follow up questions
- Tutorial Gallery - put headers in own cells so they render better in readthedocs
- [JOSS] Installation of jupyer kernel HOT 2
- [JOSS] Instructions for downloading example data HOT 1
- [JOSS] General explanation of reduce/preserve HOT 3
- [JOSS] Minimal pandas support HOT 4
- [JOSS] Implementation of weights is occasionally unclear HOT 1
- rename correlation HOT 1
- Badges, CI and forks
- roc_curve_data API rendering in readthedocs HOT 1
- Add threshold weighted scores
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scores.