Comments (4)
@tennlee I've reviewed the code, equations and mathjax - I could not find any issues. (Just waiting on your cross-review of the heidke skill score mathjax and we're all good.)
Since this is a math review, real world testing (and boundary tests like divide by 0) are out of scope.
As a side note, I found it interesting that there are different representations of the more complicated skill scores. An optional suggestion (if it isn't already implemented) would be to add unit tests that check the alternative representations for the more complicated scores against each other; this would also automatically serve as a "sense check" for the equivalence of simpler scores. However, this a "nice to have" and not mandatory for v1.0
.
from scores.
Fantastic, thank you so much for doing that review, really appreciate it.
Over time, we should possibly add additional edge case / boundary case testing, but the notebooks and manual usage all add non-automated coverage.
from scores.
As far as I can tell, with the merge of Heidke's Skill Score, this is all done. I'll leave it to you to confirm and close when you are ready however.
from scores.
Review is complete - closing.
from scores.
Related Issues (20)
- [JOSS] Consider tracking coverage HOT 3
- [JOSS] Number scheme is not explained HOT 2
- [JOSS] JOSS statement of need should be expanded HOT 4
- [JOSS] Mention binder availability in README HOT 2
- [JOSS] Add a end-to-end example HOT 3
- [JOSS] Fix warnings in test suite and examples HOT 6
- Support for distributed testing
- Deprecation warning in tutorial for Pearson's correlation coefficient
- Add a "Key Features of `scores`" page to the documentation
- Key Features page in docs - follow up questions
- Tutorial Gallery - put headers in own cells so they render better in readthedocs
- [JOSS] Installation of jupyer kernel HOT 2
- [JOSS] Instructions for downloading example data HOT 1
- [JOSS] General explanation of reduce/preserve HOT 3
- [JOSS] Minimal pandas support HOT 4
- [JOSS] Implementation of weights is occasionally unclear HOT 1
- rename correlation HOT 1
- Badges, CI and forks
- roc_curve_data API rendering in readthedocs HOT 1
- Add threshold weighted scores
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scores.