Coder Social home page Coder Social logo

Comments (4)

nikeethr avatar nikeethr commented on July 20, 2024

@tennlee I've reviewed the code, equations and mathjax - I could not find any issues. (Just waiting on your cross-review of the heidke skill score mathjax and we're all good.)

Since this is a math review, real world testing (and boundary tests like divide by 0) are out of scope.

As a side note, I found it interesting that there are different representations of the more complicated skill scores. An optional suggestion (if it isn't already implemented) would be to add unit tests that check the alternative representations for the more complicated scores against each other; this would also automatically serve as a "sense check" for the equivalence of simpler scores. However, this a "nice to have" and not mandatory for v1.0.

from scores.

tennlee avatar tennlee commented on July 20, 2024

Fantastic, thank you so much for doing that review, really appreciate it.
Over time, we should possibly add additional edge case / boundary case testing, but the notebooks and manual usage all add non-automated coverage.

from scores.

tennlee avatar tennlee commented on July 20, 2024

As far as I can tell, with the merge of Heidke's Skill Score, this is all done. I'll leave it to you to confirm and close when you are ready however.

from scores.

nikeethr avatar nikeethr commented on July 20, 2024

Review is complete - closing.

from scores.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.