nationalsecurityagency / dcp Goto Github PK

Software in Rust is as fast as C++ and secure as Java.

makansh khadma m3akm? hh

(ngassar brk, 7abit n3rf brk esq tfahmo darja)

INSTALL is very misleading and does not contain proper directions for compiling. README-devel contains the correct directions for compiling. INSTALL should either mirror README-devel or refer to it.

I thought that the project structure was a little weird, and using bash scripts and a build-and-configuration system seemed like the worst of both worlds, so I refactored both the project and the build system.

As it currently stands, to build the project, you simply run ./configure && make, and the project is good to go. The gengetopt files still get generated, but they are explicit dependencies now, which the makefile generated by autoconf handles. It also still generates the config.in.h header, but now it puts it in the dedicated include folder, where all of the headers live.

I also removed the multi-levelled header and source file structure, as I'm not sure it really served a purpose, since all of it was a single project, rather than a group of projects that built separate libraries and then linked together. To modify the header and source file include directives, I just used a sed script to delete the ../(impl|io|index)/ part of the include statement.

I also updated the README file, and it now clearly indicates that the project requires gengetopt. It successfully built with multiple version of GCC, Clang, and ICC, all of which are listed on the readme (the version that were tested, that is). It also explains how to build the project, as well as some of the lmitations of the refactored version, as it currently stands. For example, while you can configure the CFLAGS, CPPFLAGS, LDFLAGS, and CC variables as normal, the compiler indicated by CC is currently used as the linker driver. This implicit dependency is on the chopping block as this refactor continues.

While the project does build and is configurable, this is still very much a work-in-progress, as the full flexibility of the autotools toolset isn't being used to its full potential. I will be referencing this issue in the commit, I just had to actually create it, per the contributing guide.

XATTR_Branch differences from master should be documented. It's not clear whether these are future changes which will be merged in, or if this is a permanent divergence. If it's a permanent divergence, please provide explanation for using one over the other, in the README, and converge the trivial differences between the branches (whitespace, indentation, wrapping), to make it easier to git diff the two and examine their differences.