Coder Social home page Coder Social logo

wallet-android's People

Contributors

agneslovelace avatar alexanderpavlenko avatar alexeylazitski avatar aliakseilazitski avatar alteragent avatar apetersson avatar computerpoet avatar danielweigl avatar giszmo avatar gosuto-inzasheru avatar itserg avatar jeromerousselot avatar johnzweng avatar kallerosenbaum avatar kaue avatar kurtnebiev-elvis avatar kurtnebiev-elvis1 avatar kurtnebiev-elvis2 avatar kurtnebiev-elvis3 avatar kurtnebiev-elvis4 avatar mikhailzisman avatar nurunabiyev avatar obrazcoff avatar poletova-n avatar prusnak avatar sergeylappo avatar wacomalt avatar wiz avatar xelvis89x avatar zuevroman avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

wallet-android's Issues

NFC support

Hello I'd like to see NFC support in mycelium.

I see that you have android.nfc.action.NDEF_DISCOVERED commented out in your AndroidManifest. Was this functionality tested out at one point?

If I wrote a patch to mycelium, would you accept it?

Thank you,

adrian

mined coins spendable too early.

mined coins should be shown as incoming/not spendable until 120 confirmations. right now it is possible to construct a transaction from freshly mined coins.

I CAN'T SPEND THE BACKUPPED MONEY

I backupped the keys and save them on physical support as SD, but after a reinstallation of the wallet (mobile android), i clipboard the jpeg keys and the wallet just read it.
The wallet doesn't allow to spend/send the money, just read only.
What to do?
Thank you.

landscape specific layout

right now it all "works" but is not pretty and sometime users have to scroll needlessly. make specific landscape layout.

BTC-E as Exchange Source

BTC-E.com is one of the most popular exchanges in Europe. It would be great to see it in Exchange Sources.

Desperately need more than ten active addresses!

Loving Mycellium until I hit this wall.

This has got to be an easy fix.

Please just change the number of storage variables now and recompile.

Anyone with divided funds and more than a few mining activities has to set up more addresses!

No AndroidManifest.xml

I was looking for declared intents in manifest, but there are no android files, manifests, layouts etc... :-(

Digit grouping for large numbers

Please consider grouping large numbers in threes to be more human-readable, so that instead of 1258155.058 mBTC or 1588411.79 USD, the users sees one of the following:

1,258,155.058 mBTC and 1,588,411.79 USD (North American)
1 258 155.058 mBTC and 1 588 411.79 RUR (generic grouping)
1.258.155,058 mBTC and 1.588.411,79 EUR (European)

Giving an option in Settings for the user’s desired grouping syntax would be even better.

Issue with build

Error below. Any ideas?

dyn-160-39-195-144:wallet-master jasonravel$ ./gradlew build

FAILURE: Build failed with an exception.

  • What went wrong:
    A problem occurred configuring project ':public:mbw'.

    Failed to notify project evaluation listener.
    Could not resolve all dependencies for configuration ':public:mbw:_ProdnetDebugCompile'.
    Could not find any version that matches com.android.support:appcompat-v7:18.0.+.
    Required by:
    wallet-master.public:mbw:unspecified
    Could not find any version that matches com.android.support:gridlayout-v7:18.0.+.
    Required by:
    wallet-master.public:mbw:unspecified

  • Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

new-ver 1.0.4 Export Problem

Samsung G2 phone SGH-T989
android 2.3.6
Kernel ver 2.6.35.11-1209942
Build GINGERBREAD.UVLDH

The latest version of Mycelium wallet has broken my export feature
QR code for export looks like gibberish after upgrade from previous version
see attached photo
20131122_152039

Checking "cold storage" without internet connection

Sometimes it is needed to check "cold storage" for what:

  • I don't forget BIP38 password
  • It is printed correctly

But little bit scared do "import key" with internet connection because of viruses/malware/google backdoors or something else could be on the phone.

In current version when i tap "cold storage" without connection it says after decryption process "error: no connection". So it would be grate to consider about this feature

fortuna build error with v1.1.5 and master

During gradle build on windows, I get the following error. Failed assertion for a test of fortuna. Any ideas?

:public:bitlib:test

se.grunka.fortuna.entropy.URandomEntropySourceTest > shouldAddUptime FAILED
java.lang.AssertionError at URandomEntropySourceTest.java:42

48 tests completed, 1 failed, 1 skipped
:public:bitlib:test FAILED

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':public:bitlib:test'.

Import whichever key is scanned, regardless of context.

I lost 6.5 BTC the other day because I scanned my private keys from the "Addresses" tab instead of the "Keys" tab. I think the user assumption is that the key that is scanned is the one imported. At least, a warning could be presented letting the user know that even though they scanned the private key, only the public key will be imported if on the "Addresses" tab.

clipboard use for backup password

It was avoided to have the private keys go through the android clipboard as any app could spy on it and the whole encrypted key backup is nice but has a flaw. When I have to verify a backup of 12 keys, I have to type the password 12 times or I copy it if I'm quick enough. Both is not good.
Please address this by either remembering passwords for one scanning session or by disabling the edit/copy feature. Alternatively ask to auto-confirm public keys on the same print-out (that might have to be scanned individually). That should be faster and doesn't require the password anyway.

don't consider unconfirmed change to be spendable

It appears to me that mycelium considers all change in the wallet to be spendable whether it is confirmed or not.

With the ongoing "malleable transactions" DDoS attack, that isn't a safe thing to do. It's quite possible that change I created myself never confirms, due to a clone of my outgoing transaction getting confirmed rather than my transaction.

Would it be possible to add an option to prohibit unconfirmed change outputs from being considered as spendable?

Failed restoration from PDF backup

Hi
I am looking for help:

I have Mycelium wallet
I sent 1 mBTC and it has got into the wallet properly.
I backed it up to a PDF file with writing down properly the capital letters key

Now: i wanted to test a scenario of completely removal and re-installation on other device

I removed the application from my device
Then re-installed again

I open the new installed application (new address is automatically created) and then went to:
Menu -> Settings -> Expert Mode. i checked the Expert Mode with V.
Now, i got back to the main screen -> KEYS tab -> click on the upper Key+ icon and I scanned the Bitcoin address (left QR square) from the PDF backup. all worked OK. a new address (the original one, from the PDF) was created successfully. I have selected this address to be my main active address.

At this stage i could see my 1mBTC balance but couldn't use it for anything since my private keys has not been imported yet.

I went back again to the main menu -> Verify Backup and scanned the private key from the PDF (the right QR square), I typed in the decryption capital letters password correctly and got the message that my private key was imported successfully.

Now, the point is that although it seems like my private keys has been imported successfully, when I am going to BALANCE tab, there is no "send" button there. Moreover, click on the QR code is resulting in a message "Warning: your wallet does not have the private key for this address. You cannot spend coins received unless you have the private key elsewhere".

Please can help me with this? What am i doing wrong? what is missing here?

Displaying message from Bitcoin URI

When we send new Intent from other app there is one optional parameter "message" in the URI. But it is not displayed in Mycelium wallet (Coinbase app, for example, displayed it properly).

// I mean this "message" parameter in uri:
URI uri = Uri.parse("bitcoin:1FfZBhs...?message=Donation")
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setData(uri);
startActivity(intent);

Duplicates in Transaction History

I sent a transaction and entered the wrong PIN on the first try. The second attempt was successful, but now there same transaction appears in the history twice.

Needless to say, this was confusing ad worrying. But the hash is the same on both and blockchain.info also only displays one transaction actually having gone through.

transactions made using mycelium not showing up in mycelium

Yesterday I made a few transactions. On two separate occasions the transaction appeared to go through OK, but wasn't shown on the transactions display, and wasn't subtracted from my available funds.

I checked on blockchain.info and they had indeed been broadcast to the network, and upon pressing the refresh icon in mycelium they did appear in the app.

This seems like a dangerous behaviour, since I could have assumed the transactions hadn't been made, and sent them again, effectively paying someone twice by mistake.

I can understand connectivity issues possibly causing transactions not to be received from other devices, but these two were generated in the device which claimed not to know about them, which is strange to me.

I installed mycelium from the play store, so presumably have the current version installed.

Paying miner fee should be optional or definable.

I don't always need my transaction to go through as quickly as possible and sometimes I do. If I want to send less than 0.0001 BTC, the app won't let me. If I want to send 0.0001 BTC, the app adds a miner fee of 0.0001 BTC which is double the original amount. If a hamburger cost 0.0001 BTC in the future, I would definitely not use this app. As the value of BTC changes, I want to be able to change the fee I pay.

Context menu on long press

When we manage keys it would be great to have posibility delete and archive them by context menu on long tap on the item. Why? Less movements, less taps. Just suggestion.

No options button

On my HTC One, I don't see an options button. On the main page, I see:

Your bitcoin address: [QR code]
1JUA...

Your balance:  [refresh arrow]
~USD 0,00

Send  Receive

1 BTC ~ USD 359,99 (Bitstamp)

Beta build version 0.8.5, use at your own risk.

I'm able to swipe left to reveal the transaction history page:

Transaction history  [refresh arrow]

No Transaction Records

Beta build version 0.8.5, use at your own risk.

In addition, I can enlarge the QR code or share by Bitcoin address. But no options button anywhere :(

BIP38 Decryption Key Generation Stops on Device Rotation

My device is an AT&T HTC OneX, Android 4.2.2. Mycelium version 1.1.10.

When trying to spend from BIP38 encrypted cold storage rotate the device while it is generating the decryption key from your passphrase. On rotation, the dialog showing the progress on generating the decryption key disappears and the process has stopped and must be restarted.

This is obviously not a critical bug, but is certainly annoying and seems like it should be easily preventable.

mBtc should affect exchange rate

Setting the unit of Bitcoin to mBTC should be reflected in the display of the exchange rate as well. So instead of 1 BTC = USD 1 193.35 (Mtgox)

it could show
1 mBtc = USD 1.19335

I am not sure how to handle fractions in this case.

so would it be
1 uBtc = USD 0.00119335 ? full precision?
1 uBtc = USD 0.001193 ? (4 significant digits?)
1 mBtc = USD 1.19 (rounded to cents?)

Building fails after following instructions.

After following the instructions in the README the build fails with errors

No value has been specified for property 'signingConfig.storePassword'
No value has been specified for property 'signingConfig.keyPassword'

This seems to be caused by me not having set the path and password to the keystore correctly. The thing is, I don't want to sign the apk immediately. I want to sign it on an offline computer. What should I do?

Multisig addresses not recognized on Testnet client

The Mainnet client correctly recognizes multisig addresses (as much as I could test it so far). The Testnet version however does not, can returns an "Unrecognized format" message.

I was trying out GreenAddress, which uses 2-of-2 multisig. Before using it for actual coins, wanted to test their Testnet version. Unfortunately that doesn't work with Mycelium Testnet, since their receive addresses are unrecognized by the app.

Show time stamps in system format

In the Android display settings I can choose to have my clock display in 24 hour time. I noticed that some apps react to that and also change the way they display the time, but Mycellium does not.
This isn't a serious issue but just some extra polish before a 1.0 release.

Show nearby OpenStreetmap Bitcoin nodes

I believe the tag to look for is payment:bitcoin=yes, but there may be others. This would both encourage putting Bitcoin locations into OSM and make it easier to find places to spend or get Bitcoin.

option to encrypt wallet on device

Is there documentation explaining how the wallet is encrypted on the device? I'd like to know a bit more about how secure this is. Is the encryption key based on the pin? Is there anything to prevent someone who gains access to the encrypted data from trying all 6 digit pins quickly?

Low precision of BTC balance, can't send less than 100 uBTC

Is the precision of BTC balance is only 4 decimal places? That is all it shows, where a standard Satoshi is 8. Even though the app has uBTC, I can't actually spend/send less than 100 uBTC. This is about a penny USD, which isn't much now. But if the value goes up, this wallet could be blocking me from getting that money.

Encrypted PDF Backup problem

HTC Legend
Android 2.2
Kernel 2.6.32.17-g30929af
Mycelium 1.1.2

Application crashes on "Encrypted PDF Backup" page. "Preparing encryption key... 0%" message appears and then oops (report sent). What additional info can I provide?

Can't export private keys on phones with no SD card slot

I have a Samsung Galaxy Nexus and a HTC One (European version), and neither of them has SD card slots.

The only private key export options in Mycelium are QR code, clipboard and SD card.

I'm not comfortable with copy-pasting the private key into other apps or taking a picture of the QR code to another device.

I'd prefer to be able to copy encrypted private keys to the filesystem, Google Drive or Dropbox. Or just encrypt and save them into my Google account data.

app icon is low res

I like the icon, but frankly, it looks pretty bad in my Nexus 5. It would be nice to have a full res icon.

balance in adressbook

Id like to see the balance of adresses in my adressbook, including my own archived adresses.

Autofocus not working on Samsung Galaxy Note

Hi there,

I am unable to use cold storage because I cannot scan the QR codes. Because the autofocus is not working on my Samsung Galaxy Note. I tried enabling and disabling autofocus in the settings, but this seems to affect the brightness, not the autofocus. With autofocus disabled, the image is almost only white. With autofocus enabled the brightness is ok, but no focus. Currently I scan the QR code with another app, then save it to the clipboard and use it from there in Mycelium.

Can I help in fixing this? If there is anything I can to please let me know.

Best,
Andreas

New PDF backup scheme does not work well with an offline phone

I use an Android phone in airplane mode as a means for storing some offline funds. I am unable to backup my keys because my only options with the PDF are to "Share" via Bluetooth or Gmail. An option to copy the PDF to the SD card would be appreciated.

Allow grouping or tagging of addresses

Tagging addresses would make for an extremely powerful key management system without adding any inherent complexity.

An individual could have 'personal' and 'business' tags, and the business tag could have child tags like 'art sales' and 'freelance payments'.

I realize this is a pretty broad and far-out request; really I'm looking to see if this is the kind of feature you'd accept. If so I'd work on it myself.

Amount cut off

When spending coins, the amount is sometimes cut off.
on some phones, the amount should be displayed in its own line

Backups should be easy

Having tried many different virtual currency wallets, I'm finding that backups are messy and poorly designed. And I didn't see this issue discussed in the existing issues here, so below are a few ideas for consideration.

Backups should be easy and fail-safe.

At backup time, the user should need to neither type [note 1] nor read and record any encryption key. People make typographical mistakes all the time, especially on a small smartphone screen. Instead, a predetermined public key should be used to encrypt the backup, similar to the way GPG encrypts messages. Later on, at restore time, the private key will be used to do the restore. This private key need not be known to the program creating the backup.

The backup file should include essential information in its name [note 1]. E.g.: name of program, backup format, datestamp. So simply looking at the filename will tell us at restore time how to use the file. The person doing the restore might be a knowledgable friend, not the naive user doing the backup, so let's save them some trouble trying to guess where the backup came from.

In addition to saving to mass storage, also, wherever possible, send the backup by email in the background so the user doesn't have to think about it. This might be possible on most desktop machines. On an Android device, invoke the mail program with the destination address already filled in, so the user needs to only press Send.

If possible, Android apps should also save the backup in a place where it will automatically get backed up by Google's "Android Backup Service", ready for restore should the Android device go through a factory reset and/or be replaced by another.


I recently posted the above comments in the issue tracker for the Android Dogecoin wallet, and you will see some follow-up comments and my responses. Please take a look there too. Thank-you!

Note 1. I didn't make my comments specific to the Mycelium wallet, so please ignore the parts (e.g., typing an encryption key) that don't apply here.

Offline signing

Would be nice having the mobile wallet cosigned/signed offline with another smartphone phone in offline airplane mode. I think it is the cheapest easiest solution since many people have/will have a secondary/old smartphone. The two phones can communicate using QR codes using the camera. A similar scheme to bitcoin armory but for mobile.

I can't send an amount in USD

Hi, I have selected MtGox as my exchange source but today I can't specify an amount in Fiat and switch between fiat and BTC while entering the amount.

Please help me.

Faster access to QR scan

As a user I want to be able to open app and in one click go to QR scanning.

Now I need to click send and then Scan QR Code.

Some shortcut button in the main Activity would led to better UI experience.

License of the code is unclear

Currently, the source code of Mycelium doesn't have a license. It would be good to clarify it, either in the README, as a LICENSE file or as a header in the files

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.