mveytsman / heroicons_elixir Goto Github PK

Hey there, thanks for this package, we love it!

I've noticed in the latest release I get a warning when using apply, like so:

  @doc """
  Accepts the following attributes:

    * name
    * outlined
    * and any other HTML attribute: class, aria-label, etc

  ## Examples

      <.icon name={:home} outlined class="text-gray-400" />
      <.icon name={:home} class="text-gray-400" />
      <.icon name={:home} />
  """
  def icon(assigns) do
    assigns =
      assigns
      |> assign_new(:outlined, fn -> false end)
      |> assign_new(:class, fn -> "w-4 h-4 inline-block" end)
      |> assign_new(:"aria-hidden", fn -> !Map.has_key?(assigns, :"aria-label") end)

    ~H"""
    <%= if @outlined do %>
      <%= apply(Heroicons.Outline, @name, [assigns_to_attributes(assigns, [:outlined, :name])]) %>
    <% else %>
      <%= apply(Heroicons.Solid, @name, [assigns_to_attributes(assigns, [:outlined, :name])]) %>
    <% end %>
    """
  end

With the following warning:

warning: <%= chart_bar(class: "..." %> is deprecated, please use <.chart_bar class="..." /> inside HEEx templates instead
  (heroicons 0.3.0) lib/heroicons.ex:27: Heroicons.Outline.chart_bar/1
  (my_app 0.1.0) lib/myapp_web/live/live_helpers.ex:103: anonymous fn/2 in MyAppWeb.LiveHelpers.icon/1
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/engine.ex:124: Phoenix.HTML.Safe.Phoenix.LiveView.Rendered.to_iodata/1
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/engine.ex:140: Phoenix.HTML.Safe.Phoenix.LiveView.Rendered.to_iodata/3
  (my_app 0.1.0) lib/myapp_web/live/live_helpers.ex:123: anonymous fn/2 in MyAppWeb.LiveHelpers.link/1
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:387: Phoenix.LiveView.Diff.traverse/7
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:515: anonymous fn/3 in Phoenix.LiveView.Diff.traverse_comprehension/4
  (elixir 1.13.2) lib/enum.ex:1715: Enum."-map_reduce/3-lists^mapfoldl/2-0-"/3
  (elixir 1.13.2) lib/enum.ex:1715: Enum."-map_reduce/3-lists^mapfoldl/2-0-"/3
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:462: Phoenix.LiveView.Diff.traverse/7
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:486: anonymous fn/4 in Phoenix.LiveView.Diff.traverse_dynamic/7
  (elixir 1.13.2) lib/enum.ex:2396: Enum."-reduce/3-lists^foldl/2-0-"/3
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:387: Phoenix.LiveView.Diff.traverse/7
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:486: anonymous fn/4 in Phoenix.LiveView.Diff.traverse_dynamic/7
  (elixir 1.13.2) lib/enum.ex:2396: Enum."-reduce/3-lists^foldl/2-0-"/3
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:387: Phoenix.LiveView.Diff.traverse/7
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/diff.ex:138: Phoenix.LiveView.Diff.render/3
  (phoenix_live_view 0.17.6) lib/phoenix_live_view/static.ex:244: Phoenix.LiveView.Static.to_rendered_content_tag/4

Downgrading to 0.2.2 removes the warning. I noticed recently there was in change in how things were generated, but I wasn't 100% sure without a changelog or commits to mark the 0.3 release. Any ideas?

Currently outline is the implicit default, but one cannot explicitly use outline as an attribute on heroicons like so: <Heroicons.photo outline />

Hey, first and foremost thanks for this.
I was using heroicons on my project but extracing the SVGs into a file and created a Macro to do the in-lining, but using the new Pheonix components is much better DX, so thanks for this package. :)

I was thinking it would be cool to have a way to update the SVGs (in priv) easily so it's easier to keep up with new releases?
Took some code from the Phoenix Tailwind and sass installers for the downloading part. After the unziping of the archive, we just copy the optimized directory contents to the priv folder.
Wrapped it into a heroicons.update Mix task.

If you think this is useful, I can open a PR.

My commit is here: greven@8b890e3

Now that LiveView is adding stateless function components (phoenixframework/phoenix_live_view#1428), we can can use them for heroicons.

It's possible that they will work out of the box and we just need to add some documentation.

👋🏼 Hi there! I'm trying to find the refresh icon, but it doesn't seem to exist in the library, or at least I can't find it. Is it possible to add it? Do you accept PRs?
Thanks in advance 🙌🏼

Is there an easy way to pass in the icon name as an argument?

eg:

<Heroicons.icon name="academic-cap" class="h-4 w-4" />

The following code now raises an error with the latest version of heroicons -

<Heroicons.arrow_right_on_rectangle class="w-6 h-6 mr-2 inline" />

The function component arrow_right_on_rectangle does not define a micro attribute, so the svg function has no micro attribute in the assigns and falls through to the error clause.

Heroicons v2 has launched and has a new option mini

https://twitter.com/steveschoger/status/1562117153591107586

Would it be possible to add an option to change the stroke-width attribute of the path element in the SVG?

For my current case I'd like to use a Heroicon but with stroke-width set to 1:

<svg xmlns="http://www.w3.org/2000/svg" class="h-6 w-6" fill="none" viewBox="0 0 24 24" stroke="currentColor">
  <path stroke-linecap="round" stroke-linejoin="round" stroke-width="1" d="M5.121 17.804A13.937 13.937 0 0112 16c2.5 0 4.847.655 6.879 1.804M15 10a3 3 0 11-6 0 3 3 0 016 0zm6 2a9 9 0 11-18 0 9 9 0 0118 0z" />
</svg>

The tag could have an optional attribute so it would be called like:

<Heroicons.Outline.user_circle class="h6 w-6" stroke-width="1" />

As per the title, is there any plan to update icons to the latest version (2.1.1)?

If I'm not mistaken, it's sufficient to run the heroicons.update task, I can make a PR with updated icons.

The mix.exs file has:

If you try to use Live View 0.19 and this package you get this error:

#0 2.180 Because "your app" depends on "heroicons 0.5.2" which depends on "phoenix_live_view ~> 0.18.2", "phoenix_live_view ~> 0.18.2" is required.
#0 2.180 So, because "your app" depends on "phoenix_live_view 0.19.0", version solving failed.

The arrow_right_on_rectangle icon is missing micro attribute and this leads to an expected either mini or solid, but got both. error rise.

Hi Max, thanks for this great library!

Is it ok if i fork it and adapt to use Phosphor instead of Heroicons? Also, can i later publish it on hex?

Thanks again!
Pedro