Comments (7)
This is currently broken, re-opening
from heroicons_elixir.
@greven width
and height
were just added to the globals in live view (but this obviously hasn't shipped yet
phoenixframework/phoenix_live_view@feeb5f8
I think there's still an issue with stroke-width but I havent' tested it enough...
from heroicons_elixir.
Closed in c712f72
from heroicons_elixir.
Hey, @mveytsman correct me if I'm wrong, but with the recent build this issue is already solved, so it can be closed?
Right now you can pass the stroke-width as assign to the Functional Component and it will affect the SVG.
from heroicons_elixir.
That's absolutely correct thanks @greven!
from heroicons_elixir.
@mveytsman So this is the same reason that if I add width and height the compiler keeps warning me about unknown attribute:
I thought the :global attr would allow valid HTML attributes but it still warns on width and height. 🤔
width, height and stroke-width should be common options when using icons.
Width and Height are important for SVG since before CSS applies it prevents the icons from being rendered in huge sizes so it reduces page elements moving around.
from heroicons_elixir.
@greven
width
andheight
were just added to the globals in live view (but this obviously hasn't shipped yet
phoenixframework/phoenix_live_view@feeb5f8I think there's still an issue with stroke-width but I havent' tested it enough...
Oh that's great, missed that, thanks. The amount of warnings I had because of that was a bit unsettling!
from heroicons_elixir.
Related Issues (11)
- Shamelessly copy for Phosphor? HOT 4
- Support for Heroicons v2 and mini
- Need a way to configure `view-box` and `fill` HOT 2
- Allow `outline` attribute HOT 1
- Dynamic icons HOT 1
- Missing icon HOT 2
- This package prevents using Phoenix Live View 0.19 HOT 6
- Add support for components HOT 1
- Mix script to update SVGs from Github HOT 7
- Warnings on latest in heex templates HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heroicons_elixir.