Coder Social home page Coder Social logo

Comments (7)

mveytsman avatar mveytsman commented on May 28, 2024 2

This is currently broken, re-opening

from heroicons_elixir.

mveytsman avatar mveytsman commented on May 28, 2024 1

@greven width and height were just added to the globals in live view (but this obviously hasn't shipped yet
phoenixframework/phoenix_live_view@feeb5f8

I think there's still an issue with stroke-width but I havent' tested it enough...

from heroicons_elixir.

mveytsman avatar mveytsman commented on May 28, 2024 1

Closed in c712f72

from heroicons_elixir.

greven avatar greven commented on May 28, 2024

Hey, @mveytsman correct me if I'm wrong, but with the recent build this issue is already solved, so it can be closed?
Right now you can pass the stroke-width as assign to the Functional Component and it will affect the SVG.

from heroicons_elixir.

mveytsman avatar mveytsman commented on May 28, 2024

That's absolutely correct thanks @greven!

from heroicons_elixir.

greven avatar greven commented on May 28, 2024

@mveytsman So this is the same reason that if I add width and height the compiler keeps warning me about unknown attribute:

image

I thought the :global attr would allow valid HTML attributes but it still warns on width and height. 🤔
width, height and stroke-width should be common options when using icons.
Width and Height are important for SVG since before CSS applies it prevents the icons from being rendered in huge sizes so it reduces page elements moving around.

from heroicons_elixir.

greven avatar greven commented on May 28, 2024

@greven width and height were just added to the globals in live view (but this obviously hasn't shipped yet
phoenixframework/phoenix_live_view@feeb5f8

I think there's still an issue with stroke-width but I havent' tested it enough...

Oh that's great, missed that, thanks. The amount of warnings I had because of that was a bit unsettling!

from heroicons_elixir.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.