Coder Social home page Coder Social logo

Add application menu on OS X about mpv HOT 5 CLOSED

mpv-player avatar mpv-player commented on May 14, 2024
Add application menu on OS X

from mpv.

Comments (5)

pigoz avatar pigoz commented on May 14, 2024

I'm working on this branch at the moment https://github.com/mpv-player/mpv/tree/cocoa_event_loop
which already fixes cmd+q. Long story short, menu management is FUBAR'd in master. If you want you can start to test it.

You could experience weird crashes and bug with playlists when using the command line though. Still fighting against that…

from mpv.

Nyx0uf avatar Nyx0uf commented on May 14, 2024

Just tried your branch, seems to work fine for now.

I Just added native OS X fullscreen (>= 10.7) to test, that way it will fix #34.

in vo_cocoa_config_window in cocoa_common.m :
[s->window setCollectionBehavior:NSWindowCollectionBehaviorFullScreenPrimary];

in init_cocoa_application in macosx_application.m :
[NSApp setPresentationOptions:NSFullScreenWindowMask];

Must test a little more because I did this really quickly!

from mpv.

pigoz avatar pigoz commented on May 14, 2024

@Nyx0uf you tried the rebased branch where I run the playloop in a secondary pthread, right?

I plan to remove 10.6 support when we finally have the cocoa event loop code merged as well as made vo_opengl and vo_corevideo threadsafe.

@wm4 is also working on running the swap buffers on a separate thread, maybe this will make it easier to adapt the code to use CVDisplayLink to drive the rendering.

from mpv.

Nyx0uf avatar Nyx0uf commented on May 14, 2024

@pigoz Just downloaded the zip from https://github.com/mpv-player/mpv/tree/cocoa_event_loop_rebase

TBH I don't know the code at all since it's the first time I downloaded it. If i'm not mistaken, the playloop is indeed running on a secondary thread. stuff in mplayer.c right ?

from mpv.

pigoz avatar pigoz commented on May 14, 2024

Yes, I wanted to make sure because the branch I linked in my first reply of this thread was using a different approach or scheduling each iteration of the the playloop using a Cocoa timer.

from mpv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.