Comments (5)
I'm working on this branch at the moment https://github.com/mpv-player/mpv/tree/cocoa_event_loop
which already fixes cmd+q
. Long story short, menu management is FUBAR'd in master. If you want you can start to test it.
You could experience weird crashes and bug with playlists when using the command line though. Still fighting against thatβ¦
from mpv.
Just tried your branch, seems to work fine for now.
I Just added native OS X fullscreen (>= 10.7) to test, that way it will fix #34.
in vo_cocoa_config_window in cocoa_common.m :
[s->window setCollectionBehavior:NSWindowCollectionBehaviorFullScreenPrimary];
in init_cocoa_application in macosx_application.m :
[NSApp setPresentationOptions:NSFullScreenWindowMask];
Must test a little more because I did this really quickly!
from mpv.
@Nyx0uf you tried the rebased branch where I run the playloop in a secondary pthread, right?
I plan to remove 10.6 support when we finally have the cocoa event loop code merged as well as made vo_opengl
and vo_corevideo
threadsafe.
@wm4 is also working on running the swap buffers on a separate thread, maybe this will make it easier to adapt the code to use CVDisplayLink to drive the rendering.
from mpv.
@pigoz Just downloaded the zip from https://github.com/mpv-player/mpv/tree/cocoa_event_loop_rebase
TBH I don't know the code at all since it's the first time I downloaded it. If i'm not mistaken, the playloop is indeed running on a secondary thread. stuff in mplayer.c right ?
from mpv.
Yes, I wanted to make sure because the branch I linked in my first reply of this thread was using a different approach or scheduling each iteration of the the playloop using a Cocoa timer.
from mpv.
Related Issues (20)
- limit lavfi video filters/glsl shaders to a specific srgb range/threshold
- Why no stats.lua video subtitles HOT 7
- Polar scalers behave weird with vo=gpu on Android HOT 11
- Segmentation fault on wayland with force-window=immediate and a YouTube url HOT 3
- Non-HDR Vulkan configuration selected when playing HDR HOT 5
- Error opening/initializing the selected video_out (--vo) device. HOT 3
- stats.lua: add options to disable the graphs on page 3 HOT 2
- Do I need an exception for mpv in DisplayCAL Profile Loader? HOT 1
- Using vulkan/winvk in a Windows HDR environment, skipping from SDR to HDR file or vice versa messes up the colours HOT 2
- dynamic video-crop
- Horrible cracking sound. HOT 7
- Switching to an external high bitrate audio track for the first time during playback will cause the video to freeze and lag continuously HOT 2
- crash when playing yt-dlp HOT 11
- v0.38.0 build failed for iOS when enabled audiounit HOT 1
- DOCS/client-api-changes.rst is difficult to read on GitHub HOT 2
- looped files (--loop) stutter between loops on vulkan HOT 11
- gpu-context should auto switch when switch hwdec HOT 6
- cycle show-in-taskbar to yes takes no effect after restart explorer.exe HOT 3
- Segfault in the `vo` thread with libmpv 0.38.0 HOT 5
- Cannot see mpv UI anymore HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mpv.