Segfault in the `vo` thread with libmpv 0.38.0 about mpv

[Dudemanguy]

Does this work?

diff --git a/video/out/opengl/context_drm_egl.c b/video/out/opengl/context_drm_egl.c
index ce86570efe..da28093562 100644
--- a/video/out/opengl/context_drm_egl.c
+++ b/video/out/opengl/context_drm_egl.c
@@ -491,7 +491,8 @@ static void drm_egl_uninit(struct ra_ctx *ctx)
         if (p->gbm.surface)
             gbm_surface_destroy(p->gbm.surface);
         eglTerminate(p->egl.display);
-        gbm_device_destroy(p->gbm.device);
+        if (p->gbm.device)
+            gbm_device_destroy(p->gbm.device);
 
         if (p->drm_params.render_fd != -1)
             close(p->drm_params.render_fd);

[Dudemanguy]

Another workaround would be explicitly setting vo to libmpv in RSS Guard but indeed we shouldn't be segfaulting during probing.

[guihkx]

Thanks for the heads up.

I may have to do that anyway, because with 0.38.0, playing any video causes a detached mpv window to pop up, instead of the old behavior where mpv would be embedded to RSS Guard's player (due to libmpv being the default back then, I suppose).

Additionally, I'm seeing another crash in a Qt-related thread after I play any video for the second time, which I'll have to investigate too (it's most likely unrelated to libmpv, though).

Thanks again.

[guihkx]

Here are most of the options RSS Guard passes to libmpv:

https://github.com/martinrotter/rssguard/blob/4.6.6/src/librssguard/gui/mediaplayer/libmpv/libmpvbackend.cpp#L53-L62

It's probably worth noting that my GPU driver doesn't really support GBM (as far as I understand), which seems to be related to the crash, given the backtrace information.

[guihkx]

Yup, that did it! Thank you very much for the quick fix. :D