looped files (--loop) stutter between loops on vulkan about mpv

[guidocella]

Probably fixed by #10748

[Dudemanguy]

I don't see any stutter on my end.

[Rabcor]

I don't see any stutter on my end.

🤔 interesting, are you on X11 or Wayland?

[Dudemanguy]

I tried both and I don't see anything. But maybe I'm just blind.

[Rabcor]

I tried both and I don't see anything. But maybe I'm just blind.

I just tried on X11 too, it stuttered there but I feel like it was less obvious than on Wayland.

it is just 1 frame tho I think, but to me it's blatantly obvious, did you try playing it side-by-side with the opengl renderer on one instance (or maybe even just your browser)? it might be easier to spot the difference if you have a perfectly smooth sample beside it for comparison.

[kasper93]

Are you able to test with #10748 changes?

[Rabcor]

Are you able to test with #10748 changes?

I wouldn't be averse to trying, but I really don't know how, I can barely manage to wrangle pkgbuilds into building specific versions from git for me if I have like 20 minutes to do it, never mind applying unapplied pull requests (e.g. patches).

But I have actually managed adding patches to aur packages before (and I suppose there's also the option of applying them and building from git but it's not like using makepkg is any harder really) so maybe if I had a prepared patch that's compatible with the current git master I could manage it... But that PR is from 2022, so I doubt it'll be very easy to get that.

Also, this file can serve as an alternate sample, it's bigger and higher framerate so it's a little easier to notice with this file.

Might be worth a try for you to use this file instead @Dudemanguy

https://giphy.com/gifs/daily-after-effects-hypnotic-oO95KMJ7LqZxdh66pY

With this file I noticed there actually is a stutter in the opengl renderer between loops as well, but if the vulkan renderer stutter is a normal stutter, the one in the opengl renderer is a microstutter (had to really be looking hard for it to see it; I think it's only visible at all due to the high framerate, I cannot see any stutter on the opengl renderer in the OP sample pic)

[guidocella]

I also can't reproduce the stutter on either video on either Vulkan or a 2011 laptop.

[kasper93]

if I had a prepared patch that's compatible with the current git master I could manage it... But that PR is from 2022, so I doubt it'll be very easy to get that.

According to github there are no conflicts, you can use this patch directly https://github.com/mpv-player/mpv/pull/10748.patch

[Dudemanguy]

Might be worth a try for you to use this file instead @Dudemanguy
https://giphy.com/gifs/daily-after-effects-hypnotic-oO95KMJ7LqZxdh66pY

I can see it here I think. opengl looks fine to me.

#10748 seems to completely break the duration of gifs at least but it does work.

[Rabcor]

if I had a prepared patch that's compatible with the current git master I could manage it... But that PR is from 2022, so I doubt it'll be very easy to get that.

According to github there are no conflicts, you can use this patch directly https://github.com/mpv-player/mpv/pull/10748.patch

Yep, getting same result as Dudemanguy. It fixes the stutter, but it breaks the duration of gifs, although i think that is pretty much how it works maybe (instead of starting the file over, it keeps playing the file in a continuous stream).

I also took a look to see if there was a performance difference, performance didn't change at all from using the patch.

Honestly if the duration thingy is fixed, that code might be good to use as default for --loop/--loop-file, using a --seamless-looping setting seems like nonsense.