This repository has been migrated to https://github.com/mozilla/fxa/tree/master/packages/123done
Please file issues and open pull requests against https://github.com/mozilla/fxa
DEPRECATED - Migrated to https://github.com/mozilla/fxa
This repository has been migrated to https://github.com/mozilla/fxa/tree/master/packages/123done
Please file issues and open pull requests against https://github.com/mozilla/fxa
Linkify the word "Persona" in the footer text.
To make it clear to people that see these demos that the dialog can be branded a bit, we should have an RP logo on this site.
Maybe this public domain one?
Saw this on the iPad. With a decent sized list, the screen flashes (redraws) with each item deleted.
The problem is more obvious on iOS for iPhone - the item content section of the web page flashes gray in color in between each successive deletion.
Looks like node version needs a boost on the awsbox. On git push
:
remote: npm http 200 https://registry.npmjs.org/client-sessions/-/client-sessions-0.3.1.tgz
remote:
remote: npm ERR! Unsupported
remote: npm ERR! Not compatible with your version of node/npm: [email protected]
remote: npm ERR! Required: {"node":">= 0.8.0"}
remote: npm ERR! Actual: {"npm":"1.1.21","node":"0.6.17"}
NOTE: for ephemeral deployments, the server should check that the server is up before rendering.
I hate this bug because we will have to make the server more complex to support this. alternately, we could deploy multiple versions of 123done rather than having a single retargetable version. hmmm.
in dialog. This is a core feature we want tested, so for the purposes of 123done, let's include links
After logging out the user's email address is still in the html (although the element is not visible).
It is in #loggedin > span.
Consider this a tracker bug...
From the dev-identity channel:
Still waiting for my confirmation email. How long does that take?
Because this is currently targeted at our development deployment of browserid, email sending is flakey. specifically, emails sent are often categorized as spam or blocked. In the next couple days, we'll retarget the work in progress demo to our beta/staging setup which is way more reliable.
The 'Fork me on Github' appears on top of the 'Sign in with Persona' link when visiting 123done.org from the B2G desktop client. This is preventing an automated UI test from attempting to sign in. Could we make it so this is not present on narrow displays? On a B2G device the content is not so large and therefore is not an issue, so it's possible this could/should be fixed elsewhere. Please advise.
Trying to run this, I had to change the dependency in package.json for client-sessions to be 0.0.8 instead of 0.0.6. before i could get it to work on os x mountain lion.
I don't really understand why, but figured I'd dump this in here.
It sends Cache-control headers with: public, max-age: 0 for static files, so there is no caching.
the site should scale gracefully to look and work great on tablet and mobile
because this newfangled API requires we do a little work before displaying the user's logged in state, we should probably give a smoother visual progression during load.
specifically, notice that as you load 123done.org there's a delay before signed-in state is displayed in the upper right.
What do you think skinny? loading spinners?
I don't actually have steps to reproduce but I loaded train0730.123done.org in win7/ie9 and got a js exception:
SCRIPT5007: Unable to get value of the property 'request': object is null or undefined
123done.js, line 14 character 3
https://github.com/mozilla/123done/blob/master/static/js/123done.js#L14
Seems include.js didn't load and so navigator.id is undefined and ... barf.
Suggestion combine the following files if possible in a sprite:
http://123done.org/img/persona-login.png
http://123done.org/img/sync_saved.png
http://123done.org/img/sync_alert.png
http://123done.org/img/sync_progress.png
To reduce the number of requests.
Right now you can get to 123done.org with https://123done.org/, but you will get a cert warning.
Ugly.
Can we fix this to redirect the https site to http?
Should update the code on this example site to not use loggedInEmail.
to reproduce, sign in, delete your cookies, and visit the site. you'll notice the sign in button flashes.
in onready if onlogin was called, we need to not display the button, but wait for assertion verification to complete.
As a test I ran the following files through: http://www.smushit.com/ysmush.it/
image - result size - savings - % savings
http://123done.org/img/persona-login.png 3.62 KB 944 bytes 20.29%
http://123done.org/img/sync_saved.png 395 bytes 2.71 KB 87.52%
http://123done.org/img/sync_alert.png 382 bytes 2.67 KB 87.75%
http://123done.org/img/sync_progress.png 416 bytes 2.68 KB 86.85%
http://123done.org/img/background.png 47.51 KB 4.25 KB 8.20%
As you can see that does help, although if issue #45 is applied the effect is probably gone.
QA will test that we display a proper "unsupported" message via this site. We should make the site render reasonably and spawn the dialog properly.
Although I am a big fan of the more creative font faces - like the current one in blue here - some people may find it a bit hard to read.
This does not really change the functionality of the site as a demo RP.
But if we want to make it more slick, we should think about giving the user a choice of supported (ie browser) font faces and colors.
Not too hard to do really.
Or, limit this to one sans, one serif, and the current creative with a choice of a few colors.
If we are going toward profile data per user and/or account, then font information could go there...
I noticed this with my Android 4.x phone, but I will assume this is true for all mobile devices.
The icon in the upper right corner of the page (and to the left of the Sign In) button is visible, so therefore discoverable.
But its purpose is not discoverable!
I am unable to "hover over" the icon for obvious reasons, so there appears to be no way to bring up the help text.
Looks like we need a way to activate that icon as a button when using a mobile device, so that clicking on it brings up an info/help text.
Just reporting this "for the record". I was checking an issue for 'requires cookies' screen in dialog and disabled cookies and loaded 123done.org. The sign in button stays as a spinner forever.
This is obviously not a huge deal, since if the sign in were shown, clicking it would just say "you must enable cookies".
better signed in/logout affordance
Real websites have real sessions. This demo should too.
Right now the following links open over the current 123done.org session:
Fork me on GitHub
Persona
identity folks
This can be confusing if the user is logged in (with or without a list) and hits one of the links.
The user must go back to the original page to continue with the list.
If he/she closes the the tab/page - which is common on a mobile device, then the original 123done page must be reloaded.
This works out OK for now since the user will still be logged in.
But, this can get more confusing if the user clicks a link then starts navigating new content, possibly opening extra pages:
TOS or the developer page on diresworb.org
Commits or Branchs on GitHub
It is entirely possible to move far enough off of 123done.org to confuse the user in terms of getting back.
We should instead, open the links as new tabs/pages that can be navigated/bookmarked/closed separately...
IE8/IE9 have a bug where cookies with the same name on a TLD and subdomain of that TLD collide. We should alter cookies based on hostname to handle this.
Yea, now I am looking at small feature additions to make 123done.org be really really useful (and lifelike).
It would be nice to have the ability to drag and drop the list items to change the order/priority
(without actually selecting them for removal - see #23)
It appears that new code was pushed to 123done.org that picked up all changes to https://github.com/mozilla/123done since last August.
The master branch of 123done breaks on IE8, but worked before Friday. I git-bisected and this commit 6ceb3dd where script loading is deferred is the problem (and consistent with the error that IE8 was showing, where it was confused about what '$' was). Was something different about the update on Friday.
I'll put in a pull request shortly to revert the above commit. You can see the code running with master minus that commit at http://j123done.personatest.org/.
Allow the user to upload a new photo and change their name.
I created a list with a given account.
Then by clicking on any list time, I get a red x.
(this is through mouse/keyboard on desktop or by tablet)
I can not figure out how to uncheck an item
as a result I am mistakenly removing items from the list that I still want.
And, it is not clear how, if at all, I can sync back the original list.
As above; right now, neither the "Add" nor "Sign in..." buttons appear to be links.
Hi @lloyd. Filing so stephend's team and others can track.
Anyways, while using the elastic IP (54.225.199.66) works, the dns resolution for (*?)123done at iwantmyname.net still returns the old IP (23.21.171.226). I'm assuming that needs updating to point at the elastic IP (either by A or CNAME).
Workaround for very short term, add to /etc/hosts:
54.225.199.66 123done.org beta.123done.org dev.123done.org
Part of this demo shows how you don't need a heavy handed sign up flow, how you can build a site that's instantly usable and upgrades when a users chooses to sign in.
This makes things a little complicated, as your todolist can be:
Currently there's placeholder text to the left of the signin box, we should represent this state with icons instead, maybe with tooltips upon hovering over the symbol.
Suggestion is to combine the following files in one file to reduce the number of requests:
http://123done.org/modernizr.min.js
http://123done.org/js/jquery.min.js
http://123done.org/js/123done.js
When you log in with persona, your tasks should be sync'd to the server and across devices.
dev.123done.org tries to load include.js from https://dev.diresworb.org/
This should be https://login.dev.anosrep.org instead.
I was assuming that the actual list would get cleared once I clicked on the LOGOUT link.
But this is not the case.
Since this is a "real world" RP to show the features of BrowserID, we should probably make this flow as real as possible, which means clearing the current list when the user logs out.
Alternatively we can wait for
But, it would be better to just wipe it between sign ins to better emulate action desired on a shared computer.
If it makes sense to do so.
We are deprecating myfavoritebeer and myfavoritebooze, the only RPs with links to TOS and PP.
@skinny97214 has already committed new css for the site, this issue is open as a tracker that can get closed down once she's happy with the initial look of the site - then we can open more specific issues for UX interactions or little changes in the future.
this is a supported browser, QA will be testing IE8.
I noticed this with Android 4.x (ICS) on a phone.
I have not tried against other mobile devices yet.
If I tap in the list/item field, I get a zoom in and a keyboard pop-up, as expected.
After I type in an item and click Go, the item is added but I can not see it because I am still zoomed in on the text field.
I have to zoom out by hand to see the full 123done.org page with my list, buttons, etc.
You don't even have to be logged in!
OK, so not that big a deal if you can simply leave the item field blank and click the Add button.
But, we should show something - a blank item is still an item.
Notice also the the "current line" is advanced as if there was something to show - that makes the result and the layout look odd, especially if you mix items with content and items with no content.
So either:
feedback that the account was sucessfully created
If the point is that you can use many different email accounts to login to the same account, then I would have expected the same list of issues in the 123done. Not so...
The list should be based on the userid and not the email used to login - right?
So this behaviour must be wrong...
The color error should be an easy fix (color is defined as "#;" with no value), but I can't find anywhere in the codebase where we're setting -moz-opacity explicitly. Not sure if that one is a separate bug, or just there for backwards compat.
[12:07:28.434] Error in parsing value for 'color'. Declaration dropped. @ http://www.123done.org/css/styles.css:73
[12:07:28.457] Unknown property '-moz-opacity'. Declaration dropped. @ http://www.123done.org/
So that we can walk through these during weekly bug triage.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.