moxystudio / eslint-config Goto Github PK
View Code? Open in Web Editor NEWMOXY eslint configuration to be used across several JavaScript projects
License: MIT License
MOXY eslint configuration to be used across several JavaScript projects
License: MIT License
Branch | Build failing ๐จ |
---|---|
Dependency | lint-staged |
Current Version | 4.1.3 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As lint-staged is โonlyโ a devDependency of this project it might not break production or downstream projects, but โonlyโ your build or test tools โ preventing new deploys or publishes.
I recommend you give this issue a high priority. Iโm sure you can resolve this ๐ช
The new version differs by 8 commits.
30fa594
feat: Print friendlier error if config is missing (#281)
0077644
chore: Cleanup package.json
(#250)
7abe23f
ci: Disable email notifications from Travis CI
c9d0849
docs: Use emojis in the Readme
e976a3c
docs: Add screenshot with the animated gif (#276)
92e586b
docs: Reformat code blocks
9b0282a
docs: Use diff formatting for code
33da9b3
ci: Whitelist build branches to avoid duplicate builds (#269)
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot ๐ด
Branch | Build failing ๐จ |
---|---|
Dependency | lint-staged |
Current Version | 4.0.3 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As lint-staged is โonlyโ a devDependency of this project it might not break production or downstream projects, but โonlyโ your build or test tools โ preventing new deploys or publishes.
I recommend you give this issue a high priority. Iโm sure you can resolve this ๐ช
<a name"4.0.4">
The new version differs by 2 commits.
48c8c6f
fix: Disable concurrent sub task execution by default (#229)
2eb10a4
chore: Disallow lockfiles (#224)
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot ๐ด
Do you think it is worth it? ๐ค
It appears a few changes were introduced between v6.2.1 and v6.3.1 which are breaking our tests. Check the following links for more information:
Something similar to https://github.com/moxystudio/stylelint-config/tree/master/test
ESM is already supported in Node.js since v12 [docs]. However, we're currently missing proper support and documentation as follows:
.mjs
files are not being considered for linting@satazor @threequartersjohn thoughts?
Branch | Build failing ๐จ |
---|---|
Dependency | eslint |
Current Version | 4.4.1 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As eslint is โonlyโ a devDependency of this project it might not break production or downstream projects, but โonlyโ your build or test tools โ preventing new deploys or publishes.
I recommend you give this issue a high priority. Iโm sure you can resolve this ๐ช
indent
(fixes #8594) (#9105) (Teddy Katz)new.target
expressions (#9116) (Teddy Katz)chalk
to 2.x release (#9115) (Stephen Edgar)fix: false
is used (#9098) (Teddy Katz)The new version differs by 12 commits.
ff8c4bb
4.5.0
480bbee
Build: changelog update for 4.5.0
decdd2c
Update: allow arbitrary nodes to be ignored in indent
(fixes #8594) (#9105)
79062f3
Update: fix indentation of multiline new.target
expressions (#9116)
d00e24f
Upgrade: chalk
to 2.x release (#9115)
6ef734a
Docs: add missing word in processor documentation (#9106)
a4f53ba
Fix: Include files with no messages in junit results (#9093) (#9094)
1d6a9c0
Chore: enable eslint-plugin/test-case-shorthand-strings (#9067)
f8add8f
Fix: don't autofix with linter.verifyAndFix when fix: false
is used (#9098)
77bcee4
Docs: update instructions for adding TSC members (#9086)
bd09cd5
Update: avoid requiring NaN spaces of indentation (fixes #9083) (#9085)
c93a853
Chore: Remove extra space in blogpost template (#9088)
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot ๐ด
Usually, in jest
, we have to mock packages or modules and have to use require
. Because of that, global-require
and prefer-import
should be disabled when using the jest addon.
Note that this must only be done when #48 is merged, so that it applies only to test files.
See https://github.com/dferrazm/eslint-plugin-prefer-import
It would be cool to use this to enforce the use of import
when the es6-modules
addon is activated.
This should be a warning
instead of an error
because there are still cases when we must use require
, e.g.: conditional loading.
3.8.0
to 3.9.0
.๐จ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
eslint-plugin-jsdoc is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 9 commits.
175ef6d
fix: correct auto release (fixes #97)
38e30f5
fix: correct README generation logic
69acabd
chore: automate git hooks
ca7e71f
chore: update dependencies
1778446
feat: add require-description (#91)
b132a6c
fix: revert @ private skip require checks (issue #78) (#89)
95df73e
feat: set line locations when reporting violations (#88)
767a788
fix: @ private skip require checks (#86)
e496523
fix: update dependencies (#81)
See the full diff
There is a collection of frequently asked questions. If those donโt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot ๐ด
When defining a global mock in __mocks__/<filename>.js
, using the jest global causes the linter to throw a jest is not defined
error.
We should modify the @moxy/eslint-config-jest
package to also override the ESlint config for the files in this directory.
Add the lowercase-name
rule to our eslint-config-jest
config. This rule makes it so test names have to be written in lowercase.
Now that node 8.9 has object spread, we can activate https://www.npmjs.com/package/eslint-plugin-prefer-object-spread.
Branch | Build failing ๐จ |
---|---|
Dependency | eslint-plugin-react |
Current Version | 7.1.0 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
eslint-plugin-react is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you itโs very likely also breaking them.
I recommend you give this issue a very high priority. Iโm sure you can resolve this ๐ช
no-unused-state
rule (#1103 @wbinnssmith)boolean-prop-naming
rule (#1264 @EvHaus)no-typos
rule (#1189 @jseminck, #1294 @haridusenadeera)sort-props
(#1273 @Overload119)getters
and setters
groups to sort-comp
(#100 @RDGthree)noStrings
option to no-literals
(#1202 @deecewan)always
/never
to jsx-boolean-value
(#1249 @ljharb)no-direct-mutation-state
to disallow this.state
mutation in constructor (#832 @burabure)jsx-no-target-blank
crash on empty rel
attribute (#1269 @dustinsoftware)sort-comp
component detection with ClassExpression
(#1076 @webOS101)no-unused-prop-types
detection with async class properties and methods (#1053 @benstepp)void-dom-elements-no-children
crash (#1226 @kokobeware)no-danger-with-children
to ignore line breaks (#1262)no-danger-with-children
crash with undefined (#1287)jsx-no-target-blank
crash (#1296 @jseminck)no-unused-props
to no longer ignore components with no used props (#1303 @DianaSuvorova)jsx-no-duplicate-props
crash (#969 @marcelmokos)no-literals
false positives (#1301 @davidyorr)no-find-dom-node
detection with named imports (#785 @Hypnosphi)no-unused-prop-types
detection with propTypes wrapped in a function (#1253 @dustinsoftware)no-unused-prop-types
detection with destructured use of properties (#816 @DianaSuvorova)no-unused-prop-types
detection with inline functions (#1309 @DianaSuvorova)no-unused-prop-types
skipShapeProps
option with Flow annotations (#1335 @DianaSuvorova)jsx-curly-spacing
schema incompatibility with ESLint 4.2.0 (#1290 @jseminck)The new version differs by 153 commits.
73abadb
Update CHANGELOG and bump version
1a622ea
Merge pull request #1343 from DianaSuvorova/unusedPropsFlow
f9c22ef
Merge pull request #1273 from Overload119/master
d66808b
Modernize to use let and const
e305279
Merge pull request #1344 from DianaSuvorova/docs
15d0f74
[no-unused-prop-types] test from #933
f446335
[no-unused-prop-types] known false positives doc
95acd93
Merge pull request #1341 from DianaSuvorova/flowShape
942e594
flow should respect skipShapeProps
f0487f2
Merge pull request #1338 from DianaSuvorova/graphql
b6bd2da
[no-unused-prop-types] graphql issue #1097
df84876
Update dependencies
a19eec6
Merge pull request #1294 from haridusenadeera/master
ed72341
Merge pull request #1329 from DianaSuvorova/docs
3195805
Merge pull request #1302 from davidyorr/master
There are 153 commits in total.
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot ๐ด
At the moment, https://github.com/yannickcr/eslint-plugin-react is issuing a warning because we are not specifying a react version. We should default it to the latest react and perhaps document how to override it.
When this package updates to version 6 of ESLint, we must update our override for .config.js
files to disallow that same override for nested .config.js
files.
This override can be found here.
The update is probably going to be something like:
'files': './*.config.js'
Basically it would be cool if we could comment out code without capitalized-comments
erroring out.
This would require us to ignore language statements, such as import, function, var, let, const
, etc
When React 17 is released and we adopt it in our projects, the following rules will no longer be necessary:
react/jsx-uses-react
react/react-in-jsx-scope
Source: https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html#eslint
Currently, I can't have a multiline template string that contains a paragraph that has more than 140chars
:
str += `
It's a bad practice having files being output with hashes during development. Your output folder will become filled with a lot of different files after a few rebuilds.
Additionally, this is know to cause ${chalk.bold('memory leaks')} with ${chalk.bold('webpack-dev-middleware\'s')} in-memory filesystem.
Either ${chalk.bold('avoid having hashes')} in development or disable in-memory filesystem through the \`memoryFs\` option.
If you feel this was a false positive, please ignore this warning.
`;
We should consider laxing this rules in a few cases, see https://eslint.org/docs/rules/max-len
Found about these when I was first reading the following blog post by Kent Dodds: https://kentcdodds.com/blog/common-mistakes-with-react-testing-library.
Repositories:
Disable the following rules in test files: react/jsx-no-bind
, react/prop-types
.
Thoughts?
Branch | Build failing ๐จ |
---|---|
Dependency | eslint |
Current Version | 4.7.1 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As eslint is โonlyโ a devDependency of this project it might not break production or downstream projects, but โonlyโ your build or test tools โ preventing new deploys or publishes.
I recommend you give this issue a high priority. Iโm sure you can resolve this ๐ช
The new version differs by 3 commits.
e164397
4.7.2
b7818ba
Build: changelog update for 4.7.2
4f87732
Fix: Revert setting node.parent early (fixes #9331) (#9336)
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot ๐ด
5.12.0
to 5.12.1
.๐จ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
eb5c401
Chore: use meta.messages in some rules (2/4) (refs #9870) (#10773) (่ๅฎ่ฐ็็ซ)aa56247
Fix: avoid loading core rules dynamically from FS in Linter (#11278) (Peter Metz)04450bb
Docs: clarify process for adding committers (#11272) (Kai Cataldo)3ffcf26
Docs: add @g-plane as committer (#11277) (Kai Cataldo)c403445
Fix: warn constant on RHS of || in no-constant-condition (fixes #11181) (#11253) (Merlin Mason)9194f45
Fix: Manage severity of 1 with TAP reporter (fixes #11110) (#11221) (Gabriel Cousin)000f495
Docs: fix example for sort-imports ignoreDeclarationSort (#11242) (Remco Haszing)7c0bf2c
Docs: Add npx
usage to Getting Started guide (#11249) (eyal0803)da9174e
Docs: fixes typo peerDepencies (#11252) (Christian Kรผhl)9c31625
Docs: Improve custom formatter docs (#11258) (Nicholas C. Zakas)The new version differs by 12 commits.
faf3c4e
5.12.1
1010c98
Build: changelog update for 5.12.1
eb5c401
Chore: use meta.messages in some rules (2/4) (refs #9870) (#10773)
aa56247
Fix: avoid loading core rules dynamically from FS in Linter (#11278)
04450bb
Docs: clarify process for adding committers (#11272)
3ffcf26
Docs: add @g-plane as committer (#11277)
c403445
Fix: warn constant on RHS of || in no-constant-condition (fixes #11181) (#11253)
9194f45
Fix: Manage severity of 1 with TAP reporter (fixes #11110) (#11221)
000f495
Docs: fix example for sort-imports ignoreDeclarationSort (#11242)
7c0bf2c
Docs: Add npx
usage to Getting Started guide (#11249)
da9174e
Docs: fixes typo peerDepencies (#11252)
9c31625
Docs: Improve custom formatter docs (#11258)
See the full diff
There is a collection of frequently asked questions. If those donโt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot ๐ด
no-multi-spaces
so that spaces on comments are consistent{
property: '__defineGetter__',
message: 'Please use Object.defineProperty instead.',
},
{
property: '__defineSetter__',
message: 'Please use Object.defineProperty instead.',
}
Both are breaking changes.
So that code blocks are validated.
Currently we have problems with no-invalid-this
on rwm. Basically weยดre having a linting error using this
on class properties, and we shouldn't.
eslint-plugin-babel re-implements problematic rules so they do not give false positives or negatives.
re-implementation of `no-invalid-this': https://github.com/babel/eslint-plugin-babel/pull/101/files
Currently, our indentation is 4 spaces, with a few exceptions:
'indent': [2, 4, {
'SwitchCase': 0,
'MemberExpression': 0,
}],
Re-evaluate these exceptions to see if we can remove them. As an example, because we are forcing MemberExpression
to 0
, the following code becomes unreadable:
const schema = {
headers: Joi.object({
'Content-Type': Joi
.string()
.pattern(/^application\/json\b/)
.required(),
}),
};
which would be much more readable like so:
const schema = {
headers: Joi.object({
'Content-Type': Joi
.string()
.pattern(/^application\/json\b/)
.required(),
}),
};
To circumvent the above issue, I would have to write it like so:
const schema = {
headers: Joi.object({
'Content-Type':
Joi
.string()
.pattern(/^application\/json\b/)
.required(),
}),
};
Interesting read: https://bytes.referralcandy.com/react-pure-components-now-with-more-weakmaps-f676ce8162e7#.5n6suhnqh
We should disallow arrow functions and perhaps activate class props declaration to easily bind functions to instances.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.