Jest addon should only work inside test/ about eslint-config

[satazor]

I've updated the patterns. I've removed .jsx support because it's a bad practice.

[satazor]

Actually this should be opt-in and not the default. Perhaps a different addon?

[acostalima]

@satazor @andregoncalvesdev @AfonsoVReis

According to ESLint's docs, the configuration can be modified under overrides key in .eslintrc.*. I have been experimenting a bit and below is the best I've achieved so far.

• I had to make the the top-level .eslintrc.json into .eslintrc.js instead:

module.exports = {
    'root': true,
    'extends': [
        './es5.js',
        './addons/node.js',
        './addons/jest.js',
    ],
    'rules': {
        'quote-props': [2, 'always'],
    },
    'overrides': [require('./addons/overrides/jest-test-dir')],
};

where jest-test-dir.js is:

'use strict';

module.exports = {
    'env': {
        'jest/globals': false,
    },
    'files': ['!test/**/*.js'],
    'rules': {
        'jest/no-disabled-tests': 0,
        'jest/no-focused-tests': 0,
        'jest/no-identical-title': 0,
        'jest/valid-expect': 0,
    },
};

The above works just fine, but has the following downsides/problems:

• The ESLint config must be .js instead of .json, if we wish to use the override as a module
• ESLint is not seeing changes made to jest-test-dir.js probably because we're using require, which is an inconvenient. I do not yet know how to fix this.

Feedback is welcome! 😄

[acostalima]

I think I got it. I was not aware that it was possible to extend a config with overrides:

// ./addons/overrides/jest-test-files.js`
'use strict';

module.exports = {
    'overrides': [{
        'env': {
            'jest/globals': false,
        },
        'files': ['!test/**/*.js'],
        'rules': {
            'jest/no-disabled-tests': 0,
            'jest/no-focused-tests': 0,
            'jest/no-identical-title': 0,
            'jest/valid-expect': 0,
        },
    }],
};

// ./.eslintrc.json
{
    "root": true,
    "extends": [
        "./es5.js",
        "./addons/node.js",
        "./addons/jest.js",
        "./addons/overrides/jest-test-dir.js"
    ],
    "rules": {
        "quote-props": [2, "always"]
    }
}

What do you think?

[satazor]

I think we do not need to create jest-test-dir but put all of this in the addons/jest.js.

Regarding the files it should be based on the default patterns of jest + add a test folder because of utilities I mentioned above.

[
   '!**/__tests__/**/*.js',
   '!**/?(*.)(spec|test).js',
   '!test/**/*.js',
]

[acostalima]

@satazor thanks! 👍
It is working already. I'm just finalizing the tests. I'll open a PR shortly.