Comments (6)
Obviously the failing Travis is due to a change of the underlying Travis installation, now providing a more recent ruby version than the one we manually install. I'm experimenting with a fix in #167.
from moveit_tutorials.
Having fixed Travis' ruby issue, there pop up dozens of broken link warnings: https://travis-ci.org/ros-planning/moveit_tutorials/builds/379740334. Please fix them.
from moveit_tutorials.
@rhaschke let's keep this dialog polite, feels very accusatory. We just put a lot of effort into greatly improving the tutorials and issues always occur when making lots of changes.
-
Re: PR numbers, the client (Franka) wanted some over site and review before we went "live" so we had to work in a separate Github organization. Plenty of companies/labs develop internally before releasing open source, I don't think you can ask that to change. I also don't think the broken PR links are that big a deal. Do you have any recommendations for avoiding this beyond just requesting we commit directly to ros-planning?
-
The broken Travis build is not related with our PickNikRobotics fork so i don't think should be conflated with "bad PR practice". Something broke on CI unrelated to us (ruby?) and yes, should be fixed by whomever feels motivated to do so.
-
The broken link warnings on Travis are because the ROS buildfarm has not built the new tutorials yet. We have already been looking into this issue - it appears ROS build only runs every ~2 weeks now but we're not sure why: http://build.ros.org/job/Kdoc__moveit_tutorials__ubuntu_xenial_amd64/lastBuild/
@mlautman is going to contact Tully -
Thanks for fixing the Ruby issues!
from moveit_tutorials.
- @davetcoleman I'm sorry if my English was offending. That wasn't my intention at all. I was just very confused, when I tried to figure out the reason for the Travis failure of
moveit_tutorials
and couldn't find corresponding pull requests to recent commits, although this was a guideline you strongly insisted in in the past. - In hindsight, I understand your motivation. However, instead of simply fast-forwarding this repo from your local one, a better approach might have been to explicitly merge. In this fashion, the commit history would have become more obvious.
- Indeed, the broken Travis was not related to your recent commits. However, having Travis not enabled for your local company repo, you maybe didn't noticed these issues over the past two months. At least, I didn't.
from moveit_tutorials.
instead of simply fast-forwarding this repo from your local one, a better approach might have been to explicitly merge.
I did a rebase-and-merge... I'm afraid I don't understand the difference enough but will try to research it more next time
from moveit_tutorials.
While a rebase tries to maintain a linear commit history, an explicit merge commit allows to recognize that a bunch of commits was merged in from somewhere else and it also indicates from where.
from moveit_tutorials.
Related Issues (20)
- When using the RRT algorithm in Moveit's ompl, I would like to know the collision detection times of the RRT algorithm. How can I implement it
- Invalid <param> tag HOT 15
- Exit Code -11 when running Rviz HOT 3
- Orientation changes while following waypoints in move_group python interface HOT 1
- Panda hand missing HOT 2
- Errors When adding EIT* to moveit HOT 25
- MoveIt Setup Assistant tutorial: Spawn service timed out error HOT 7
- A question in "planning_scene_tutorial.launch" HOT 2
- Errors when runing EIT* in planning HOT 1
- Keys expired in IKFast installation script. HOT 2
- Pick-Place-tutorial objects not visible in Gazebo HOT 4
- [NEED URGENT HELP] Not able to see any topics in context tab of the hand-eye calibration window HOT 2
- solved: changed name from hand to panda_hands HOT 1
- Github link for ROS noetic moveit toutorial not working HOT 2
- object with no geometry HOT 2
- github404 HOT 3
- The noetic branch of moveit_tutorials is missing. HOT 3
- the moveit tutorial is depracted? HOT 3
- trying to run demo_gazebo.launch under a namespace - Not working HOT 1
- Allowing "External comm." make rviz very slow HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moveit_tutorials.