Coder Social home page Coder Social logo

Comments (10)

janknobloch avatar janknobloch commented on June 11, 2024 2

@tms0 yes indeed im using the packageScan feature for now, I think when using addMigrationClasses you would need to search during build time for the given mongock annotations and use a buildstep in conjunction with unremovableOf to keep those files in the class path?

from mongock.

tms0 avatar tms0 commented on June 11, 2024 1

So, @tms0 , Correct me if I am wrong, but I understand you are planning to raise a PR addressing this, right?

Here you are : #664

from mongock.

dieppa avatar dieppa commented on June 11, 2024 1

Sorry I didn't let you know, but the PR was merged and released in version 5.4.1

from mongock.

dieppa avatar dieppa commented on June 11, 2024

Thanks @tms0 . I will review the PR once it's raised :)

from mongock.

janknobloch avatar janknobloch commented on June 11, 2024

@tms0 worked fine for me in regards to the classloader - no touches needed there - yet i had to manually force

<groupId>org.reflections</groupId>
<artifactId>reflections</artifactId>
<version>0.10.1</version>
</dependency>

as the quarkus bom forces a downgrade onto 0.9.x which broke my integration, yet im not running native - are you?
(this is actually why I haven't pushed It yet as I want to solve the issue without the need of pulling extra dependencies in to make the extension work)

from mongock.

dieppa avatar dieppa commented on June 11, 2024

Thanks @janknobloch, reflections library in some of its versions, produces this error. Not sure this is the fix for native image. If @tms0 can you confirm this is(or not) a fix, would be great. Otherwise, as said, I will wait for the PR

from mongock.

janknobloch avatar janknobloch commented on June 11, 2024

@dieppa - sadly haven't had the time to test native for now - hope to find some time on the weekend to report back on this if my extension works at least fine in native (with the given fix) + I need to build most likely some more build steps with "keep migration files / jandex etc"

@tms0 let me know if I can be of any help,

so far my extension runs fine with the upper mentioned quick fix, if anyone has a nicer suggestion on the reflections issue e.g. maybe to overwrite the quarkus bom somehow implicitly from the extension itself and if that's the proper way on dealing with this I'm happy for any input :-)

from mongock.

tms0 avatar tms0 commented on June 11, 2024

Both JVM and native modes are impacted by this issue.

@janknobloch I guess you use the package scan method ? It should explain why you don't have this issue. But package scan will not work in native mode, because org.reflections use org.jboss.vfs, which is not supported by GraalVM (if I understand correctly).

from mongock.

dieppa avatar dieppa commented on June 11, 2024

So, @tms0 , Correct me if I am wrong, but I understand you are planning to raise a PR addressing this, right?

from mongock.

dieppa avatar dieppa commented on June 11, 2024

@tms0 Approved pipeline run 😉

from mongock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.