Comments (10)
@tms0 yes indeed im using the packageScan feature for now, I think when using addMigrationClasses you would need to search during build time for the given mongock annotations and use a buildstep in conjunction with unremovableOf to keep those files in the class path?
from mongock.
So, @tms0 , Correct me if I am wrong, but I understand you are planning to raise a PR addressing this, right?
Here you are : #664
from mongock.
Sorry I didn't let you know, but the PR was merged and released in version 5.4.1
from mongock.
Thanks @tms0 . I will review the PR once it's raised :)
from mongock.
@tms0 worked fine for me in regards to the classloader - no touches needed there - yet i had to manually force
<groupId>org.reflections</groupId>
<artifactId>reflections</artifactId>
<version>0.10.1</version>
</dependency>
as the quarkus bom forces a downgrade onto 0.9.x which broke my integration, yet im not running native - are you?
(this is actually why I haven't pushed It yet as I want to solve the issue without the need of pulling extra dependencies in to make the extension work)
from mongock.
Thanks @janknobloch, reflections
library in some of its versions, produces this error. Not sure this is the fix for native image. If @tms0 can you confirm this is(or not) a fix, would be great. Otherwise, as said, I will wait for the PR
from mongock.
@dieppa - sadly haven't had the time to test native for now - hope to find some time on the weekend to report back on this if my extension works at least fine in native (with the given fix) + I need to build most likely some more build steps with "keep migration files / jandex etc"
@tms0 let me know if I can be of any help,
so far my extension runs fine with the upper mentioned quick fix, if anyone has a nicer suggestion on the reflections issue e.g. maybe to overwrite the quarkus bom somehow implicitly from the extension itself and if that's the proper way on dealing with this I'm happy for any input :-)
from mongock.
Both JVM and native modes are impacted by this issue.
@janknobloch I guess you use the package scan method ? It should explain why you don't have this issue. But package scan will not work in native mode, because org.reflections
use org.jboss.vfs
, which is not supported by GraalVM (if I understand correctly).
from mongock.
So, @tms0 , Correct me if I am wrong, but I understand you are planning to raise a PR addressing this, right?
from mongock.
@tms0 Approved pipeline run 😉
from mongock.
Related Issues (20)
- Unable to specify/override ReadConcern for transactional ChangeUnits HOT 1
- Mongock migration for MongoDB on CosmosDB fails HOT 2
- @ChangeSet executed before @ChangeUnit, ignoring order HOT 3
- MongoCK ChangeUnit doesn't auto wire other spring beans as dependency HOT 3
- Not supporting @ConditionalOnExpression or @ConditionalOnProperty HOT 2
- ChangeUnits containing Unnamed Variables (JEP443) are not found by Mongock. HOT 7
- Configuration error when using multiple transaction managers HOT 1
- BOM not published for version 5.3.5 HOT 2
- State that the order of a ChangeUnit is alphabetically (documentation/website issue) HOT 1
- Overwriting index of a collection fails HOT 6
- Error Creating bean getBuilder when deploying on docker HOT 5
- When using @ChangeUnit, if @Execution fails, and then @RollbackExecution fails, the original execution failure is not logged anywhere HOT 8
- Proxies are not created in GraalVM HOT 5
- Change units are re-executed unnecessarily HOT 6
- MongoCK 5.4.0 does not execute change sets by order HOT 1
- Exception com.mongodb.MongoCommandException: Command failed with error 26 (NamespaceNotFound) thrown sometimes. HOT 1
- OffsetDateTime support on DateUtils class HOT 7
- Feature request: Skipping particular changeunit
- Feature request: Provide more Metadata on particular change unit run
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mongock.