Coder Social home page Coder Social logo

Comments (7)

spalberg avatar spalberg commented on May 29, 2024 1

We recently upgraded to java 21 with preview features enabled too and could not make sense of some changeunits not being picked up by mongock until reading your issue. We confirmed this issue with our codebase!

from mongock.

florian-gehring avatar florian-gehring commented on May 29, 2024 1

@dieppa Hello, thank you for your comment. Yes, we've commited to not using "_" so the workaround is perfectly fine. This issue is less of a "PLEASE FIX" and more of a "Just FYI". It's a preview feature after all.

from mongock.

dieppa avatar dieppa commented on May 29, 2024 1

Thanks @florian-gehring for letting us know. We have a lot of new exciting things for the upcoming major release, hopefully we can add these nicr to have to it, so we are more up to date with modern java featured

from mongock.

dieppa avatar dieppa commented on May 29, 2024

@florian-gehring we'll take a look at this, but for the time being, as workaround, is it enough if you don't use "_"?

from mongock.

dieppa avatar dieppa commented on May 29, 2024

@spalberg this is not the same problem. Please see this issue.

from mongock.

spalberg avatar spalberg commented on May 29, 2024

@dieppa it's exactly the same issue as described here. When a changeunit uses the unnamed variable feature it is completely overlooked by mongock when picking up the changeunits via reflection. Not using the unnamed variable fixes that.

from mongock.

dieppa avatar dieppa commented on May 29, 2024

I am not familiar with that feature. We'll look at it as soon as possible.

In the meanwhile, yiu are welcome to raise a PR if you feel so.

from mongock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.