Change units are re-executed unnecessarily about mongock

[osantana85]

Hello @rgruber1 , thanks for raising the issue. We'll take a look to reproduce it and let you know.

However, even though the unique key is composed of the ChangeUnit id + author, the best practice (and the recommended one) is to have unique ChangeUnit ids.

In a future major version the way to go will be to have unique ids (the author will be optional and won't be part of the key).

As a workaround, can you refactor your ChangeUnits to prevent duplicated ids?

[dieppa]

@rgruber1 can you update us on this, so we can close it and move it to an internal ticket to address it?

[rgruber1]

As a workaround, we simplified the annotation definitions and only specify the mandatory attributes (id + order), so that mongock uses the id and the default author for the uniqueness check across change units (this effectively makes change units unique based on id only as you know).

[dieppa]

Thanks, we'll fix this in the next major release. This workaround should be fine for the time being.

[rgruber1]

Mongock change unit documentation could possibly mention this defect in https://docs.mongock.io/v5/migration/index.html

[dieppa]

you are totally right! Will do!