Compile fails with error: ‘gflags’ has not been declared when compiling from source about eternalterminal

[MisterTea]

Hmm, how about this: namespace google {} namespace gflags {} using namespace google; using namespace gflags;

…

On Thu, Mar 9, 2017, 1:57 PM Tuk Bredsdorff ***@***.***> wrote: No, I get TerminalClient.cpp:21:17: error: ‘gflags’ is not a namespace-name using namespace gflags; ^ 😟 . — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASuv_PHVA1dLd6LewkOL4LEcaF9wtCeks5rkHXlgaJpZM4MYZoX> .

[MisterTea]

Hey, I think you are missing the gflags dependency.

Here's a list of the deps you need:

sudo apt-get install libboost-dev, libsodium-dev, libncurses5-dev, libprotobuf-dev, protobuf-compiler, cmake, libgoogle-glog-dev, libgflags-dev

You can find this out from launchpad: https://launchpadlibrarian.net/307528352/et_2.0.1-1ubuntu1.dsc

Let me know if installing the gflags dev package fixes your issue.

[tiktuk]

True, I didn't have that installed. I get the same error though.

But I solved it by changing gflags to google as mentioned in this comment. Apparently it's been renamed in version 2.1 of gflags and I guess my version of Debian install 2.0 though it says 2.0-2.1, confusingly:

# apt-cache policy libgflags-dev
libgflags-dev:
  Installed: 2.0-2.1
  Candidate: 2.0-2.1
  Version table:
 *** 2.0-2.1 0
        500 http://mirror.one.com/debian/ jessie/main i386 Packages
        100 /var/lib/dpkg/status

It's used here and here.

I don't know if it's possible to make it compatible with both versions.

[MisterTea]

Oh interesting. We should be able to support both this way: using namespace google; using namespace gflags; And then not putting the namespace. Can you try this and verify that it compiles?

…

On Thu, Mar 9, 2017 at 10:41 AM Tuk Bredsdorff ***@***.***> wrote: True, I didn't have that installed. I get the same error though. But I solved it by changing glags to google as mentioned in this comment <BVLC/caffe#2597 (comment)>. Apparently it's been renamed in version 2.1 of gflags and I guess my version of Debian install 2.0 though it says 2.0-2.1, confusingly: # apt-cache policy libgflags-dev libgflags-dev: Installed: 2.0-2.1 Candidate: 2.0-2.1 Version table: *** 2.0-2.1 0 500 http://mirror.one.com/debian/ jessie/main i386 Packages 100 /var/lib/dpkg/status It's used here <https://github.com/MisterTea/EternalTCP/blob/master/terminal/TerminalClient.cpp#L36> and here <https://github.com/MisterTea/EternalTCP/blob/master/terminal/TerminalServer.cpp#L205> . I don't know if it's possible to make it compatible with both versions. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASuv6bGx6BgEzMW6CPDGwS2GO-nILFYks5rkEfQgaJpZM4MYZoX> .

[tiktuk]

No, I get

TerminalClient.cpp:21:17: error: ‘gflags’ is not a namespace-name
 using namespace gflags;
                 ^

😟 .

[tiktuk]

Yes, that worked!

Thanks ☺️ !

[MisterTea]

Can you file a pull request to fix this for everyone?

…

On Sat, Mar 11, 2017, 10:38 AM Tuk Bredsdorff ***@***.***> wrote: Yes, that worked! Thanks ☺️ ! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASuv7wztvicH_PZAafd4sRzYPvuuW2pks5rkupBgaJpZM4MYZoX> .

[tiktuk]

Sure: #16.

[oqsh]

Hmm, how about this: namespace google {} namespace gflags {} using namespace google; using namespace gflags;
…
On Thu, Mar 9, 2017, 1:57 PM Tuk Bredsdorff @.***> wrote: No, I get TerminalClient.cpp:21:17: error: ‘gflags’ is not a namespace-name using namespace gflags; ^ 😟 . — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AASuv_PHVA1dLd6LewkOL4LEcaF9wtCeks5rkHXlgaJpZM4MYZoX .

Thanks! I just have the same problem, and your solution worked. It's a namspace problem.
I think it is because when I install the gflags, I use the command "cmake -DCMAKE_INSTALL_PREFIX=/usr/local -DBUILD_SHARED_LIBS=ON -DGFLAGS_NAMESPACE=google ../", and you can see the sentence "NAMESPACE=google". So when I use the function xxx in glags, I should use the namespace "google", such as the funtion "gflags::ParseCommandLineFlags(&argc, &argv, true);" I should write as "google::ParseCommandLineFlags(&argc, &argv, true);"