Why does 6.2.8 install header and cmake files? about eternalterminal

[MisterTea]

Should be fixed in master

[MisterTea]

The httplib dependency is adding those files:

https://github.com/MisterTea/EternalTerminal/blob/master/CMakeLists.txt#L122

Maybe there's some option to not install those?

It's harmless, so I'm not going to investigate, but happy to accept a PR if there's a fix.

[jubalh]

The httplib dependency is adding those files

But those are devel files for EternalTerminal, why should they be installed for the end user?

It's harmless, so I'm not going to investigate, but happy to accept a PR if there's a fix.

It would be good to fix this upstream. I removed the files in our package.

[MisterTea]

It looks like we can fix by setting HTTPLIB_INSTALL=OFF in our Cmakelists.txt

[MisterTea]

Hmm. I can't seem to make 6.2.8 install those files. @jubalh what parameters are you passing cmake?

[jubalh]

Full build recipe.
Full build log.

Call to cmake:

/usr/bin/cmake /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.8/. '-GUnix Makefiles' -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_INSTALL_BINDIR:PATH=bin -DCMAKE_INSTALL_SBINDIR:PATH=sbin -DCMAKE_INSTALL_LIBEXECDIR:PATH=libexec -DCMAKE_INSTALL_SYSCONFDIR:PATH=etc -DCMAKE_INSTALL_SHAREDSTATEDIR:PATH=/var/lib -DCMAKE_INSTALL_LOCALSTATEDIR:PATH=var -DCMAKE_INSTALL_RUNSTATEDIR:PATH=run -DCMAKE_INSTALL_LIBDIR:PATH=lib64 -DCMAKE_INSTALL_INCLUDEDIR:PATH=include -DCMAKE_INSTALL_DATAROOTDIR:PATH=share -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DCMAKE_BUILD_TYPE=RelWithDebInfo '-DCMAKE_C_FLAGS=-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g' '-DCMAKE_CXX_FLAGS=-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -std=c++17' '-DCMAKE_Fortran_FLAGS=-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g' '-DCMAKE_EXE_LINKER_FLAGS=-flto=auto -Wl,--as-needed -Wl,-z,now' '-DCMAKE_MODULE_LINKER_FLAGS=-flto=auto -Wl,--as-needed' '-DCMAKE_SHARED_LINKER_FLAGS=-flto=auto -Wl,--as-needed -Wl,-z,now' -DLIB_SUFFIX=64 -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF -DCMAKE_COLOR_MAKEFILE:BOOL=OFF -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_MODULES_INSTALL_DIR=/usr/lib64/cmake/EternalTerminal -DDISABLE_VCPKG:BOOL=ON -DProtobuf_LITE_LIBRARY=/usr/lib64/libprotobuf-lite.so

During make install I see:

[  181s] /usr/bin/cmake -P cmake_install.cmake
[  181s] -- Install configuration: "RelWithDebInfo"
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/bin/etserver
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/bin/etterminal
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/bin/et
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/bin/htm
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/bin/htmd
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/include/httplib.h
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/lib64/cmake/httplib/httplibConfig.cmake
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/lib64/cmake/httplib/httplibConfigVersion.cmake
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/lib64/cmake/httplib/FindBrotli.cmake
[  181s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/EternalTerminal-6.2.8-52.2.x86_64/usr/lib64/cmake/httplib/httplibTargets.cmake