Coder Social home page Coder Social logo

Comments (3)

MisterTea avatar MisterTea commented on July 18, 2024

Interesting, thanks for the clear issue description. I don't believe ip addresses are supported at all. I think what's happening is the "10.96.0.1" is being passed to stoi and turned into "10", and "50005:127.1.1.1:8443" is being turned into "50005". Stoi is very tolerant of malformed numbers.

Would you be willing to write this PR? There's a few parts:

  1. Change the parsing code here to accept ip addresses: https://github.com/MisterTea/EternalTerminal/blob/master/src/base/TunnelUtils.cpp#L4
  2. Remove this check
  3. If the name exists, use it here instead of hardcoding localhost:

from eternalterminal.

tsunamaru avatar tsunamaru commented on July 18, 2024

@MisterTea would love to help with PR, but sadly I don't know C++
Hope somebody can pick this up.

Do you accept bounties, by the way? If yes, I would happily sponsor implementation of this feature.

from eternalterminal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.