Translations not working / not usefull for multilang sites about mindshape_cookie_consent

[22markets]

Hello Daniel, I have tried to use the translation fields from the extension in the backend and the fields for the cookie groups and cookies in the located version. But the translated contents are not visible in version 2.0 and above. Only the values from the default language. Also the strings for necessary cookies and the deny buttons have no fields in the backend to be translated Mit freundlichen Grüßen Sebastian Lorenz Langheimer Str. 60 --||-- D-96264 Altenkunstadt fon: [phone] mobil: [phone] email: ***@***.***

…

Am 17.01.2022 um 19:40 schrieb Daniel Dorndorf ***@***.***>: Hi @22markets <https://github.com/22markets>, have you used the latest way for custom translations <https://docs.typo3.org/m/typo3/reference-coreapi/10.4/en-us/ApiOverview/Internationalization/ManagingTranslations.html#custom-translations> as refered in #20 <#20>!? As far as I know translations in TypoScript are not that favoured anymore. (correct me if I'm wrong) Greetings Daniel — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADMP5HLR42VTG6YA5IZULVTUWRPB5ANCNFSM5MD7ONNA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.

[SimonWpt]

I have the same problems as @22markets

First language is german, second is english. I fill in BE the fields with german and english texts. Most text on english site are german.

[featdd]

Hi @22markets,

have you used the latest way for custom translations as refered in #20!?

As far as I know translations in TypoScript are not that favoured anymore. (correct me if I'm wrong)

Greetings
Daniel

[featdd]

Hi @22markets,

could you update the extension (2.1) and your TYPO3 instance to its latest versions and verify this still doesn't work?

I will try consider adding a custom label field for the deny button for the next update.

How did you add your custom translations, as explained in the documentation? Did you create a proper XLIFF file?
Maybe have another look or please submit a bit more details of your implentation.

Greetings
Daniel

[SimonWpt]

Second problem: I can't edit the necassary cookie.

Working with ddev, TYPO3 10.4.23 and mindshape_cookie_consent 2.1.2.

[stephangrass]

Same problems here ...

[featdd]

Hi @22markets, @SimonWpt, @stephangrass,

I managed to reproduce this, I don't know why the repository doesn't handle the language context properly, maybe it depends on an early instantiation stage in the hook or something.

I just wrote a patch and would be happy if some of you guys can confirm that it's also working for you.

See: 49b8e4a

Greetings
Daniel

[stephangrass]

Hi @featdd,

thanks, it really looks like it works in the frontend.

But in the backend the error
Call to undefined method Doctrine\DBAL\Driver\Mysqli\MysqliStatement::fetchAllAssociative()
appears if you want to edit the consent configuration.

My TYPO3 10.4.24 installation is not based on composer ...

[featdd]

Hi @featdd,

thanks, it really looks like it works in the frontend.

But in the backend the error
Call to undefined method Doctrine\DBAL\Driver\Mysqli\MysqliStatement::fetchAllAssociative()
appears if you want to edit the consent configuration.

My TYPO3 10.4.24 installation is not based on composer ...

Have you installed the latest TYPO3 v10?

[stephangrass]

Have you installed the latest TYPO3 v10?

Yes: TYPO3 10.4.24

[featdd]

HI @stephangrass,

the issue is caused by the none composer installation, I have a composer installation wich provides a forward compatibility package with the methods used in v11.

I replaced all methods with the proper v10 variants, see: c8409cf

May you have another try?
I will try to release an Update next week.

Greetings
Daniel

[stephangrass]

Hi @featdd

thanks a lot!
Unfortunately, I have some installations that cannot be switched to Composer for various reasons. And I guess I'm not the only one with this...

But there is still one more place where fetchAllAssociative() is used:

Call to undefined method Doctrine\DBAL\Driver\Mysqli\MysqliStatement::fetchAllAssociative() in /Users/stephangrass/Documents/_Webs_/kirchhoff-mobility.com/typo3/www/typo3conf/ext/mindshape_cookie_consent/Classes/UserFunc/ConfigurationTcaUserFunc.php line 61

Greetings
Stephan

[featdd]

@stephangrass have you checked out the correct commit?

I amended the changes to the bugfix commit, see this commit: 85c38de

[stephangrass]

Argh, ok. Thanks. I will try it later.

nice weekend
Stephan

[stephangrass]

Moin Daniel,
thanks a lot, it looks really good now.

Stephan

[featdd]

@stephangrass @SimonWpt @22markets Update 2.1.3 with this fix is available in TER