Coder Social home page Coder Social logo

Comments (8)

featdd avatar featdd commented on July 23, 2024 1

Hi @jungedigitale, @LimeUwe, @birgitberlin,

I just pushed a commit that should fix the problem: 2bd7bfd
Can you guys confirm me this also works for you?

I don't know if this counts as a breaking change but this will break some peoples code, will have to check some other extensions later too...
Luckily in this case the parameter was unused anyway and just there for completion, so I could just remove it.

I will try to push an update to TER next week.

Greetings
Daniel

from mindshape_cookie_consent.

featdd avatar featdd commented on July 23, 2024

Hi @jungedigitale,

I have to test this, haven't done the newest update yet.
Have you done some changes to the TCA of this extension? Otherwise this might be a breaking change in the core or something.

Greetings
Daniel

from mindshape_cookie_consent.

jungedigitale avatar jungedigitale commented on July 23, 2024

Hi Daniel,
thanks for the fast reply! No we haven't done any changes to the TCA of this extension, it is a standard implementation.

thanks & best regards
-Markus

from mindshape_cookie_consent.

LimeUwe avatar LimeUwe commented on July 23, 2024

I have the same problem here.
Looking at the paramters, there is a unued parameter tcaSelectItems which is not of the correct type:

public function sitesItemsProcFunc(array $parameters, TcaSelectItems $tcaSelectItems): void

It's not used anywhere in the method, so I think it can be removed? List view works then.

from mindshape_cookie_consent.

birgitberlin avatar birgitberlin commented on July 23, 2024

I can confirm this problem.

from mindshape_cookie_consent.

jungedigitale avatar jungedigitale commented on July 23, 2024

Hi @featdd,
Thank you, the fix seems to have eliminated the issue!
best -Markus

from mindshape_cookie_consent.

featdd avatar featdd commented on July 23, 2024

Hi @jungedigitale, @LimeUwe, @birgitberlin,

I just pushed an update to TER containing this bugfix.

Greetings and merry christmas
Daniel

from mindshape_cookie_consent.

jungedigitale avatar jungedigitale commented on July 23, 2024

Thank you very much for your work & happy new year!

from mindshape_cookie_consent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.