Coder Social home page Coder Social logo

Error: Return value of Mindshape\MindshapeCookieConsent\Utility\CookieUtility::getCookieValue() must be of the type array or null, bool returned about mindshape_cookie_consent HOT 6 CLOSED

klodeckl avatar klodeckl commented on June 24, 2024
Error: Return value of Mindshape\MindshapeCookieConsent\Utility\CookieUtility::getCookieValue() must be of the type array or null, bool returned

from mindshape_cookie_consent.

Comments (6)

featdd avatar featdd commented on June 24, 2024

Hi @klodeckl,

the only explenation I currently have in mind that some users have a mess in their cookie value and the json_decode just returns a boolean.

Anyway, I will try to adjust this to prevent this exception.

Greetings
Daniel

from mindshape_cookie_consent.

klodeckl avatar klodeckl commented on June 24, 2024

Thank you! :)
But how could get mess in the cookie value?

from mindshape_cookie_consent.

klodeckl avatar klodeckl commented on June 24, 2024

I changed the function now to the following:

if (false === self::hasCookie($name) || is_bool(json_decode($_COOKIE[$name], true)) === true) {
return null;
}

return json_decode($_COOKIE[$name], true);

I will check if the error won’t occur anymore now. Maybe instead of is_bool === true it would be better to check for is_array || is_null === false.

from mindshape_cookie_consent.

featdd avatar featdd commented on June 24, 2024

Hi @klodeckl,

I solved this here: 22bfbf2

This shouldn't happen except a user/script/adblocker tries to manipulate the consent cookie somehow, but this should make it safe now. (Broken cookies will also be ignored by the JavaScript prompting the modal and save it properly)

Greetings
Daniel

from mindshape_cookie_consent.

featdd avatar featdd commented on June 24, 2024

Hi @klodeckl,

an update with this fix is now released in TER.

Greetings
Daniel

from mindshape_cookie_consent.

klodeckl avatar klodeckl commented on June 24, 2024

Thank you!

from mindshape_cookie_consent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.