Coder Social home page Coder Social logo

Comments (4)

SirCxyrtyx avatar SirCxyrtyx commented on July 21, 2024 1

Thanks for the detailed report! I've fixed the first issue; BioSeqAct_BioToggleCinematicMode should recompile identically now.
The other two problems are quite vexing. I can't figure out why the two properties in SFXGameModeConversation should have the component flag, as my understanding is that for ObjectProperties it should only be set when the class it holds inherits from Component or BioBaseComponent. Clearly I'm missing something. May take me some time to figure out.

from legendaryexplorer.

KR33PYK1NG avatar KR33PYK1NG commented on July 21, 2024

Comparison of oBehavior field:
1_2RECOMP
1_2VAN
Comparison of ConversationCam field:
1_1RECOMP
1_1VAN

from legendaryexplorer.

KR33PYK1NG avatar KR33PYK1NG commented on July 21, 2024
  1. BioPlayerInput (LE3)
    Recompiling the class causes the game to crash if you try to zoom in (right click) while in any turret section (Rannoch Reaper chase, Palaven base defence, Earth, Thessia...)
    Comparison vanilla<->recompiled:
    changed

However, if I use "Restore export data" specifically on PostProcessInput function and restore this export to vanilla state, the turret crash disappears.

More experiments:

  1. Vanilla else if block on line 70:
    __1
  2. I replaced the block's contents with just !BP.IsInCover call, and it still crashes:
    __2
  3. If I remove the negation, it doesn't crash (!):
    __3

from legendaryexplorer.

KR33PYK1NG avatar KR33PYK1NG commented on July 21, 2024

Can confirm that issue 1 is fixed.
Issue 2: for those two properties in SFXGameModeConversation, if I manually take flags from vanilla and slap them onto recompiled with hex editor, the issue 2 is also fixed (couldn't we just copy vanilla flags for all vanilla properties that are recompiled? I guess there's caveats if it hasn't already been done, but just pitching an idea).
Issue 3: it seems different, since the only changed exports upon recompilation are functions, no properties there. I guess another bug also exists in function compilation?

UPD: SFXGameModeBase (LE3) also breaks upon recompilation because some of its functions changed exports, not sure which exactly. The game just won't load into the menu.

from legendaryexplorer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.