mcdamo / tab-image-saver Goto Github PK

Dont know what do, what should i do? When i press the button and set up the program nothing happens.

is there a way to make this work on android firefox browser?
it will really help me.

Hi there.

I'm setup to save from tabs to the right, with a low minimum size count, everything else is pretty much stock.

It just won't download the files, no matter what I do, what am I doing wrong? Just installed, FF 67.0.4.

Have tried with both JPGs and GIFs.

Here's the site I'm trying:
https://kittens.tistory.com/171

Here's two of the image tab URLs that I'm attempting to download from.

1. https://t1.daumcdn.net/cfile/tistory/99EBBC405B3047BB11?original
2. https://t1.daumcdn.net/cfile/tistory/999FE1405B3047BD16?original

If you wish to test GIFs, then there's ... hm ... here's some TWICE GIFs:
https://yesesyo.tistory.com/1352?category=677583

I see that these image types may mirror something that some of the Firefox reviews were saying last year about parameter filenames being problematic, but it looks like that was fixed.

Could it be something to do with the language of the original filenames? (Korean)

I've just tested it on roman characters (~English) as opposed to the Hangul ones linked above, and it does work. However I can't then use this to get to HQ imagery. 🙁

FWIW - The built in rules are renaming GIFs as JPGs for some reason, I'm just trying to learn your mini-code for that to work around it. Bit frustrating. But easily dealt with. :-)

Very Best
M_M_M

FWIW - I'm very happy about what you've made here, not posting this as an annoyance, just hoping to help shore up any issues. :-)

... [sigh] Sorry, I just realized that I opened this bug on the wrong extension. Please disregard.

Just a suggestion (sorry, still working out how to use github after 10 years) ... basically what it says in the title/subject line.

The ability to define the filename determination to a bit more order. Meaning that let's say that I'd like to number my images perhaps not starting at the number 1. Or maybe increase in twos (for whatever weird reason), I dunno.

So, if I already know that I have 58 car pictures already in the "Cars" folder, know that I'm already using a 3 number system ###, and want to start at 59, with single digit increments, then I would put:
Cars/car_<index-in|000,59,1><ext|xExt|xMimeExt|.jpg>
or
Cars/car_<index-in|###,59,1><ext|xExt|xMimeExt|.jpg>

If you wanted to be adventurous, you might be able to also (once the logic has been defined) set a decreasing standard, too:
Cars/car_<index-de|000,57,1><ext|xExt|xMimeExt|.jpg>
or
Cars/car_<index-de|###,57,1><ext|xExt|xMimeExt|.jpg>

Of course, not suggesting this with any kind of entitlement, just thought about it, and it'd be quite cool. :-) Oh, and the examples above, are purely just me thinking aloud on implementation of the idea.

Still a good extension! Wishing you luck whatever happens. :-)

the link looks like this https://urlurlurlurl.com/attachment.php?aid=123456. If I start downloading with any option in Tab Image Saver, it would download like usual but it saves as attachment (1).php. when I rename it to let's say picture1.jpg, the images shows and everything else is fine, like the image size. I think it's because of the link where normally it says https://urlurlurlurl.com/picture1.jpg but in this case it was the link above and it confuses the add-on on naming stuff. I could rename it my self but I'd like to keep the name the way it should be.

A feature I missed in the upgrade to 57 was from an extension similar to yours. It had three download options: To the Download folder, to the previously saved directory, and custom. Bascially, I'd like to open and save one pic, and then bulk save the rest to the same folder.

Hello, I love this addon, but I would like to have the possibility to save images anywhere on my PC, by giving a drive and folder name (c:\test\images) or a UNC-path (\myserver\test\images) instead of saving to the download folder. Any way this can be done? Many thanks!

New to this site you may want to add a side code where you can ctrl+mousedrag (from example) and open all images in the correct size.

Btw I found in Firefox theres an setting "jump to the most recent tab you openened". Very useful combined with this, is there anyway to make a hotkey to go back?

I'm one of those who used to use the old "Save Images" addon which I'm sure you've heard about. My version 28 of firefox finally has stopped working on too many sites to justify continuing to use it so I've been forced to update and look for a replacement and this seems to be a very good alternative. There's just one thing that the old "Save Images" could do that I can't figure out how to replicate. There used to be an option to "Append Tab title to Save Folder." Basically the name of the Subfolder that an image was saved to would be automatically set to the Tab title the image came from. This was convenient since the albums I was downloading from would have the same tab title for all images in the album and I could open multiple albums and when I saved the images the images would be automatically sorted into proper folders for each album without me needing to rename each and every one. This also meant that if images from different albums had the same name (001, 002 ect) this wouldn't cause any conflicts.

When I found your addon I saw the paths options and one of the paths options is for tabTitle but when I tried to use it in the "path" box this only seemed to change the file name, not the sub folder name. Is there a way to replicate this behavior with the tools as is and if not is it something that could be added? Regardless thanks for your work.

When pictures with the suffix :large are opened in separate tabs, the extension doesn't recognize them as pictures. This URL format is used for images uploaded to Twitter and shows them in their original dimensions. Removing the suffix throws out a compressed image with a max. size of 1200px

For example: with normal firefox save
yande.re 468966 animal_ears areola ass benghuai_xueyuan bunny_ears erect_nipples higandgk naked_ribbon yae_sakura_(benghuai_xueyuan)
With add-on:
yande.re%20468966%20animal_ears%20areola%20ass%20benghuai_xueyuan%20bunny_ears%20erect_nipples%20higandgk%20naked_ribbon%20yae_sakura_%28benghuai_xueyuan%29

This only happen in 2.2.1

...or, better yet, add an option to specify what extensions to cover. That would be awesome!

Thank you!

have 12 tabs and set shorcut to dl from right tabs but it only dl's pics from 10 tabs when pressing shorcut,

Tab Image Saver was working well with Firefox 57, but after the FF58 update, TIS now is forced to run super-slow as it pops-up the Windows File-Save dialog for each image file that it tries to save.

I switched from Firefox to Waterfox back when Mozilla dropped support for Legacy add-on's. I've been using the "Save Images" add-on for years and "Tab Image Saver" is the closest I've found to replace it. However, one feature I didn't see was the ability to set the output filename and use a 3-digit suffix. This is useful in cases where you have several tabs with images, and you want them to be saved from left to right, in the same order as the tabs.

Example: Tab1=image001, Tab2=image002, Tab3=image003, etc.

Perhaps this is something you'll consider in a future release?

I'm running Firefox 78.0.2 (64-bit) on Lubuntu 18.04 on Private Browsing Mode.

I updated to version 3.0.0, I got a "tabs do not have permission" error when I tried to download images from Wikimedia Commons (https://commons.wikimedia.org/).

These are my customized settings:
Default action: Right of current tab
Browser action: Default action
Image filter: Largest image
Duplicate filename action: Rename
After downloading: Close tabs, Show notification and Clear download history

I tried to save images from 7 tabs, but I was unable to download the images and the message I got was, "7 tabs do not have permission."

As a test, I downloaded and installed version 2.5.6, and it works, I was able to get the images that I wanted.

Another issue with version 3.0.0 is inconsistent settings, when I set my customized settings and I close and open my browser, my settings vanish.

These issues do not happen with version 2.5.6, so until then, I'm sticking to version 2.5.6.

If you would like to help translate this addon into your language please join the Crowdin project.

Alternatively you may create a pull request with messages.json that you have edited.

I tried saving images from different sites, but the error message was the same.

Browser Console:
rule: <, filename: <, valid: false background.js:289:7
rule: n, filename: n, valid: true background.js:289:7
Error: "Invalid filename generated: images/n" background.js:516:19

I have a lot of (lets say several hundred) opened tabs with pictures in it.
Every time, I press the button, I get, (depending on which tab I am)

• no message, but also no savings
• Message: "User cancelled. Failed downloads: 1 1 Tabs do not have permisson"
  So: Why are the others not saved?
  Which tab does not have permission?
  At least more information would be nice to find ot why and which of the image(s) could not be downloaded.
  And if one image cannot be downoaded: Why not download the others?
  Ralf

As of version 2.1.0, which Firefox forcefully upgraded me to, the addon simply doesn't work any more. Whenever I try to save any images, the icon shows the addon working for a bit then says 0, despite having tabs with images beyond the minimum resolution setting. If I enable "Show notification popups" I get the error Failed: 1 in the system tray.

Firefox 61.0.2 64bit, Linux openSUSE Tumbleweed x64 KDE, Tab Image Saver 2.1.0.

Ever since the update, the active tab doesn't get included when downloading images. I like to have the active tab selected and then get all images to the right of it as well to make icons with. Here are my settings:

So I'll have like 9 tabs open with images and it grabs the other 8 but not the one in the active tab.

It would be awesome if you could add the option to create domain specific rules. I've got the problem that some image sites use the same image names for multiple galleries (e.g. page numbers or always "index") while others use hashes. Adding the tab title helps but i have to manually change the rule order for some sites because they use tag lists as title (for example) - causing complete chaos.

Allowing to filter rules by host would help greatly with fine-tuning a proper name-scheme.

Thanks for the great addon!

Hey,

I can't figure out how to replace all forscores in a tabTitle with an underscore.
Common JavaScript regex don't seem to work.
Could you please give us an example?

Let's say I download images from one host, so my images are saved as:

<basedir>\<host>\img_001.png
<basedir>\<host>\img_002.png
<basedir>\<host>\img_003.png
<basedir>\<host>\img_004.png

Some time passed and I want to download some other images for the same host, currently I have two options:

• overwrite (I lose old images and don't want that)
• rename (<basedir>\<host>\img_001_(1).png etc) - this can work, but also breaks image order.

Is it possible to check last image number in folder and start from incrementing that number?
So in the case above where images 001-004 exist, if we start a new download, start it from 005?

I guess I'm proposing adding third option to Duplicate filename action: append.

Options:
#########################
Default action
Right of current tab
Include current tab: true
Restrict to image tabs: false

Dimensions (pixels)
Min width: 100
Max width: 100

Duplicate filename action
Rename (automatic)

Finished downloading

Close tabs: true
Hide from download history: false
Show notification popup: true

###########################

Expected behavior: Saves the biggest image in each tab right from current tab including current tab to the default download folder and closes the tabs afterwards

Current behavior: Popup shows "0 images downloaded", no images saved to download folder, tabs still open

I'm running Firefox Quantum 57.0 (64 Bit) on a Windows 7 Ultimate Version 6.1 (Build 7601: Service Pack 1)

I have 15 tabs and set shorcut to dl from all tabs but it only dl's pics from 13 tabs when pressing shorcut,double checked it.Include current tab is ticked and max concurrent dl's is set to 17

Hi,
the addon works fine with saving the images but i noticed that in the process of saving, the addon specifically downloads the image again from image url. can it be possible to just save the image without downloading again?
Thank you.

It is possible to save the images in the same order the tabs are open?
Or the option to use part of the url as the image name?

Thank you in advance!

Would you consider porting this extension to Chrome and publishing it in the Web Store? As of now, all the bulk image saving extensions in there either don't do what I need or haven't been updated in years, and your extension is what I've been using on Firefox since the Quantum update.

Some website doesn't provide good file name in the URL example with 500px:

https://drscdn.500px.org/photo/113791545/q%3D80_m%3D2000/v2?user_id=13376435&webp=true&sig=4a16c4eeb21c9eb9ab9f780b69b293b50dc5d62c4d2f38df98a79caf9bf775e4

It will be saved as "v2?user_id=13376435&webp=true&sig=4a16c4eeb21c9eb9ab9f780b69b293b50dc5d62c4d2f38df98a79caf9bf775e4" while the page title is "stock-photo-113791545.jpg"

So I guess it would be nice to have a white list that use Page title instead of the URL for the file name.

I downloaded it. Default everything. Icon shows up, click button on active tab, always get same response. ANY site, ANY image.

subj

i have a suggestion. can you add an option for it to ignore spacer images. perhaps add a function that says do not download images with filenames spacer.gif spacer.png etc but make it so it still downloads the next biggest image.

Is there a functionality / related extension that will save all images in a tab (instead of the largest in each tab)?

Hello.

I found this extension recently while trying to find an alternative to Bazzacuda Image Saver. The old XUL version is not usable anymore, and a more recent version with the same name has very faulty image detection in tabs. But Tab Image Saver does work fine on image-only tabs, even on all-tabs regardless of position, which is excellent for my needs.
However, it seems the only way to change destination folder is to go into options and change it manually, or define a domain-specific rule. It is a common case to want to download images from the same domain into different content folders.
The webext Bazzacuda gives this menu

when left-clicking on the extension icon. Perhaps something similar could be done for TIS?

Of course I'm aware of the webext limitations which this one is also subjected to, just relative-to-download-folder paths like the per-domain ones will be perfect.

Regards.

When I quit Firefox, I use the session restore feature... and I have noticed issues using Tab Image Saver:

• Having "about:" tabs unloaded cause errors like this when I press the Tab Image Saver button:
  waitForTabs Error: "Illegal URL: about:newtab"
• I tend to have lot of unloaded tabs when opening Firefox, it would be nice to have an option to just skip "unloaded" tabs instead of reloading them.

You can easily reproduce the first issue by:

1. Opening a few tabs including about:newtab, about:preferences
2. Enable restore previous session option from Firefox
3. Quit Firefox with about: tabs opened
4. Start Firefox
5. Load a picture URL
6. Press Tab Image Saver button.
7. You will get the error in debugger

For now I was keeping version 1.3.0 because it would work flawless and quicker, but I figure I would help improve the add-on which has cool features and as I'm a webext developer as well.

Pic related. My bookmarks or my history should be in there, not this add-on's goddamn menu

.

Used to save the images with their filenames, now all I get is a random 10 digit numeric name.

Searched and searched and can't find anywhere to save with original file names.

For example, images URL like https://www.example.com/ss17_2000x.jpg?v=1497020526 will be save into folder incorrectly with the ending ?v=1497020526 being saved.

Your latest update worked fine with 67.0.1, but, as soon as I updated to 67.0.2, it sais "Failed downloads: n", n beeing the correct number of tabs with images(images opened in new tabs).

I tend to have lot of unloaded tabs when opening Firefox, it would be nice to have an option to just skip "unloaded" tabs instead of reloading them. I think version 1.3.0 skip those tabs because it's way quicker !

Originally posted by @AntoineTurmel in #25 (comment)

Hello,
first thanks a lot for your web extension ! I was using Bazzacuda but obviously it gets incompatible with Firefox 57.
If I had one suggestion: is it possible to let the user choose a folder outside the Download folder ?
I use to choose a sub-folder inside my Image folder.

Barracuda Image Saver+ (down not work with FF57+) has the feature to detect duplicates (based on hash value).

If already downloaded / identical file exists, then skip downloading instead of renaming or overwriting.

Even if no hash value will be made, then please only add the option to skip downlad as third option to available "rename" and "overwrite".

Thank you.

Is there a way for the addon to pull images from the disk cache in Firefox? I am using ver. 64, 64bit. I have Firefox installed on a 4GB ram drive, as well as the cache. It would be awesome if it could just retrieve the images from the ram drive rather than downloading each one again, even after they have been opened in a tab and downloaded once already.

Thanks for your time.

I've noticed this add-on is unable to save images from pixiv.net, instead saving empty files with the same filename. This is a behaviour I've noticed in Firefox itself too, where dragging a Pixiv image into a folder to save it creates an empty file, while right clicking and saving it succeeds. I think you have to make a free account to access full resolution images on the site, but you can still see lower resolution images failing to save without doing this. Here are a couple of example links if wanted:
https://www.pixiv.net/member_illust.php?mode=medium&illust_id=22014425
https://www.pixiv.net/member_illust.php?mode=medium&illust_id=21991924

Don't know if this trigger issue is a FF bug or not, since I experienced something similar with another add-on. (NoSquint Plus unwilling to save preferences)

FF 61.0.1 on Linux

Is there any chance an option for only active tabs for left, right, and all to be downloaded? I work with a lot of tabs, and I would like it if only my 30 active tabs had its images downloaded, not 180 tabs. This causes my Firefox to overload my ram and it freezes.

I would appreciate if you could implement this.

Hello :)
First i want to say thanks for this extension! it's very helpful :)
But i have a problem, after the first install the program working great, but after i exit Firefox, and open the browser again the add-on is not downloading images at all, nothing.
I figured to solve this problem by - uninstalling the add-on - exit firefox - enter firefox again - install the add-on and that should work, until i exit again from the browser.

I've been downloading a ton of images, and I'm noticing occasionally the extension slows way down... where I click on 'download' and 5-6 seconds pass before I can click it again. The files are only about 5mb, there are no other active downloads... not sure what's causing the slow down. In addition, it doesn't happen consistently... same site, other times, works just fine.